All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: <cgel.zte@gmail.com>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<linux-omap@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Minghao Chi <chi.minghao@zte.com.cn>,
	Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] net: ethernet: ti: cpsw: using pm_runtime_resume_and_get instead of pm_runtime_get_sync
Date: Tue, 12 Apr 2022 12:49:39 +0300	[thread overview]
Message-ID: <78ec4bb7-b575-2554-9a29-e25c28022bdf@ti.com> (raw)
In-Reply-To: <20220412082847.2532584-1-chi.minghao@zte.com.cn>



On 12/04/2022 11:28, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> Using pm_runtime_resume_and_get() to replace pm_runtime_get_sync and
> pm_runtime_put_noidle. This change is just to simplify the code, no
> actual functional changes.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
>   drivers/net/ethernet/ti/cpsw.c | 36 ++++++++++++----------------------
>   1 file changed, 12 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 03575c017500..9f37b5b196a5 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -756,11 +756,9 @@ static int cpsw_ndo_open(struct net_device *ndev)
>   	int ret;
>   	u32 reg;
>   
> -	ret = pm_runtime_get_sync(cpsw->dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(cpsw->dev);
> +	ret = pm_runtime_resume_and_get(cpsw->dev);
> +	if (ret < 0)
>   		return ret;
> -	}
>   
>   	netif_carrier_off(ndev);
>   
> @@ -968,11 +966,9 @@ static int cpsw_ndo_set_mac_address(struct net_device *ndev, void *p)
>   	if (!is_valid_ether_addr(addr->sa_data))
>   		return -EADDRNOTAVAIL;
>   
> -	ret = pm_runtime_get_sync(cpsw->dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(cpsw->dev);
> +	ret = pm_runtime_resume_and_get(cpsw->dev);
> +	if (ret < 0)
>   		return ret;
> -	}
>   
>   	if (cpsw->data.dual_emac) {
>   		vid = cpsw->slaves[priv->emac_port].port_vlan;
> @@ -1052,11 +1048,9 @@ static int cpsw_ndo_vlan_rx_add_vid(struct net_device *ndev,
>   	if (vid == cpsw->data.default_vlan)
>   		return 0;
>   
> -	ret = pm_runtime_get_sync(cpsw->dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(cpsw->dev);
> +	ret = pm_runtime_resume_and_get(cpsw->dev);
> +	if (ret < 0)
>   		return ret;
> -	}
>   
>   	if (cpsw->data.dual_emac) {
>   		/* In dual EMAC, reserved VLAN id should not be used for
> @@ -1090,11 +1084,9 @@ static int cpsw_ndo_vlan_rx_kill_vid(struct net_device *ndev,
>   	if (vid == cpsw->data.default_vlan)
>   		return 0;
>   
> -	ret = pm_runtime_get_sync(cpsw->dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(cpsw->dev);
> +	ret = pm_runtime_resume_and_get(cpsw->dev);
> +	if (ret < 0)
>   		return ret;
> -	}
>   
>   	if (cpsw->data.dual_emac) {
>   		int i;
> @@ -1567,11 +1559,9 @@ static int cpsw_probe(struct platform_device *pdev)
>   	/* Need to enable clocks with runtime PM api to access module
>   	 * registers
>   	 */
> -	ret = pm_runtime_get_sync(dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(dev);
> +	ret = pm_runtime_resume_and_get(dev);
> +	if (ret < 0)
>   		goto clean_runtime_disable_ret;
> -	}
>   
>   	ret = cpsw_probe_dt(&cpsw->data, pdev);
>   	if (ret)
> @@ -1734,11 +1724,9 @@ static int cpsw_remove(struct platform_device *pdev)
>   	struct cpsw_common *cpsw = platform_get_drvdata(pdev);
>   	int i, ret;
>   
> -	ret = pm_runtime_get_sync(&pdev->dev);
> -	if (ret < 0) {
> -		pm_runtime_put_noidle(&pdev->dev);
> +	ret = pm_runtime_resume_and_get(&pdev->dev);
> +	if (ret < 0)
>   		return ret;
> -	}
>   
>   	for (i = 0; i < cpsw->data.slaves; i++)
>   		if (cpsw->slaves[i].ndev)

Thank you.
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

-- 
Best regards,
Grygorii, Ukraine

  reply	other threads:[~2022-04-12 10:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-12  8:28 [PATCH] net: ethernet: ti: cpsw: using pm_runtime_resume_and_get instead of pm_runtime_get_sync cgel.zte
2022-04-12  9:49 ` Grygorii Strashko [this message]
2022-04-12 22:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=78ec4bb7-b575-2554-9a29-e25c28022bdf@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=cgel.zte@gmail.com \
    --cc=chi.minghao@zte.com.cn \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=zealci@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.