From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A8A8C433DB for ; Fri, 15 Jan 2021 11:28:12 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3E8F221F7 for ; Fri, 15 Jan 2021 11:28:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3E8F221F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.67982.121562 (Exim 4.92) (envelope-from ) id 1l0NGk-0005UX-57; Fri, 15 Jan 2021 11:27:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 67982.121562; Fri, 15 Jan 2021 11:27:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l0NGk-0005UQ-20; Fri, 15 Jan 2021 11:27:54 +0000 Received: by outflank-mailman (input) for mailman id 67982; Fri, 15 Jan 2021 11:27:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l0NGj-0005UK-6H for xen-devel@lists.xenproject.org; Fri, 15 Jan 2021 11:27:53 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 96c46947-71d2-4f44-8c98-62d14783cc14; Fri, 15 Jan 2021 11:27:51 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 18951ACB0; Fri, 15 Jan 2021 11:27:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96c46947-71d2-4f44-8c98-62d14783cc14 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1610710071; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A2xZ5D+Cey4Q8W7tlZo5yST/p+SZDyne2XZwrRO6IPE=; b=iAeCuT1vlpDu4bmekBc1Sa9XVmmoRfnTBoQIxZbWT0l8qTqM0ms68b7ooeSNi4kc0sGrqh ZAt2x8S6+OCQN8EiA8chZor7uDVegAUWgZNjga3nyiobf5B5+i5KrqS2HqVe+3/2O+nQgW vcU+bVbM6L+jCxJJvBCjm4SbxPjr+xU= Subject: Re: [PATCH 1/3] introduce unaligned.h To: Andrew Cooper Cc: George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , M A Young , "xen-devel@lists.xenproject.org" References: <0eba95b9-66eb-2692-1da1-c27784b9f51e@suse.com> <12f26ab9-8a8c-19f0-ea65-8b354bd326a6@suse.com> <8c459039-a27a-01e5-0143-7c9b6e019e42@citrix.com> From: Jan Beulich Message-ID: <78ecd61e-bdfb-169c-1db3-b9914fca7f3d@suse.com> Date: Fri, 15 Jan 2021 12:27:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <8c459039-a27a-01e5-0143-7c9b6e019e42@citrix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 15.01.2021 12:13, Andrew Cooper wrote: > On 15/01/2021 10:05, Jan Beulich wrote: >> Rather than open-coding commonly used constructs in yet more places when >> pulling in zstd decompression support (and its xxhash prereq), pull out >> the custom bits into a commonly used header (for the hypervisor build; >> the tool stack and stubdom builds of libxenguest will still remain in >> need of similarly taking care of). For now this is limited to x86, where >> custom logic isn't needed (considering this is going to be used in init >> code only, even using alternatives patching to use MOVBE doesn't seem >> worthwhile). >> >> No change in generated code. >> >> Signed-off-by: Jan Beulich >> --- >> Iirc use of include/asm-generic/ was disliked, hence the generic header >> goes into include/xen/. > > Really?  I think its going to be the only sane way of fixing up some of > our header tangle. > > This series probably isn't the right place to fix this argument, so > Acked-by: Andrew Cooper Thanks. > However, presumably we're going to want an ARM side of this imminently? Why? It's only used (and going to be further used) by code not built for Arm. So while it certainly would be nice for such a header to also appear there (and the x86-special casing going away in patch 2), it's not a strict requirement at this point. Therefore I'd prefer to leave this to the Arm maintainers (and probably for 4.16). Jan