From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C1DCCA481 for ; Thu, 30 Jun 2022 18:33:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236689AbiF3Sds (ORCPT ); Thu, 30 Jun 2022 14:33:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236695AbiF3Sdq (ORCPT ); Thu, 30 Jun 2022 14:33:46 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD1A225E9B for ; Thu, 30 Jun 2022 11:33:43 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id z19so27653558edb.11 for ; Thu, 30 Jun 2022 11:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=yJGEttsMIPFNExRUVjMuioYnkzWMdO3yRAB963cFp2o=; b=bVZKc01WEs5LMjU5JtELjSXU1pShwhHGLZhNmZYt3wfTdiQE/yN2UAshZdvCOv8QGq jvuwowiNtOjr5posUthWXU7PWhNZt5GOF4X2vS97DTQrhkMDd85y2516gnqfIuFFlh2I ruddBdJWCPzK2JSEvz6DATLXX11xi0ZKag2bf5Laj6MHMpCI7ursQwhCZpecYj90tw5h nPUB4qcjaCKLvbhHoLjfivF0IkdS9P0U2XM5vlr2MQX+1XbAOzaKqW9xv/xG0frtmHy6 SsZzW6ElgdT4rkY8rdjUlQFfxOrx2HPWseOs3kKWIzs1pfoxsos6mZK6KSJsuFIKNtoI Jsqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=yJGEttsMIPFNExRUVjMuioYnkzWMdO3yRAB963cFp2o=; b=gF/p44TiuWYV6qoyaJ69W1UbtGV0t/+Ol54aqBD80Sl9sLXKBPHkehG3w+2ex8CP+v puzHFYXA9b+rEdoeFYGcFok8pE0uoy96vhmeTTK09WgIZmFt8ghuKE6RpT5ziiIABpC6 9GRe4Y2oa96xzRqIA5hqxWtX2WXgIWAg8coU5hGgvNMXQR7oozUJKtKWGPO4omz2A1hI XYkkFPQ6+iBwpYUT91vpxlFxNW+TiVBjZUa8CvrGxlxlcLsAupNYjvhtnNi/2GVw+Z8t 4B8+lBL1vxcG/xnx/T4ojSqD6EnVB44WvrVPoGrrxjbLw7lN7ZGdLon9DGSeKCk0arQ2 OsUw== X-Gm-Message-State: AJIora/juQLyz04jt0gI0BGVDXSMiFIAH3w54vSZzsN1E7h1DwIlozNA 9gjyM+q7GuSSH+kBQMotpZNXRA== X-Google-Smtp-Source: AGRyM1s8xy762cCi9FZl1Kcj0KeKPHclcEopngQ5Us/lz3lUXqlZKh+6oqktKAwNKh4wiC/U7Zn6jA== X-Received: by 2002:a05:6402:3708:b0:433:2d3b:ed5 with SMTP id ek8-20020a056402370800b004332d3b0ed5mr13495310edb.246.1656614022289; Thu, 30 Jun 2022 11:33:42 -0700 (PDT) Received: from [192.168.0.190] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id w3-20020a1709067c8300b00722fc0779e3sm9482072ejo.85.2022.06.30.11.33.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jun 2022 11:33:41 -0700 (PDT) Message-ID: <78faf75d-80b7-7a0e-e306-6351dbe5133c@linaro.org> Date: Thu, 30 Jun 2022 20:33:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v6 02/14] dt-bindings: pinctrl: imx: Add fsl,scu-iomux yaml file Content-Language: en-US To: "Viorel Suman (OSS)" Cc: Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Dmitry Torokhov , Srinivas Kandagatla , Dong Aisheng , Fabio Estevam , Shawn Guo , Stefan Agner , Pengutronix Kernel Team , Linus Walleij , Alessandro Zummo , Alexandre Belloni , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Wim Van Sebroeck , Guenter Roeck , Sascha Hauer , NXP Linux Team , Abel Vesa , Viorel Suman , Oliver Graute , Liu Ying , Mirela Rabulea , Peng Fan , Ming Qian , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-input@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org, linux-pm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220629164414.301813-1-viorel.suman@oss.nxp.com> <20220629164414.301813-3-viorel.suman@oss.nxp.com> <20220630123754.esbuac4pfktlseh2@fsr-ub1664-116> From: Krzysztof Kozlowski In-Reply-To: <20220630123754.esbuac4pfktlseh2@fsr-ub1664-116> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 30/06/2022 14:37, Viorel Suman (OSS) wrote: > On 22-06-29 19:53:51, Krzysztof Kozlowski wrote: >> On 29/06/2022 18:44, Viorel Suman (OSS) wrote: >>> From: Abel Vesa >>> >>> In order to replace the fsl,scu txt file from bindings/arm/freescale, >>> we need to split it between the right subsystems. This patch documents >>> separately the 'iomux/pinctrl' child node of the SCU main node. >>> >>> Signed-off-by: Abel Vesa >>> Signed-off-by: Viorel Suman >>> --- >>> .../bindings/pinctrl/fsl,scu-pinctrl.yaml | 68 +++++++++++++++++++ >>> 1 file changed, 68 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml >>> new file mode 100644 >>> index 000000000000..76a2e7b28172 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml > [...] >>> + fsl,pins: >>> + description: >>> + each entry consists of 3 integers and represents the pin ID, the mux value >>> + and config setting for the pin. The first 2 integers - pin_id and mux_val - are >>> + specified using a PIN_FUNC_ID macro, which can be found in >>> + . The last integer CONFIG is >>> + the pad setting value like pull-up on this pin. Please refer to the >>> + appropriate i.MX8 Reference Manual for detailed CONFIG settings. >>> + $ref: /schemas/types.yaml#/definitions/uint32-matrix >> >> Look at fsl,imx8mq-pinctrl.yaml. Each item is described (items under items). > > Added them initially, but later dropped because of some logs like > "pinctrl@xxxxxxx: usdhc1grp:fsl,pins:0: [...] is too long" shown by > "make dt_binding_check dtbs_check DT_SCHEMA_FILES=[...]/fsl,scu-pinctrl.yaml" > > Same logs are shown for "fsl,imx8mq-pinctrl.yaml". Will add the items description in the next > version. > The fsl,imx8mq-pinctrl.yaml should be correct and I don't see the reason why dtschema complains in some of the entries. It's like one define was not correct... I'll take a look at this later, but anyway keep the same as fsl,imx8mq-pinctrl.yaml even if it complains. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AB64C43334 for ; Thu, 30 Jun 2022 18:35:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qyfMuDf6mlH2fKr2uuq2DVT/LaDk5gCVg/bkUaBFEGA=; b=f5eMoU48Amf4gE 3d5N7A2k5dVwy67PfkH3fwUNkw04pJZRBwr6cT38NPSRxRgCmQWE42KbMRpI1GuwAV2ovxLOWVpMK oz8pfmgXb7lcCpws/qcz1Wp59d8PLNPyaM0CY9MJaQDDiNw1g0mFNY4LR4ys3dhelQXfychVX71fJ rseU+7+0ePeYkTP3i3jlk14i9BcRxojWBYROFGJw/jiRYemzwVWCdLmpQmiYZgzyKRPjmfDK3YGbn 3I8MiBZwSxmQ4amEKnELxueAD2PJsG87f8HHtXMT4EsB6vJJ3TX6vFsPoK8V1Wezhs95UTD1pB9ka IYeHjkWW+3SlelI2CEyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6yz5-00149i-Uk; Thu, 30 Jun 2022 18:33:48 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6yz2-00148o-Ab for linux-arm-kernel@lists.infradead.org; Thu, 30 Jun 2022 18:33:45 +0000 Received: by mail-ed1-x529.google.com with SMTP id z41so42653ede.1 for ; Thu, 30 Jun 2022 11:33:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=yJGEttsMIPFNExRUVjMuioYnkzWMdO3yRAB963cFp2o=; b=bVZKc01WEs5LMjU5JtELjSXU1pShwhHGLZhNmZYt3wfTdiQE/yN2UAshZdvCOv8QGq jvuwowiNtOjr5posUthWXU7PWhNZt5GOF4X2vS97DTQrhkMDd85y2516gnqfIuFFlh2I ruddBdJWCPzK2JSEvz6DATLXX11xi0ZKag2bf5Laj6MHMpCI7ursQwhCZpecYj90tw5h nPUB4qcjaCKLvbhHoLjfivF0IkdS9P0U2XM5vlr2MQX+1XbAOzaKqW9xv/xG0frtmHy6 SsZzW6ElgdT4rkY8rdjUlQFfxOrx2HPWseOs3kKWIzs1pfoxsos6mZK6KSJsuFIKNtoI Jsqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=yJGEttsMIPFNExRUVjMuioYnkzWMdO3yRAB963cFp2o=; b=X+xXDPjvj5HxTvKEMP4G8Rq5V74M5brCcFeB74DJUbqYTI6mt5ZmuBgnlC3wORoZMO AoHnDQrTYImK0bYQlBwY1mlB0lOfSsR8cmipNP7pYowHda3bfBOo+gjm8Fav/0gwOn6S lz1W6OG7DjBE5pOYr8LK2+jBdQ8Jz8t3tuOh8d2CKd5ZM7xz6szTWfF1VgovQxXpoZQE +6L3aof3EeW3PbVGeLBfJAq5I6KLANWwLk4rZL1yM3XMjlD8sdLAxXVPwR9u+MfPcRIp TLY5GF8O57Td1N4rKFmKmBMggnHLm2PPHZA+iCLnNchVbYuXHwXRHX7uBMMlNa6Bjuvh yV5A== X-Gm-Message-State: AJIora8fXb9rC/Rxxq3VxTCtyD/KUwKyC32xVoxW/eyqh1GAWldUs1Ws lt/GLsyLFK6bphaGrpchbgkonA== X-Google-Smtp-Source: AGRyM1s8xy762cCi9FZl1Kcj0KeKPHclcEopngQ5Us/lz3lUXqlZKh+6oqktKAwNKh4wiC/U7Zn6jA== X-Received: by 2002:a05:6402:3708:b0:433:2d3b:ed5 with SMTP id ek8-20020a056402370800b004332d3b0ed5mr13495310edb.246.1656614022289; Thu, 30 Jun 2022 11:33:42 -0700 (PDT) Received: from [192.168.0.190] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id w3-20020a1709067c8300b00722fc0779e3sm9482072ejo.85.2022.06.30.11.33.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jun 2022 11:33:41 -0700 (PDT) Message-ID: <78faf75d-80b7-7a0e-e306-6351dbe5133c@linaro.org> Date: Thu, 30 Jun 2022 20:33:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v6 02/14] dt-bindings: pinctrl: imx: Add fsl,scu-iomux yaml file Content-Language: en-US To: "Viorel Suman (OSS)" Cc: Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Dmitry Torokhov , Srinivas Kandagatla , Dong Aisheng , Fabio Estevam , Shawn Guo , Stefan Agner , Pengutronix Kernel Team , Linus Walleij , Alessandro Zummo , Alexandre Belloni , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Wim Van Sebroeck , Guenter Roeck , Sascha Hauer , NXP Linux Team , Abel Vesa , Viorel Suman , Oliver Graute , Liu Ying , Mirela Rabulea , Peng Fan , Ming Qian , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-input@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org, linux-pm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220629164414.301813-1-viorel.suman@oss.nxp.com> <20220629164414.301813-3-viorel.suman@oss.nxp.com> <20220630123754.esbuac4pfktlseh2@fsr-ub1664-116> From: Krzysztof Kozlowski In-Reply-To: <20220630123754.esbuac4pfktlseh2@fsr-ub1664-116> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220630_113344_428639_C8A9A9CE X-CRM114-Status: GOOD ( 19.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/06/2022 14:37, Viorel Suman (OSS) wrote: > On 22-06-29 19:53:51, Krzysztof Kozlowski wrote: >> On 29/06/2022 18:44, Viorel Suman (OSS) wrote: >>> From: Abel Vesa >>> >>> In order to replace the fsl,scu txt file from bindings/arm/freescale, >>> we need to split it between the right subsystems. This patch documents >>> separately the 'iomux/pinctrl' child node of the SCU main node. >>> >>> Signed-off-by: Abel Vesa >>> Signed-off-by: Viorel Suman >>> --- >>> .../bindings/pinctrl/fsl,scu-pinctrl.yaml | 68 +++++++++++++++++++ >>> 1 file changed, 68 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml >>> new file mode 100644 >>> index 000000000000..76a2e7b28172 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,scu-pinctrl.yaml > [...] >>> + fsl,pins: >>> + description: >>> + each entry consists of 3 integers and represents the pin ID, the mux value >>> + and config setting for the pin. The first 2 integers - pin_id and mux_val - are >>> + specified using a PIN_FUNC_ID macro, which can be found in >>> + . The last integer CONFIG is >>> + the pad setting value like pull-up on this pin. Please refer to the >>> + appropriate i.MX8 Reference Manual for detailed CONFIG settings. >>> + $ref: /schemas/types.yaml#/definitions/uint32-matrix >> >> Look at fsl,imx8mq-pinctrl.yaml. Each item is described (items under items). > > Added them initially, but later dropped because of some logs like > "pinctrl@xxxxxxx: usdhc1grp:fsl,pins:0: [...] is too long" shown by > "make dt_binding_check dtbs_check DT_SCHEMA_FILES=[...]/fsl,scu-pinctrl.yaml" > > Same logs are shown for "fsl,imx8mq-pinctrl.yaml". Will add the items description in the next > version. > The fsl,imx8mq-pinctrl.yaml should be correct and I don't see the reason why dtschema complains in some of the entries. It's like one define was not correct... I'll take a look at this later, but anyway keep the same as fsl,imx8mq-pinctrl.yaml even if it complains. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel