On 5/6/22 07:18, Lucas Mateus Castro(alqotel) wrote:XX3 and MMIRR_XX3 are in different decodetree files, I'll change all instructions to use MMIRR_XX3 for the next patch but I'll have to change MMIRR_XX3 declaration in target/ppc/insn64.decode to have an !extern in it (since it'll need to also be declared in target/ppc/insn32.decode)
+{
+ arg_MMIRR_XX3 m;
+ m.xa = a->xa;
+ m.xb = a->xb;
+ m.xt = a->xt;
+ m.pmsk = 0xFF;
+ m.ymsk = 0xF;
+ m.xmsk = 0xF;
+ return do_ger_MMIRR_XX3(ctx, &m, helper);
}
Is XX3 going to be used for anything else? Is it worthwhile to move these into the
decoder as explicit assignments?
Either way,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~