From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E134EC433ED for ; Thu, 6 May 2021 16:08:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB41C61078 for ; Thu, 6 May 2021 16:08:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235846AbhEFQJd (ORCPT ); Thu, 6 May 2021 12:09:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235176AbhEFQJa (ORCPT ); Thu, 6 May 2021 12:09:30 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24D33C061761 for ; Thu, 6 May 2021 09:08:32 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1legY7-0002z8-8C; Thu, 06 May 2021 18:08:27 +0200 Message-ID: <7900502879b346e18727f956965ace34a146c0f1.camel@pengutronix.de> Subject: Re: [RESEND v4 1/2] dt-bindings: imx6q-pcie: add one regulator used to power up pcie phy From: Lucas Stach To: lorenzo.pieralisi@arm.com Cc: linux-pci@vger.kernel.org, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Richard Zhu , andrew.smirnov@gmail.com, shawnguo@kernel.org, kw@linux.com, bhelgaas@google.com, stefan@agner.ch Date: Thu, 06 May 2021 18:08:24 +0200 In-Reply-To: <1617091701-6444-2-git-send-email-hongxing.zhu@nxp.com> References: <1617091701-6444-1-git-send-email-hongxing.zhu@nxp.com> <1617091701-6444-2-git-send-email-hongxing.zhu@nxp.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lorenzo, have those two patches fallen through some crack? AFAICS they are gone from patchwork, but I also can't find them in any branch in the usual git repos. Regards, Lucas Am Dienstag, dem 30.03.2021 um 16:08 +0800 schrieb Richard Zhu: > Both 1.8v and 3.3v power supplies can be used by i.MX8MQ PCIe PHY. > In default, the PCIE_VPH voltage is suggested to be 1.8v refer to data > sheet. When PCIE_VPH is supplied by 3.3v in the HW schematic design, > the VREG_BYPASS bits of GPR registers should be cleared from default > value 1b'1 to 1b'0. Thus, the internal 3v3 to 1v8 translator would be > turned on. > > Signed-off-by: Richard Zhu > Reviewed-by: Lucas Stach > --- >  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 3 +++ >  1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > index de4b2baf91e8..d8971ab99274 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > @@ -38,6 +38,9 @@ Optional properties: >    The regulator will be enabled when initializing the PCIe host and >    disabled either as part of the init process or when shutting down the >    host. > +- vph-supply: Should specify the regulator in charge of VPH one of the three > + PCIe PHY powers. This regulator can be supplied by both 1.8v and 3.3v voltage > + supplies. >   > >  Additional required properties for imx6sx-pcie: >  - clock names: Must include the following additional entries: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D23C0C433B4 for ; Thu, 6 May 2021 16:10:06 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 744BE610A1 for ; Thu, 6 May 2021 16:10:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 744BE610A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:Cc:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N9nFRbHytIiV9smwYMqweI1aiXupKXuyXWTmGcL8fxg=; b=C0SCg2V81pQVhRZhV/otiwITF lBflzcfkVSpQzyNLxRtTF2EVEW1NzfuwsG0z+5VVIpCZ3emBjWewNJ3QBiXeEcTOuYZ1n03lWM1vT ls2WPpG7CGPhPkRIwMMleB7R5kSC1nCUzq8pfn5n8N24SMAVon8ljVFSL1sCTKrkQV+sQrvxIVwko HDIqUUMwtfvCA774i2n2Ynn50rX7LUlSQrw8W2cgjVrNfsPamMGCJg6bQQoVs+ZXjufgzDKByHYff tx0Wzjcp0NvgZYQ/kn3hlbGyRu7dlXuYmZrB2w9gAcHdbiJAclCjgwfOyAhIfiKolPXfEzZ1IIzov 2pJCzYh9A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1legYK-004lIr-Td; Thu, 06 May 2021 16:08:41 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1legYH-004lIT-K9 for linux-arm-kernel@desiato.infradead.org; Thu, 06 May 2021 16:08:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=1Q5dNTrCJtGTUnFAAF/YqMlKgi3nzHaqE59ClaKI744=; b=QYRbnPItogvKXJjAhx5qcCauiR JbCkd1GsHJjvSm/6LMIQol7/Q6/PYM5D1JBvjNCf14wk9o+DEz5u871SFx3hQL1Pq9WJvW+gurHms QB1EutssjA1T5aRxkNkp2aET+4AcBxw1kiZ+TEd7tOVBQJSAKhQQGAfTI3JzQ5yo19xCHtKII8kYl rqyCWPgHLWyKV4TrWRqsXZbL7CFsMXAbUNAefMtUyIK7yxIVhulhG+9UnZg1Um6guV6ad1/lGlGvd oJQYRZBPmoxWzt2Rbbw1t9VEBD8kn6ijVoN1I37uJN9+qvNN6vYOPwaDHAJH190+M2GQqVM8Mv9f/ yFZAiHGQ==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1legYE-006CUm-W0 for linux-arm-kernel@lists.infradead.org; Thu, 06 May 2021 16:08:36 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1legY7-0002z8-8C; Thu, 06 May 2021 18:08:27 +0200 Message-ID: <7900502879b346e18727f956965ace34a146c0f1.camel@pengutronix.de> Subject: Re: [RESEND v4 1/2] dt-bindings: imx6q-pcie: add one regulator used to power up pcie phy From: Lucas Stach To: lorenzo.pieralisi@arm.com Cc: linux-pci@vger.kernel.org, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Richard Zhu , andrew.smirnov@gmail.com, shawnguo@kernel.org, kw@linux.com, bhelgaas@google.com, stefan@agner.ch Date: Thu, 06 May 2021 18:08:24 +0200 In-Reply-To: <1617091701-6444-2-git-send-email-hongxing.zhu@nxp.com> References: <1617091701-6444-1-git-send-email-hongxing.zhu@nxp.com> <1617091701-6444-2-git-send-email-hongxing.zhu@nxp.com> User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210506_090835_046418_E9A99DE1 X-CRM114-Status: GOOD ( 16.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTG9yZW56bywKCmhhdmUgdGhvc2UgdHdvIHBhdGNoZXMgZmFsbGVuIHRocm91Z2ggc29tZSBj cmFjaz8gQUZBSUNTIHRoZXkgYXJlIGdvbmUKZnJvbSBwYXRjaHdvcmssIGJ1dCBJIGFsc28gY2Fu J3QgZmluZCB0aGVtIGluIGFueSBicmFuY2ggaW4gdGhlIHVzdWFsCmdpdCByZXBvcy4KClJlZ2Fy ZHMsCkx1Y2FzCgpBbSBEaWVuc3RhZywgZGVtIDMwLjAzLjIwMjEgdW0gMTY6MDggKzA4MDAgc2No cmllYiBSaWNoYXJkIFpodToKPiBCb3RoIDEuOHYgYW5kIDMuM3YgcG93ZXIgc3VwcGxpZXMgY2Fu IGJlIHVzZWQgYnkgaS5NWDhNUSBQQ0llIFBIWS4KPiBJbiBkZWZhdWx0LCB0aGUgUENJRV9WUEgg dm9sdGFnZSBpcyBzdWdnZXN0ZWQgdG8gYmUgMS44diByZWZlciB0byBkYXRhCj4gc2hlZXQuIFdo ZW4gUENJRV9WUEggaXMgc3VwcGxpZWQgYnkgMy4zdiBpbiB0aGUgSFcgc2NoZW1hdGljIGRlc2ln biwKPiB0aGUgVlJFR19CWVBBU1MgYml0cyBvZiBHUFIgcmVnaXN0ZXJzIHNob3VsZCBiZSBjbGVh cmVkIGZyb20gZGVmYXVsdAo+IHZhbHVlIDFiJzEgdG8gMWInMC4gVGh1cywgdGhlIGludGVybmFs IDN2MyB0byAxdjggdHJhbnNsYXRvciB3b3VsZCBiZQo+IHR1cm5lZCBvbi4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBSaWNoYXJkIFpodSA8aG9uZ3hpbmcuemh1QG54cC5jb20+Cj4gUmV2aWV3ZWQtYnk6 IEx1Y2FzIFN0YWNoIDxsLnN0YWNoQHBlbmd1dHJvbml4LmRlPgo+IC0tLQo+IMKgRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9mc2wsaW14NnEtcGNpZS50eHQgfCAzICsrKwo+ IMKgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2ZzbCxpbXg2cS1wY2llLnR4dCBiL0Rv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wY2kvZnNsLGlteDZxLXBjaWUudHh0Cj4g aW5kZXggZGU0YjJiYWY5MWU4Li5kODk3MWFiOTkyNzQgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9mc2wsaW14NnEtcGNpZS50eHQKPiArKysgYi9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2ZzbCxpbXg2cS1wY2llLnR4dAo+ IEBAIC0zOCw2ICszOCw5IEBAIE9wdGlvbmFsIHByb3BlcnRpZXM6Cj4gwqDCoMKgVGhlIHJlZ3Vs YXRvciB3aWxsIGJlIGVuYWJsZWQgd2hlbiBpbml0aWFsaXppbmcgdGhlIFBDSWUgaG9zdCBhbmQK PiDCoMKgwqBkaXNhYmxlZCBlaXRoZXIgYXMgcGFydCBvZiB0aGUgaW5pdCBwcm9jZXNzIG9yIHdo ZW4gc2h1dHRpbmcgZG93biB0aGUKPiDCoMKgwqBob3N0Lgo+ICstIHZwaC1zdXBwbHk6IFNob3Vs ZCBzcGVjaWZ5IHRoZSByZWd1bGF0b3IgaW4gY2hhcmdlIG9mIFZQSCBvbmUgb2YgdGhlIHRocmVl Cj4gKyAgUENJZSBQSFkgcG93ZXJzLiBUaGlzIHJlZ3VsYXRvciBjYW4gYmUgc3VwcGxpZWQgYnkg Ym90aCAxLjh2IGFuZCAzLjN2IHZvbHRhZ2UKPiArICBzdXBwbGllcy4KPiDCoAo+IAo+IMKgQWRk aXRpb25hbCByZXF1aXJlZCBwcm9wZXJ0aWVzIGZvciBpbXg2c3gtcGNpZToKPiDCoC0gY2xvY2sg bmFtZXM6IE11c3QgaW5jbHVkZSB0aGUgZm9sbG93aW5nIGFkZGl0aW9uYWwgZW50cmllczoKCgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJt LWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtl cm5lbAo=