From mboxrd@z Thu Jan  1 00:00:00 1970
From: Santosh Jodh <Santosh.Jodh@citrix.com>
Subject: Re: [PATCH] dump_p2m_table: For IOMMU
Date: Wed, 8 Aug 2012 10:17:17 -0700
Message-ID: <7914B38A4445B34AA16EB9F1352942F1012F0E1E93A1@SJCPMAILBOX01.citrite.net>
References: <68946c7e1d67f823b072.1344441362@REDBLD-XS.ad.xensource.com>
	<5022AE180200007800093B41@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5022AE180200007800093B41@nat28.tlf.novell.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: "wei.wang2@amd.com" <wei.wang2@amd.com>, "Tim (Xen.org)" <tim@xen.org>, "xiantao.zhang@intel.com" <xiantao.zhang@intel.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Thanks Jan. No - it does not compile on x86_32. Who runs x86_32 xen anyway? Just kidding...

BTW, I hate printf format specifiers...

Thanks,
Santosh

-----Original Message-----
From: Jan Beulich [mailto:JBeulich@suse.com] 
Sent: Wednesday, August 08, 2012 9:21 AM
To: Santosh Jodh
Cc: wei.wang2@amd.com; xiantao.zhang@intel.com; xen-devel; Tim (Xen.org)
Subject: Re: [Xen-devel] [PATCH] dump_p2m_table: For IOMMU

>>> On 08.08.12 at 17:56, Santosh Jodh <santosh.jodh@citrix.com> wrote:
> +    if ( table_vaddr == NULL )
> +    {
> +        printk("Failed to map IOMMU domain page %-16lx\n", 
> + page_to_maddr(pg));

Does that build on x86-32? Similar format specifier problems appear to be present elsewhere in the patch.

Jan