All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: Jakub Kicinski <kuba@kernel.org>,
	Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
	<davem@davemloft.net>, <netdev@vger.kernel.org>,
	<pabeni@redhat.com>
Subject: Re: [PULL] Networking for v6.3
Date: Wed, 22 Feb 2023 14:26:31 -0800	[thread overview]
Message-ID: <79180e81-ab37-f287-79fb-06b0974f81ab@intel.com> (raw)
In-Reply-To: <20230222113334.0fb37d5f@kernel.org>



On 2/22/2023 11:33 AM, Jakub Kicinski wrote:
> On Wed, 22 Feb 2023 20:07:21 +0100 Alexander Lobakin wrote:
>>> I suspect it would be as simple as adding a
>>>
>>>         depends on ICE != n
>>>
>>> to that thing, but I didn't get around to testing that. I thought it
>>> would be better to notify the guilty parties.  
>>
>> Patch is on its way already, it just drops the opt and uses CONFIG_GNSS
>> directly.
> 
> You got me slightly worried now. The overall idea of using Kconfig 
> to resolve the dependency and compile out the entire file was right.
> Are you planing to wrap the entire source in IS_REACHABLE() ?

No. The new solution guards the ice_gnss.o with

ice-$(CONFIG_GNSS) += ice_gnss.o

in the Makefile. This works correctly for enabling ice_gnss only if GNSS
is reachable.

Then we exchange the IS_ENABLED that was done only in the ice_gnss.h
header file with IS_REACHABLE(CONFIG_GNSS).

It's exactly the same number of checks as we had on CONFIG_ICE_GNSS but
without the extra unnecessary option, and it compiles  with at least the
following:

GNSS = Y, ICE = Y
GNSS = M, ICE = M
GNSS = M, ICE = Y (disables ice_gnss code)
GNSS = Y, ICE = M

Let me post the patch and we can discuss there.

Thanks,
Jake

  reply	other threads:[~2023-02-22 22:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 23:38 [PULL] Networking for v6.3 Jakub Kicinski
2023-02-22  2:46 ` Linus Torvalds
2023-02-22  3:33   ` Jakub Kicinski
2023-02-22 19:07   ` Alexander Lobakin
2023-02-22 19:33     ` Jakub Kicinski
2023-02-22 22:26       ` Jacob Keller [this message]
2023-02-22  2:50 ` pr-tracker-bot
2023-02-23 17:21 ` Linus Torvalds
2023-02-23 19:06   ` Kalle Valo
2023-02-23 21:37     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79180e81-ab37-f287-79fb-06b0974f81ab@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=arkadiusz.kubalewski@intel.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.