All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Mina Almasry <almasrymina@google.com>
Cc: shuah@kernel.org, rientjes@google.com, shakeelb@google.com,
	gthelen@google.com, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [PATCH v12 2/9] hugetlb_cgroup: add interface for charge/uncharge hugetlb reservations
Date: Fri, 14 Feb 2020 16:50:25 -0800	[thread overview]
Message-ID: <791880db-bdb0-8d34-ea9a-be6e4996fc0d@oracle.com> (raw)
In-Reply-To: <20200211213128.73302-2-almasrymina@google.com>

On 2/11/20 1:31 PM, Mina Almasry wrote:
> Augments hugetlb_cgroup_charge_cgroup to be able to charge hugetlb
> usage or hugetlb reservation counter.
> 
> Adds a new interface to uncharge a hugetlb_cgroup counter via
> hugetlb_cgroup_uncharge_counter.
> 
> Integrates the counter with hugetlb_cgroup, via hugetlb_cgroup_init,
> hugetlb_cgroup_have_usage, and hugetlb_cgroup_css_offline.
> 
> Signed-off-by: Mina Almasry <almasrymina@google.com>
> 

Thanks for the suggested changes.  It will make the code easier to
read and understand.

Acked-by: Mike Kravetz <mike.kravetz@oracle.com

> ---
> 
> Changes in v12:
> - Instead of true/false param for rsvd or non-rsvd calls, now there is:
> hugetlb_cgroup_*() call for non-rsvd
> hugetlb_cgroup_*_rsvd() call for rsvd
> __hugetlb_cgroup_*(, bool) for both.
> - Removed review tags as this patch changed quite a bit.

  reply	other threads:[~2020-02-15  0:50 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 21:31 [PATCH v12 1/9] hugetlb_cgroup: Add hugetlb_cgroup reservation counter Mina Almasry
2020-02-11 21:31 ` Mina Almasry
2020-02-11 21:31 ` Mina Almasry
2020-02-11 21:31 ` [PATCH v12 2/9] hugetlb_cgroup: add interface for charge/uncharge hugetlb reservations Mina Almasry
2020-02-11 21:31   ` Mina Almasry
2020-02-15  0:50   ` Mike Kravetz [this message]
2020-02-16  1:21     ` David Rientjes
2020-02-16  1:21       ` David Rientjes
2020-02-11 21:31 ` [PATCH v12 3/9] hugetlb_cgroup: add reservation accounting for private mappings Mina Almasry
2020-02-11 21:31   ` Mina Almasry
2020-02-11 21:31   ` Mina Almasry
2020-02-11 21:31 ` [PATCH v12 4/9] hugetlb: disable region_add file_region coalescing Mina Almasry
2020-02-11 21:31   ` Mina Almasry
2020-02-15  1:27   ` Mike Kravetz
2020-02-15  1:27     ` Mike Kravetz
2020-02-16  1:25   ` David Rientjes
2020-02-16  1:25     ` David Rientjes
2020-02-16  1:25     ` David Rientjes
2020-02-11 21:31 ` [PATCH v12 5/9] hugetlb_cgroup: add accounting for shared mappings Mina Almasry
2020-02-11 21:31   ` Mina Almasry
2020-02-11 21:31   ` Mina Almasry
2020-02-16  1:29   ` David Rientjes
2020-02-16  1:29     ` David Rientjes
2020-02-18 18:07   ` Mike Kravetz
2020-02-18 18:07     ` Mike Kravetz
2020-02-11 21:31 ` [PATCH v12 6/9] hugetlb_cgroup: support noreserve mappings Mina Almasry
2020-02-11 21:31   ` Mina Almasry
2020-02-18 20:57   ` Mike Kravetz
2020-02-18 20:57     ` Mike Kravetz
2020-02-11 21:31 ` [PATCH v12 7/9] hugetlb: support file_region coalescing again Mina Almasry
2020-02-11 21:31   ` Mina Almasry
2020-02-11 21:31   ` Mina Almasry
2020-02-16  1:29   ` David Rientjes
2020-02-16  1:29     ` David Rientjes
2020-02-19  3:28   ` Mike Kravetz
2020-02-19  7:54     ` Mina Almasry
2020-02-19  7:54       ` Mina Almasry
2020-02-19 23:36     ` [PATCH] hugetlb: Remove check_coalesce_bug debug code Mina Almasry
2020-02-19 23:36       ` Mina Almasry
2020-02-20  0:07       ` Mike Kravetz
2020-02-11 21:31 ` [PATCH v12 8/9] hugetlb_cgroup: Add hugetlb_cgroup reservation tests Mina Almasry
2020-02-11 21:31   ` Mina Almasry
2020-02-11 21:31   ` Mina Almasry
2020-02-12  8:50   ` Sandipan Das
2020-02-20  0:05     ` Mina Almasry
2020-02-20  0:05       ` Mina Almasry
2020-02-20  0:05       ` Mina Almasry
2020-02-21  0:52   ` Mike Kravetz
2020-02-21  0:52     ` Mike Kravetz
2020-02-11 21:31 ` [PATCH v12 9/9] hugetlb_cgroup: Add hugetlb_cgroup reservation docs Mina Almasry
2020-02-11 21:31   ` Mina Almasry
2020-02-20  0:03   ` Mina Almasry
2020-02-20  0:03     ` Mina Almasry
2020-02-20  0:03     ` Mina Almasry
2020-02-20  0:18   ` Mike Kravetz
2020-02-20  0:18     ` Mike Kravetz
2020-02-11 23:19 ` [PATCH v12 1/9] hugetlb_cgroup: Add hugetlb_cgroup reservation counter Andrew Morton
2020-02-11 23:19   ` Andrew Morton
2020-02-18 14:21   ` Qian Cai
2020-02-18 14:21     ` Qian Cai
2020-02-18 14:21     ` Qian Cai
2020-02-18 18:35     ` Mina Almasry
2020-02-18 18:35       ` Mina Almasry
2020-02-18 18:35       ` Mina Almasry
2020-02-18 18:41       ` Qian Cai
2020-02-18 18:41         ` Qian Cai
2020-02-18 19:14       ` Mike Kravetz
2020-02-18 19:14         ` Mike Kravetz
2020-02-18 19:25         ` Mina Almasry
2020-02-18 19:25           ` Mina Almasry
2020-02-18 21:36           ` Mina Almasry
2020-02-18 21:36             ` Mina Almasry
2020-02-18 21:41             ` Mike Kravetz
2020-02-18 21:41               ` Mike Kravetz
2020-02-18 22:27               ` Mina Almasry
2020-02-18 22:27                 ` Mina Almasry
2020-02-18 22:27                 ` Mina Almasry
2020-02-19 19:05   ` Mina Almasry
2020-02-19 19:05     ` Mina Almasry
2020-02-19 21:06     ` Andrew Morton
2020-02-19 21:06       ` Andrew Morton
2020-02-20 19:22       ` Mina Almasry
2020-02-20 19:22         ` Mina Almasry
2020-02-21  0:28         ` Andrew Morton
2020-02-21  0:41           ` Mike Kravetz
2020-02-21  0:41             ` Mike Kravetz
2020-02-21  1:52             ` Mina Almasry
2020-02-21  1:52               ` Mina Almasry
2020-02-21  1:52               ` Mina Almasry
2020-02-21 20:19       ` Mina Almasry
2020-02-21 20:19         ` Mina Almasry
2020-02-21 20:19         ` Mina Almasry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=791880db-bdb0-8d34-ea9a-be6e4996fc0d@oracle.com \
    --to=mike.kravetz@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=almasrymina@google.com \
    --cc=cgroups@vger.kernel.org \
    --cc=gthelen@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    --cc=shakeelb@google.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.