From: Chris Mason <clm@fb.com>
To: Josef Bacik <jbacik@fb.com>, Liu Bo <bo.li.liu@oracle.com>,
<linux-btrfs@vger.kernel.org>
Cc: David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH] Btrfs: kill BUG_ON in do_relocation
Date: Wed, 14 Sep 2016 13:29:44 -0400 [thread overview]
Message-ID: <793b8de8-e612-d075-8764-0ef59963cf4a@fb.com> (raw)
In-Reply-To: <9426999a-06a8-d169-753a-0c4df5c7c4f8@fb.com>
On 09/14/2016 01:13 PM, Josef Bacik wrote:
> On 09/14/2016 12:27 PM, Liu Bo wrote:
>> While updating btree, we try to push items between sibling
>> nodes/leaves in order to keep height as low as possible.
>> But we don't memset the original places with zero when
>> pushing items so that we could end up leaving stale content
>> in nodes/leaves. One may read the above stale content by
>> increasing btree blocks' @nritems.
>>
>
> Ok this sounds really bad. Is this as bad as I think it sounds? We
> should probably fix this like right now right?
He's bumping @nritems with a fuzzer I think? As in this happens when
someone forces it (or via some other bug) but not in normal operations.
-chris
next prev parent reply other threads:[~2016-09-14 17:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 16:27 [PATCH] Btrfs: kill BUG_ON in do_relocation Liu Bo
2016-09-14 17:13 ` Josef Bacik
2016-09-14 17:29 ` Chris Mason [this message]
2016-09-14 17:31 ` Josef Bacik
2016-09-14 18:19 ` Liu Bo
2016-09-15 19:01 ` Liu Bo
2016-09-15 18:58 ` Chris Mason
2016-09-19 18:01 ` David Sterba
2016-09-19 23:11 ` Liu Bo
2016-09-20 8:03 ` David Sterba
2016-09-20 17:59 ` Liu Bo
2016-09-21 8:14 ` David Sterba
2016-09-14 18:16 ` Liu Bo
2016-09-23 21:05 ` [PATCH v2] " Liu Bo
2016-10-11 14:25 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=793b8de8-e612-d075-8764-0ef59963cf4a@fb.com \
--to=clm@fb.com \
--cc=bo.li.liu@oracle.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.