All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
	Dongjiu Geng <gengdongjiu1@gmail.com>,
	Swetha <swjoshi@microsoft.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 1/3] hw/acpi: Provide stub version of acpi_ghes_record_errors()
Date: Thu, 3 Jun 2021 11:52:34 -0700	[thread overview]
Message-ID: <794108a2-fbaf-dfbc-ed8f-2d3d87ba2c07@linaro.org> (raw)
In-Reply-To: <20210603171259.27962-2-peter.maydell@linaro.org>

On 6/3/21 10:12 AM, Peter Maydell wrote:
> +softmmu_ss.add(when: 'CONFIG_ACPI', if_false: files('acpi-stub.c', 'aml-build-stub.c', 'ghes-stub.c'))
>   softmmu_ss.add_all(when: 'CONFIG_ACPI', if_true: acpi_ss)
>   softmmu_ss.add(when: 'CONFIG_ALL', if_true: files('acpi-stub.c', 'aml-build-stub.c',
> -                                                  'acpi-x86-stub.c', 'ipmi-stub.c'))
> +                                                  'acpi-x86-stub.c', 'ipmi-stub.c', 'ghes-stub.c'))

Gosh that last line is confusing.  I see it's documented in build-system.rst, 
but yeesh.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



  reply	other threads:[~2021-06-03 18:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 17:12 [PATCH 0/3] hw/acpi, arm: Provide and use acpi_ghes_present() Peter Maydell
2021-06-03 17:12 ` [PATCH 1/3] hw/acpi: Provide stub version of acpi_ghes_record_errors() Peter Maydell
2021-06-03 18:52   ` Richard Henderson [this message]
2021-06-17 10:28     ` Paolo Bonzini
2021-06-17 12:25       ` Peter Maydell
2021-06-13 21:47   ` Dongjiu Geng
2021-06-03 17:12 ` [PATCH 2/3] hw/acpi: Provide function acpi_ghes_present() Peter Maydell
2021-06-03 18:55   ` Richard Henderson
2021-06-13 21:48   ` Dongjiu Geng
2021-06-03 17:12 ` [PATCH 3/3] target/arm: Use acpi_ghes_present() to see if we report ACPI memory errors Peter Maydell
2021-06-03 18:56   ` Richard Henderson
2021-06-13 21:49   ` Dongjiu Geng
2021-06-15  9:19 ` [PATCH 0/3] hw/acpi, arm: Provide and use acpi_ghes_present() Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=794108a2-fbaf-dfbc-ed8f-2d3d87ba2c07@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=gengdongjiu1@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=swjoshi@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.