From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csXt6-0007QA-ID for qemu-devel@nongnu.org; Mon, 27 Mar 2017 12:53:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csXt5-0000R6-LF for qemu-devel@nongnu.org; Mon, 27 Mar 2017 12:53:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60478) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1csXt5-0000Qb-CF for qemu-devel@nongnu.org; Mon, 27 Mar 2017 12:52:59 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 592C18123E for ; Mon, 27 Mar 2017 16:52:58 +0000 (UTC) References: <1490621195-2228-1-git-send-email-armbru@redhat.com> <1490621195-2228-10-git-send-email-armbru@redhat.com> From: Max Reitz Message-ID: <7954d849-2a60-31c5-d399-622c838ac7d6@redhat.com> Date: Mon, 27 Mar 2017 18:52:55 +0200 MIME-Version: 1.0 In-Reply-To: <1490621195-2228-10-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d7KJJRWnF5Fa0upXWi04uxOrEuDf4nNpm" Subject: Re: [Qemu-devel] [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev parameter password-secret List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: jdurgin@redhat.com, jcody@redhat.com, kwolf@redhat.com, eblake@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --d7KJJRWnF5Fa0upXWi04uxOrEuDf4nNpm From: Max Reitz To: Markus Armbruster , qemu-devel@nongnu.org Cc: jdurgin@redhat.com, jcody@redhat.com, kwolf@redhat.com, eblake@redhat.com Message-ID: <7954d849-2a60-31c5-d399-622c838ac7d6@redhat.com> Subject: Re: [PATCH RFC v3 for-2.9 09/11] rbd: Revert -blockdev parameter password-secret References: <1490621195-2228-1-git-send-email-armbru@redhat.com> <1490621195-2228-10-git-send-email-armbru@redhat.com> In-Reply-To: <1490621195-2228-10-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 27.03.2017 15:26, Markus Armbruster wrote: > This reverts a part of commit 8a47e8e. We're having second thoughts > on the QAPI schema (and thus the external interface), and haven't > reached consensus, yet. Issues include: >=20 > * BlockdevOptionsRbd member @password-secret isn't actually a > password, it's a key generated by Ceph. >=20 > * We're not sure where member @password-secret belongs (see the > previous commit). >=20 > * How @password-secret interacts with settings from a configuration > file specified with @conf is undocumented. I suspect it's untested, > too. >=20 > Let's avoid painting ourselves into a corner now, and revert the > feature for 2.9. >=20 > Note that users can still configure an authentication key with a > configuration file. They probably do that anyway if they use Ceph > outside QEMU as well. >=20 > Signed-off-by: Markus Armbruster > --- > qapi/block-core.json | 3 --- > 1 file changed, 3 deletions(-) Reviewed-by: Max Reitz --d7KJJRWnF5Fa0upXWi04uxOrEuDf4nNpm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFGBAEBCAAwFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAljZQ2cSHG1yZWl0ekBy ZWRoYXQuY29tAAoJEPQH2wBh1c9A/hAIAKkQr+CycCJhudR+rcLf4ZZSzZrKPhvi wF44biSu4OZNUrzZSFQaUJYfE96mcOdQb5zByPRANjyhmjA6ojf1fFva2hKhg1Fu f3oXyMlCsoonO6KbBcZAkyupfZr3piur3/1skvexdwDyZqGGAf/FeXdVppyeju71 2+Tv67WBp18PLfN1miO9SSPwYHNnjhd7lXK8AEQ7CruZlc6uGOMDdCuwWe/rqZfJ 4L/RmwHHBOO+TaJTvow0BX8UyfTa2PCzfLt2LSaIVpGoh6oQsBAnKuX5PGcX58yk fhIhxX91JLVkbhAdOuecm3sk4j72ao0/D9+nIrXXzmtoZcriTWEXl2U= =mdm1 -----END PGP SIGNATURE----- --d7KJJRWnF5Fa0upXWi04uxOrEuDf4nNpm--