From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28F59C433F5 for ; Thu, 13 Jan 2022 06:42:51 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4D33D832EA; Thu, 13 Jan 2022 07:42:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1642056169; bh=BHKrTrEkqcLy2ML1DnXXbvmBW0LnV26mDEeQCFStAB8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BxaCB6eb1/qlRbC/HIdqXGJuGJMeHm4VQTlo9vdVeN3yT74Osr3zc/Cq6mDrKTVSj dRGBeds3OBWX0H0AMYVIObTU8B6uSYQ3N8YEbXcm/q9w8BQNKo0yBB4do/JsynOQs2 ko/LdXzF16OwH3XI0Kp6HvLDsacgzBFoGGs/lrZvjClccYFrwsveSmKcajlSifizF9 Cn+1fgZpOtqya3QGyQ/y/W9eybRnRHJwzVkeeLXFZnf0OQolcRN0r7Z85PDCde3fMG VMPDKiQr8ol4U45ficj3kR61rlHOQS5vO+cELXEI8+cnM0d2W0arCjG9wV7ogH84wH 0FVaTLj07cJfw== Received: by phobos.denx.de (Postfix, from userid 109) id CBAC783301; Thu, 13 Jan 2022 07:42:47 +0100 (CET) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [IPv6:2001:67c:2050:1::465:204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8AE30830EA for ; Thu, 13 Jan 2022 07:42:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:105:465:1:3:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4JZFH93NhfzQlGr; Thu, 13 Jan 2022 07:42:45 +0100 (CET) Message-ID: <795976b1-14a1-8c43-f5c0-edb29a5d1996@denx.de> Date: Thu, 13 Jan 2022 07:42:42 +0100 MIME-Version: 1.0 Subject: Re: [PATCH u-boot-marvell v2 13/20] arm: mvebu: Enable BootROM output on A38x Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , =?UTF-8?Q?Marek_Beh=c3=ban?= , Chris Packham Cc: u-boot@lists.denx.de References: <20211221155416.8557-1-pali@kernel.org> <20220112172054.5961-1-pali@kernel.org> <20220112172054.5961-14-pali@kernel.org> From: Stefan Roese In-Reply-To: <20220112172054.5961-14-pali@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 1/12/22 18:20, Pali Rohár wrote: > BootROMs on pre-A38x SoCs enabled its output on UART by default, but A38x' > BootROM has its output on UART disabled by default. > > To enable BootROM output on A38x SoC, it is required to set DEBUG flag > (which only enables BootROM output and nothing more) in kwbimage. For UART > images this DEBUG flag is ignored by BootROM. > > Enable kwbimage DEBUG flag for all A38x boards. > > With this change BootROM prints the following (success) information on UART > before booting U-Boot kwbimage: > > BootROM - 1.73 > Booting from SPI flash > > Signed-off-by: Pali Rohár > Reviewed-by: Marek Behún Reviewed-by: Stefan Roese Thanks, Stefan > --- > arch/arm/mach-mvebu/Makefile | 7 +++++++ > arch/arm/mach-mvebu/kwbimage.cfg.in | 3 +++ > 2 files changed, 10 insertions(+) > > diff --git a/arch/arm/mach-mvebu/Makefile b/arch/arm/mach-mvebu/Makefile > index 9ace049c9d7c..74478a3134e3 100644 > --- a/arch/arm/mach-mvebu/Makefile > +++ b/arch/arm/mach-mvebu/Makefile > @@ -69,6 +69,13 @@ KWB_REPLACE += SEC_FUSE_DUMP > KWB_CFG_SEC_FUSE_DUMP = a38x > endif > > +ifdef CONFIG_ARMADA_38X > +# BootROM output is by default enabled on pre-A38x and disabled on A38x > +# DEBUG flag on A38x for non-UART boot source only enable BootROM output and nothing more > +KWB_REPLACE += DEBUG > +KWB_CFG_DEBUG = 1 > +endif > + > quiet_cmd_kwbcfg = KWBCFG $@ > cmd_kwbcfg = sed -ne '$(foreach V,$(KWB_REPLACE),s/\#@$(V)/$(V) $(KWB_CFG_$(V))/;)p' \ > <$< >$(dir $@)$(@F) > diff --git a/arch/arm/mach-mvebu/kwbimage.cfg.in b/arch/arm/mach-mvebu/kwbimage.cfg.in > index 603e8863450c..ccb09975817e 100644 > --- a/arch/arm/mach-mvebu/kwbimage.cfg.in > +++ b/arch/arm/mach-mvebu/kwbimage.cfg.in > @@ -11,5 +11,8 @@ VERSION 1 > # Boot Media configurations > #@BOOT_FROM > > +# Enable BootROM output via DEBUG flag on SoCs which require it > +#@DEBUG > + > # Include U-Boot SPL with DDR3 training code into Binary Header > BINARY spl/u-boot-spl.bin #@LOAD_ADDRESS > Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de