All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
	Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc: alsa-devel@alsa-project.org, rander.wang@intel.com,
	lgirdwood@gmail.com, kai.vehmanen@linux.intel.com,
	ranjani.sridharan@linux.intel.com
Subject: Re: [PATCH] ASoC: SOF: Intel: hda-stream: limit PROCEN workaround
Date: Thu, 30 Sep 2021 15:24:09 -0500	[thread overview]
Message-ID: <795a1c96-c4b5-a364-e192-58358c90d5de@linux.intel.com> (raw)
In-Reply-To: <20210928151012.GA25932@sirena.org.uk>



On 9/28/21 10:10 AM, Mark Brown wrote:
> On Tue, Sep 28, 2021 at 11:22:48AM +0300, Peter Ujfalusi wrote:
>> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>>
>> The work-around enabled in hda-stream.c is only required on earlier
>> versions of SOCs/PCH (Skylake, KabyLake, ApolloLake,
>> GeminiLake). Before setting the format on the host DMA, it is required
>> to couple the host and link DMA - which as a consequence shall use the
>> same format.
> 
> This breaks the build for me:
> 
> /mnt/kernel/sound/soc/sof/intel/hda-stream.c: In function 'hda_dsp_stream_hw_params':
> /mnt/kernel/sound/soc/sof/intel/hda-stream.c:436:42: error: implicit declaration of function 'get_chip_info'; did you mean 'get_group_info'? [-Werror=implicit-function-declaration]

Ack, we're missing a dependency.

Peter, this function was moved to shim.h with Ranjani's patch
"ASoC: SOF: Intel: hda: expose get_chip_info()"

That patch was added in the SOF multi-core series.

  reply	other threads:[~2021-09-30 20:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28  8:22 [PATCH] ASoC: SOF: Intel: hda-stream: limit PROCEN workaround Peter Ujfalusi
2021-09-28 15:10 ` Mark Brown
2021-09-30 20:24   ` Pierre-Louis Bossart [this message]
2021-10-01  5:58     ` Péter Ujfalusi
2021-10-01 15:54       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=795a1c96-c4b5-a364-e192-58358c90d5de@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=rander.wang@intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.