Keyon, can you look into this? Thanks!


On 8/29/20 4:35 AM, kernel test robot wrote:
> tree:   https://github.com/thesofproject/linux pr/2395
> head:   f5d2f601dba6cf997465a0bd52412852e7b081f7
> commit: 901ec5d619b041fcd9a12347a85091b90e19a6ac [7/16] ASoC: SOF: append extended data to sof_ipc_comp_dai
> config: arm64-sof-customedconfig-sof-defconfig (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          git checkout 901ec5d619b041fcd9a12347a85091b90e19a6ac
>          # save the attached .config to linux build tree
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>     sound/soc/sof/topology.c: In function 'sof_widget_load_dai':
>>> sound/soc/sof/topology.c:1437:48: error: 'core' undeclared (first use in this function)
>      1437 |      sof_comp_alloc(swidget, &ipc_size, index, core);
>           |                                                ^~~~
>     sound/soc/sof/topology.c:1437:48: note: each undeclared identifier is reported only once for each function it appears in
>
> # https://github.com/thesofproject/linux/commit/901ec5d619b041fcd9a12347a85091b90e19a6ac
> git remote add linux-sof-driver https://github.com/thesofproject/linux
> git fetch --no-tags linux-sof-driver pr/2395
> git checkout 901ec5d619b041fcd9a12347a85091b90e19a6ac
> vim +/core +1437 sound/soc/sof/topology.c
>
>    1423	
>    1424	static int sof_widget_load_dai(struct snd_soc_component *scomp, int index,
>    1425				       struct snd_sof_widget *swidget,
>    1426				       struct snd_soc_tplg_dapm_widget *tw,
>    1427				       struct sof_ipc_comp_reply *r,
>    1428				       struct snd_sof_dai *dai)
>    1429	{
>    1430		struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
>    1431		struct snd_soc_tplg_private *private = &tw->priv;
>    1432		struct sof_ipc_comp_dai *comp_dai;
>    1433		size_t ipc_size = sizeof(*comp_dai);
>    1434		int ret;
>    1435	
>    1436		comp_dai = (struct sof_ipc_comp_dai *)
>> 1437			   sof_comp_alloc(swidget, &ipc_size, index, core);
>    1438		if (!comp_dai)
>    1439			return -ENOMEM;
>    1440	
>    1441		/* configure dai IPC message */
>    1442		comp_dai->comp.type = SOF_COMP_DAI;
>    1443		comp_dai->config.hdr.size = sizeof(comp_dai->config);
>    1444	
>    1445		ret = sof_parse_tokens(scomp, comp_dai, dai_tokens,
>    1446				       ARRAY_SIZE(dai_tokens), private->array,
>    1447				       le32_to_cpu(private->size));
>    1448		if (ret != 0) {
>    1449			dev_err(scomp->dev, "error: parse dai tokens failed %d\n",
>    1450				le32_to_cpu(private->size));
>    1451			goto finish;
>    1452		}
>    1453	
>    1454		ret = sof_parse_tokens(scomp, &comp_dai->config, comp_tokens,
>    1455				       ARRAY_SIZE(comp_tokens), private->array,
>    1456				       le32_to_cpu(private->size));
>    1457		if (ret != 0) {
>    1458			dev_err(scomp->dev, "error: parse dai.cfg tokens failed %d\n",
>    1459				private->size);
>    1460			goto finish;
>    1461		}
>    1462	
>    1463		dev_dbg(scomp->dev, "dai %s: type %d index %d\n",
>    1464			swidget->widget->name, comp_dai->type, comp_dai->dai_index);
>    1465		sof_dbg_comp_config(scomp, &comp_dai->config);
>    1466	
>    1467		ret = sof_ipc_tx_message(sdev->ipc, comp_dai->comp.hdr.cmd,
>    1468					 comp_dai, ipc_size, r, sizeof(*r));
>    1469	
>    1470		if (ret == 0 && dai) {
>    1471			dai->scomp = scomp;
>    1472	
>    1473			/*
>    1474			 * copy only the sof_ipc_comp_dai to avoid collapsing
>    1475			 * the snd_sof_dai, the extended data is kept in the
>    1476			 * snd_sof_widget.
>    1477			 */
>    1478			memcpy(&dai->comp_dai, comp_dai, sizeof(*comp_dai));
>    1479		}
>    1480	
>    1481	finish:
>    1482		kfree(comp_dai);
>    1483		return ret;
>    1484	}
>    1485	
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org