From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B638C432BE for ; Wed, 1 Sep 2021 14:51:25 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A67960ED4 for ; Wed, 1 Sep 2021 14:51:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4A67960ED4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B7EA4834E5; Wed, 1 Sep 2021 16:51:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="ZVudQpKX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 20E1B834E6; Wed, 1 Sep 2021 16:51:19 +0200 (CEST) Received: from ssl.serverraum.org (ssl.serverraum.org [176.9.125.105]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E77DC832A1 for ; Wed, 1 Sep 2021 16:51:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 1167022221; Wed, 1 Sep 2021 16:51:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1630507874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NDrH7TGYSCaA9qXgleg3+kRUI2L8ZOs2Ph0rI+wJJXE=; b=ZVudQpKXXYj7QUhDwP5KlK5MMkfw71ki7M1yAof3jKLR4vjzWz4YYtedD1/uNYyPimjYy1 2XzI1N1keHB92HhY5K/rfRtztk6prcHhg8+sHv6Rpunv1LXilJQmuniTQ76hAjYtXbaRlQ uAVPGXGukvaJVWkPAERcoq6GqwV17Lk= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 01 Sep 2021 16:51:13 +0200 From: Michael Walle To: Vladimir Oltean Cc: u-boot@lists.denx.de, Jagan Teki , Priyanka Jain , Tom Rini , Peter Griffin , Manivannan Sadhasivam Subject: Re: [PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux In-Reply-To: <20210901112731.n477uhjgj34r4jtg@skbuf> References: <20210901085522.1712104-1-michael@walle.cc> <20210901085522.1712104-9-michael@walle.cc> <20210901112731.n477uhjgj34r4jtg@skbuf> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <797132272224b23b40aa43af0e94bccc@walle.cc> X-Sender: michael@walle.cc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Am 2021-09-01 13:27, schrieb Vladimir Oltean: > On Wed, Sep 01, 2021 at 10:55:21AM +0200, Michael Walle wrote: >> sata: sata@3200000 { >> compatible = "fsl,ls1028a-ahci"; >> - reg = <0x0 0x3200000 0x0 0x10000 /* ccsr sata base */ >> - 0x7 0x100520 0x0 0x4>; /* ecc sata addr*/ >> - reg-names = "sata-base", "ecc-addr"; >> + reg = <0x0 0x3200000 0x0 0x10000>, >> + <0x7 0x100520 0x0 0x4>; >> + reg-names = "ahci", "sata-ecc"; > > Again, same problem. The drivers/ata/sata_ceva.c driver calls > dev_read_resource_byname(dev, "ecc-addr") (but not for "sata-base", > apparently). > > If you don't want to convert all occurrences of "ecc-addr" to > "sata-ecc", then at least add a fallback call to > dev_read_resource_byname. This is also missing proper bindings documentation in linux :( I guess it's safe to assume the current linux device tree binding is the correct one. -michael