All of lore.kernel.org
 help / color / mirror / Atom feed
From: Janosch Frank <frankja@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: thuth@redhat.com, pmorel@linux.ibm.com, david@redhat.com,
	qemu-devel@nongnu.org, borntraeger@de.ibm.com,
	qemu-s390x@nongnu.org, mihajlov@linux.ibm.com
Subject: Re: [PATCH 02/15] s390x: Beautify diag308 handling
Date: Thu, 21 Nov 2019 12:27:27 +0100	[thread overview]
Message-ID: <797d327a-b1b3-5b13-1f2b-eed6881a566c@linux.ibm.com> (raw)
In-Reply-To: <20191121121700.1f8aa81d.cohuck@redhat.com>


[-- Attachment #1.1: Type: text/plain, Size: 1288 bytes --]

On 11/21/19 12:17 PM, Cornelia Huck wrote:
> On Wed, 20 Nov 2019 06:43:21 -0500
> Janosch Frank <frankja@linux.ibm.com> wrote:
> 
>> Let's improve readability by:
>> * Using constants for the subcodes
>> * Moving parameter checking into a function
>> * Removing subcode > 6 check as the default case catches that
>>
>> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
>> ---
>>  target/s390x/diag.c | 54 +++++++++++++++++++++++++++------------------
>>  1 file changed, 32 insertions(+), 22 deletions(-)
>>
>> diff --git a/target/s390x/diag.c b/target/s390x/diag.c
>> index 53c2f81f2a..067c667ba7 100644
>> --- a/target/s390x/diag.c
>> +++ b/target/s390x/diag.c
>> @@ -53,6 +53,29 @@ int handle_diag_288(CPUS390XState *env, uint64_t r1, uint64_t r3)
>>  #define DIAG_308_RC_NO_CONF         0x0102
>>  #define DIAG_308_RC_INVALID         0x0402
>>  
>> +#define DIAG308_RES_MOD_CLR		0
>> +#define DIAG308_RES_LOAD_NORM		1
> 
> Maybe s/RES/RESET/ ? Not that much longer, but clearer IMHO.

Sure

> 
>> +#define DIAG308_LOAD_CLEAR		3
>> +#define DIAG308_LOAD_NORMAL_DUMP	4
>> +#define DIAG308_SET			5
>> +#define DIAG308_STORE			6
> 
> (...)
> 
> Really more readable afterwards.
> 
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>

Thanks!



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-11-21 11:29 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-20 11:43 [PATCH 00/15] s390x: Protected Virtualization support Janosch Frank
2019-11-20 11:43 ` [PATCH 01/15] s390x: Cleanup cpu resets Janosch Frank
2019-11-21 11:10   ` Cornelia Huck
2019-11-21 11:32     ` Janosch Frank
2019-11-21 12:18       ` Cornelia Huck
2019-11-21 12:53   ` Thomas Huth
2019-11-21 13:11     ` Janosch Frank
2019-11-21 13:17       ` Thomas Huth
2019-11-20 11:43 ` [PATCH 02/15] s390x: Beautify diag308 handling Janosch Frank
2019-11-21 11:17   ` Cornelia Huck
2019-11-21 11:27     ` Janosch Frank [this message]
2019-11-21 11:21   ` David Hildenbrand
2019-11-21 11:28     ` Janosch Frank
2019-11-21 13:12     ` Thomas Huth
2019-11-21 13:20   ` Thomas Huth
2019-11-21 13:53     ` Janosch Frank
2019-11-20 11:43 ` [PATCH 03/15] s390x: protvirt: Add diag308 subcodes 8 - 10 Janosch Frank
2019-11-21 12:47   ` Cornelia Huck
2019-11-21 14:36   ` Thomas Huth
2020-02-07  7:56     ` Janosch Frank
2019-11-20 11:43 ` [PATCH 04/15] Header sync protvirt Janosch Frank
2019-11-21 12:59   ` Cornelia Huck
2019-11-21 13:12     ` Janosch Frank
2019-11-21 13:17       ` Cornelia Huck
2019-11-20 11:43 ` [PATCH 05/15] s390x: protvirt: Sync PV state Janosch Frank
2019-11-21 13:25   ` Cornelia Huck
2019-11-21 13:43     ` Janosch Frank
2019-11-21 14:43   ` Thomas Huth
2019-11-20 11:43 ` [PATCH 06/15] s390x: protvirt: Support unpack facility Janosch Frank
2019-11-20 13:43   ` Cornelia Huck
2019-11-21 11:33     ` Janosch Frank
2019-11-21 11:27   ` David Hildenbrand
2019-11-21 14:25     ` Janosch Frank
2019-11-21 14:28       ` David Hildenbrand
2019-11-21 14:31         ` Christian Borntraeger
2019-11-21 14:32           ` Janosch Frank
2019-11-22 13:39   ` Cornelia Huck
2019-11-22 13:49     ` Janosch Frank
2019-11-28 14:07   ` Thomas Huth
2019-11-28 14:20     ` Janosch Frank
2019-11-20 11:43 ` [PATCH 07/15] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4 Janosch Frank
2019-11-21 13:50   ` Cornelia Huck
2019-11-21 14:00     ` Janosch Frank
2019-11-21 14:04     ` Janosch Frank
2019-11-21 14:17       ` Cornelia Huck
2019-11-21 14:23         ` Janosch Frank
2019-11-20 11:43 ` [PATCH 08/15] s390x: protvirt: KVM intercept changes Janosch Frank
2019-11-21 14:07   ` Cornelia Huck
2019-11-21 14:29     ` Janosch Frank
2019-11-21 15:11   ` Thomas Huth
2019-11-28 16:38     ` Janosch Frank
2019-11-28 16:45       ` Cornelia Huck
2019-11-28 16:54         ` Janosch Frank
2019-11-20 11:43 ` [PATCH 09/15] s390x: protvirt: SCLP interpretation Janosch Frank
2019-11-21 14:11   ` Cornelia Huck
2019-11-21 14:24     ` Janosch Frank
2019-11-22 13:48       ` Pierre Morel
2019-11-20 11:43 ` [PATCH 10/15] s390x: protvirt: Add new VCPU reset functions Janosch Frank
2019-11-20 11:43 ` [PATCH 11/15] RFC: s390x: Exit on vcpu reset error Janosch Frank
2019-11-21 12:14   ` David Hildenbrand
2019-11-21 12:19     ` Janosch Frank
2019-11-21 12:22       ` David Hildenbrand
2019-11-20 11:43 ` [PATCH 12/15] s390x: protvirt: Set guest IPL PSW Janosch Frank
2019-11-28 14:30   ` Thomas Huth
2019-11-28 15:39     ` Janosch Frank
2019-11-20 11:43 ` [PATCH 13/15] s390x: protvirt: Move diag 308 data over SIDAD Janosch Frank
2019-11-28 14:40   ` Thomas Huth
2019-11-28 16:08     ` Janosch Frank
2019-11-28 16:14       ` David Hildenbrand
2019-11-20 11:43 ` [PATCH 14/15] s390x: protvirt: Disable address checks for PV guest IO emulation Janosch Frank
2019-11-28 15:28   ` Thomas Huth
2019-11-28 15:36     ` Janosch Frank
2019-11-28 16:10     ` Janosch Frank
2019-11-28 16:18       ` Cornelia Huck
2019-11-28 16:24         ` Janosch Frank
2019-11-28 20:08       ` Thomas Huth
2019-11-20 11:43 ` [PATCH 15/15] s390x: protvirt: Handle SIGP store status correctly Janosch Frank
2019-11-21 11:24   ` David Hildenbrand
2019-11-21 11:29     ` Janosch Frank
2019-11-28 15:30   ` Thomas Huth
2019-11-20 13:26 ` [PATCH 00/15] s390x: Protected Virtualization support Cornelia Huck
2019-11-20 13:33   ` Janosch Frank
2019-11-21  9:13   ` Janosch Frank
2019-11-21  9:39     ` Cornelia Huck
2019-11-29 11:08 ` Daniel P. Berrangé
2019-11-29 12:14   ` Janosch Frank
2019-11-29 12:35     ` Daniel P. Berrangé
2019-11-29 14:02       ` Janosch Frank
2019-11-29 14:30         ` Viktor Mihajlovski
2019-12-03 10:49         ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=797d327a-b1b3-5b13-1f2b-eed6881a566c@linux.ibm.com \
    --to=frankja@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=mihajlov@linux.ibm.com \
    --cc=pmorel@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.