From: Farhan Ali <alifm@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: David Hildenbrand <david@redhat.com>,
qemu-devel@nongnu.org, Thomas Huth <thuth@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2] s390x: add zPCI feature to "qemu" CPU model
Date: Wed, 13 Feb 2019 11:29:32 -0500 [thread overview]
Message-ID: <797e2c40-8cb5-3d18-d437-0a7844e0606b@linux.ibm.com> (raw)
In-Reply-To: <20190213172627.3b0a1ef0.cohuck@redhat.com>
On 02/13/2019 11:26 AM, Cornelia Huck wrote:
> On Wed, 13 Feb 2019 10:54:23 -0500
> Farhan Ali <alifm@linux.ibm.com> wrote:
>
>> I noticed the qemu-iotests 200 was failing due to the commit
>> "703fef6fcf3 : s390x/pci: Warn when adding PCI devices without the
>> 'zpci' feature".
>>
>> This patch fixes the failure :).
>
> Huh. So it was testing without pci before and now with and it's also
> working? Awesome :)
It was testing with pci, but the reason it fails was because qemu was
spitting out the warning due to commit 703fef6fcf3. Now David's commit
adds the zpci to qemu cpu model and qemu doesn't give out a warning message.
>
>>
>> Thanks
>> Farhan
>>
>> On 02/12/2019 06:23 AM, David Hildenbrand wrote:
>>> As we now always have PCI support, let's add it to the "qemu" CPU model,
>>> taking care of backwards compatibility.
>>>
>>> Signed-off-by: David Hildenbrand<david@redhat.com>
>>> ---
>>>
>>> v1 -> v2:
>>> - Use correct model identifiction of the z12 we emulate
>>>
>>> hw/s390x/s390-virtio-ccw.c | 3 +++
>>> target/s390x/gen-features.c | 8 ++++++--
>>> 2 files changed, 9 insertions(+), 2 deletions(-)
>>
>
>
prev parent reply other threads:[~2019-02-13 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 11:23 [Qemu-devel] [PATCH v2] s390x: add zPCI feature to "qemu" CPU model David Hildenbrand
2019-02-12 13:12 ` Cornelia Huck
2019-02-13 15:54 ` Farhan Ali
2019-02-13 16:26 ` Cornelia Huck
2019-02-13 16:29 ` Farhan Ali [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=797e2c40-8cb5-3d18-d437-0a7844e0606b@linux.ibm.com \
--to=alifm@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.