* Getting kernel patch to work
@ 2020-03-10 23:57 Greg Wilson-Lindberg
2020-03-11 6:07 ` [yocto] " Anders Montonen
0 siblings, 1 reply; 5+ messages in thread
From: Greg Wilson-Lindberg @ 2020-03-10 23:57 UTC (permalink / raw)
To: Yocto list discussion
I'm using a boot2qt version of a warrior Yocto build for a raspberry pi4.
I'm trying to apply a patch to a driver in the linux kernel. I'm following the procedures laid out in the
book "Embedded Linux Systems with the Yocto Project".
I already have a kernel .bbappend file that I'm using to modify the kernel config and that is working correctly.
I started with a patch file that I found on the internet that addressed the problem that I have and I added
support for it to my .bbappend file. I know that it has been found correctly because I initially specified the
file path incorrectly and received an error.
After building my image I go to look at the STAGING_KERNEL_DIR and I do not see my changes applied to the
file. I even added an error to the patch to see if it was compiling and it didn't trigger the error.
At this point I went back fully to "Embedded Linux Systems with the Yocto Project" and created my own
patch. I still don't see it being applied.
Can somebody please tell me where I should see the patch applied?
Here is how I modified my .bbappend:
# additions to Kernel configuration
SRC_URi += "file://0001-drm-vc4-Keep-the-binner-BO-through-suspend-GWL.patch"
do_configure_append() {
.
.
.
}
And here is the patch:
From d95e6ead8d25165014f8746082656da6345889b0 Mon Sep 17 00:00:00 2001
From: Greg Wilson-Lindberg <gwilson@sakuraus.com>
Date: Tue, 10 Mar 2020 16:29:08 -0700
Subject: [PATCH 1/1] drm-vc4-Keep-the-binner-BO-through-suspend-GWL
---
drivers/gpu/drm/vc4/vc4_v3d.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c
index e47e29426078..ff7812066668 100644
--- a/drivers/gpu/drm/vc4/vc4_v3d.c
+++ b/drivers/gpu/drm/vc4/vc4_v3d.c
@@ -303,9 +303,6 @@ static int vc4_v3d_runtime_suspend(struct device *dev)
vc4_irq_uninstall(vc4->dev);
- drm_gem_object_put_unlocked(&vc4->bin_bo->base.base);
- vc4->bin_bo = NULL;
-
clk_disable_unprepare(v3d->clk);
return 0;
@@ -317,10 +314,6 @@ static int vc4_v3d_runtime_resume(struct device *dev)
struct vc4_dev *vc4 = v3d->vc4;
int ret;
- ret = vc4_allocate_bin_bo(vc4->dev);
- if (ret)
- return ret;
-
ret = clk_prepare_enable(v3d->clk);
if (ret != 0)
return ret;
--
2.17.1
Thanks in advance,
Greg Wilson-Lindberg
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [yocto] Getting kernel patch to work
2020-03-10 23:57 Getting kernel patch to work Greg Wilson-Lindberg
@ 2020-03-11 6:07 ` Anders Montonen
2020-03-11 23:43 ` Greg Wilson-Lindberg
0 siblings, 1 reply; 5+ messages in thread
From: Anders Montonen @ 2020-03-11 6:07 UTC (permalink / raw)
To: Yocto list discussion
Hi,
> On 11 Mar 2020, at 1:57, Greg Wilson-Lindberg <GWilson@sakuraus.com> wrote:
>
> SRC_URi += "file://0001-drm-vc4-Keep-the-binner-BO-through-suspend-GWL.patch”
It looks like you have a typo here, the last letter of SRC_URI isn’t capitalized.
-a
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [yocto] Getting kernel patch to work
2020-03-11 6:07 ` [yocto] " Anders Montonen
@ 2020-03-11 23:43 ` Greg Wilson-Lindberg
2020-03-11 23:55 ` Denys Dmytriyenko
0 siblings, 1 reply; 5+ messages in thread
From: Greg Wilson-Lindberg @ 2020-03-11 23:43 UTC (permalink / raw)
To: Anders Montonen, Yocto list discussion
[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]
Hi Anders,
Good catch, thanks for seeing that.
I also realized that I was missing a FILESEXTRAPATHS_prepend. I have tried both:
FILESEXTRAPATHS_prepend := "$(FILE_DIRNAME)/files:"
and
FILESEXTRAPATHS_prepend := "$(THISDIR)/files:"
In both cases I don't see the expansion (i.e. I see '$(FILE_DIRNAME)/files:' or '$(THISDIR)/files:') in the list of searched directories. I would think that I should see the expanded directory path.
Here is the net beginning of my .bbappend file:
# additions to Kernel configuration
FILESEXTRAPATHS_prepend := "$(FILE_DIRNAME)/files:"
#FILESEXTRAPATHS_prepend := "$(THISDIR)/files:"
SRC_URI+= "file://0001-drm-vc4-Keep-the-binner-BO-through-suspend.patch"
Regards,
Greg
________________________________
From: yocto@lists.yoctoproject.org <yocto@lists.yoctoproject.org> on behalf of Anders Montonen <Anders.Montonen@iki.fi>
Sent: Tuesday, March 10, 2020 11:07:33 PM
To: Yocto list discussion
Subject: Re: [yocto] Getting kernel patch to work
Hi,
> On 11 Mar 2020, at 1:57, Greg Wilson-Lindberg <GWilson@sakuraus.com> wrote:
>
> SRC_URi += "file://0001-drm-vc4-Keep-the-binner-BO-through-suspend-GWL.patch"
It looks like you have a typo here, the last letter of SRC_URI isn't capitalized.
-a
[-- Attachment #2: Type: text/html, Size: 2530 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [yocto] Getting kernel patch to work
2020-03-11 23:43 ` Greg Wilson-Lindberg
@ 2020-03-11 23:55 ` Denys Dmytriyenko
2020-03-12 17:51 ` Greg Wilson-Lindberg
0 siblings, 1 reply; 5+ messages in thread
From: Denys Dmytriyenko @ 2020-03-11 23:55 UTC (permalink / raw)
To: Greg Wilson-Lindberg; +Cc: Anders Montonen, Yocto list discussion
${} and not $()
On Wed, Mar 11, 2020 at 11:43:36PM +0000, Greg Wilson-Lindberg wrote:
> Hi Anders,
>
> Good catch, thanks for seeing that.
>
>
> I also realized that I was missing a FILESEXTRAPATHS_prepend. I have tried both:
>
> FILESEXTRAPATHS_prepend := "$(FILE_DIRNAME)/files:"
> and
> FILESEXTRAPATHS_prepend := "$(THISDIR)/files:"
>
> In both cases I don't see the expansion (i.e. I see '$(FILE_DIRNAME)/files:' or '$(THISDIR)/files:') in the list of searched directories. I would think that I should see the expanded directory path.
>
> Here is the net beginning of my .bbappend file:
>
> # additions to Kernel configuration
>
> FILESEXTRAPATHS_prepend := "$(FILE_DIRNAME)/files:"
> #FILESEXTRAPATHS_prepend := "$(THISDIR)/files:"
> SRC_URI+= "file://0001-drm-vc4-Keep-the-binner-BO-through-suspend.patch"
>
>
> Regards,
> Greg
>
>
> ________________________________
> From: yocto@lists.yoctoproject.org <yocto@lists.yoctoproject.org> on behalf of Anders Montonen <Anders.Montonen@iki.fi>
> Sent: Tuesday, March 10, 2020 11:07:33 PM
> To: Yocto list discussion
> Subject: Re: [yocto] Getting kernel patch to work
>
> Hi,
>
> > On 11 Mar 2020, at 1:57, Greg Wilson-Lindberg <GWilson@sakuraus.com> wrote:
> >
> > SRC_URi += "file://0001-drm-vc4-Keep-the-binner-BO-through-suspend-GWL.patch"
>
> It looks like you have a typo here, the last letter of SRC_URI isn't capitalized.
>
> -a
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [yocto] Getting kernel patch to work
2020-03-11 23:55 ` Denys Dmytriyenko
@ 2020-03-12 17:51 ` Greg Wilson-Lindberg
0 siblings, 0 replies; 5+ messages in thread
From: Greg Wilson-Lindberg @ 2020-03-12 17:51 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: Anders Montonen, Yocto list discussion
Hi Denys,
I guess I have been rather blind when putting this together. That's what I get for not copying and pasting.
Thanks,
Greg
> -----Original Message-----
> From: Denys Dmytriyenko <denis@denix.org>
> Sent: Wednesday, March 11, 2020 4:55 PM
> To: Greg Wilson-Lindberg <GWilson@sakuraus.com>
> Cc: Anders Montonen <Anders.Montonen@iki.fi>; Yocto list discussion
> <yocto@yoctoproject.org>
> Subject: Re: [yocto] Getting kernel patch to work
>
> ${} and not $()
>
> On Wed, Mar 11, 2020 at 11:43:36PM +0000, Greg Wilson-Lindberg wrote:
> > Hi Anders,
> >
> > Good catch, thanks for seeing that.
> >
> >
> > I also realized that I was missing a FILESEXTRAPATHS_prepend. I have tried
> both:
> >
> > FILESEXTRAPATHS_prepend := "$(FILE_DIRNAME)/files:"
> > and
> > FILESEXTRAPATHS_prepend := "$(THISDIR)/files:"
> >
> > In both cases I don't see the expansion (i.e. I see '$(FILE_DIRNAME)/files:'
> or '$(THISDIR)/files:') in the list of searched directories. I would think that I
> should see the expanded directory path.
> >
> > Here is the net beginning of my .bbappend file:
> >
> > # additions to Kernel configuration
> >
> > FILESEXTRAPATHS_prepend := "$(FILE_DIRNAME)/files:"
> > #FILESEXTRAPATHS_prepend := "$(THISDIR)/files:"
> > SRC_URI+= "file://0001-drm-vc4-Keep-the-binner-BO-through-
> suspend.patch"
> >
> >
> > Regards,
> > Greg
> >
> >
> > ________________________________
> > From: yocto@lists.yoctoproject.org <yocto@lists.yoctoproject.org> on
> behalf of Anders Montonen <Anders.Montonen@iki.fi>
> > Sent: Tuesday, March 10, 2020 11:07:33 PM
> > To: Yocto list discussion
> > Subject: Re: [yocto] Getting kernel patch to work
> >
> > Hi,
> >
> > > On 11 Mar 2020, at 1:57, Greg Wilson-Lindberg <GWilson@sakuraus.com>
> wrote:
> > >
> > > SRC_URi += "file://0001-drm-vc4-Keep-the-binner-BO-through-suspend-
> GWL.patch"
> >
> > It looks like you have a typo here, the last letter of SRC_URI isn't
> capitalized.
> >
> > -a
> >
>
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-03-12 17:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-10 23:57 Getting kernel patch to work Greg Wilson-Lindberg
2020-03-11 6:07 ` [yocto] " Anders Montonen
2020-03-11 23:43 ` Greg Wilson-Lindberg
2020-03-11 23:55 ` Denys Dmytriyenko
2020-03-12 17:51 ` Greg Wilson-Lindberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.