From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hiremath, Vaibhav" Subject: RE: [PATCH 1/3] ARM: OMAP2+: 32k-counter: Use hwmod lookup to check presence of 32k timer Date: Fri, 30 Mar 2012 11:29:16 +0000 Message-ID: <79CD15C6BA57404B839C016229A409A831841326@DBDE01.ent.ti.com> References: <1326983304-14619-1-git-send-email-hvaibhav@ti.com> <1326983304-14619-2-git-send-email-hvaibhav@ti.com> <87mx9ej8fp.fsf@ti.com> <79CD15C6BA57404B839C016229A409A83181EF3F@DBDE01.ent.ti.com> <4F672364.3020403@ti.com> <79CD15C6BA57404B839C016229A409A83182386C@DBDE01.ent.ti.com> <79CD15C6BA57404B839C016229A409A83183EA54@DBDE01.ent.ti.com> <79CD15C6BA57404B839C016229A409A83183EB47@DBDE01.ent.ti.com> <79CD15C6BA57404B839C016229A409A831840C2E@DBDE01.ent.ti.com> <79CD15C6BA57404B839C016229A409A831840E0C@DBDE01.ent.ti.com> <4F7570FC.8000907@ti.com> <79CD15C6BA57404B839C016229A409A831840F82@DBDE01.ent.ti.com> <79CD15C6BA57404B839C016229A409A831841009@DBDE01.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:46205 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933785Ab2C3L3e convert rfc822-to-8bit (ORCPT ); Fri, 30 Mar 2012 07:29:34 -0400 In-Reply-To: Content-Language: en-US Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Shilimkar, Santosh" Cc: Ming Lei , "Hilman, Kevin" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "marc.zyngier@arm.com" , "johnstul@us.ibm.com" , "Balbi, Felipe" , "Cousson, Benoit" , Tony Lindgren , Paul Walmsley , "DebBarma, Tarun Kanti" On Fri, Mar 30, 2012 at 15:12:19, Shilimkar, Santosh wrote: > On Fri, Mar 30, 2012 at 2:58 PM, Hiremath, Vaibhav wrote: > > On Fri, Mar 30, 2012 at 14:50:02, Shilimkar, Santosh wrote: > >> On Fri, Mar 30, 2012 at 2:42 PM, Hiremath, Vaibhav wrote: > >> > On Fri, Mar 30, 2012 at 14:08:20, Shilimkar, Santosh wrote: > >> >> On Friday 30 March 2012 02:02 PM, Hiremath, Vaibhav wrote: > >> >> > On Fri, Mar 30, 2012 at 13:11:35, Shilimkar, Santosh wrote: > >> <...> Santosh & others, Do you think, it makes sense to clean up the CONFIG_OMAP_32K_TIMER usage in mach-omap2/timer.c file now? Specifically below code-snippet - #ifdef CONFIG_OMAP_32K_TIMER #define OMAP2_CLKEV_SOURCE OMAP2_32K_SOURCE #define OMAP3_CLKEV_SOURCE OMAP3_32K_SOURCE #define OMAP4_CLKEV_SOURCE OMAP4_32K_SOURCE #define OMAP3_SECURE_TIMER 12 #else #define OMAP2_CLKEV_SOURCE OMAP2_MPU_SOURCE #define OMAP3_CLKEV_SOURCE OMAP3_MPU_SOURCE #define OMAP4_CLKEV_SOURCE OMAP4_MPU_SOURCE #define OMAP3_SECURE_TIMER 1 #endif And lets make 32k_fclk as default clocksource for gptimer, if it is being used as clocksource. Atleast with this I can clean whole omap2/3/4 families, and I can take omap1 thing later . (as I have to understand/read about omap1 first). If you agree, I can include this cleanup also in my next version of patch- series. What's your opinion here? Thanks, Vaibhav From mboxrd@z Thu Jan 1 00:00:00 1970 From: hvaibhav@ti.com (Hiremath, Vaibhav) Date: Fri, 30 Mar 2012 11:29:16 +0000 Subject: [PATCH 1/3] ARM: OMAP2+: 32k-counter: Use hwmod lookup to check presence of 32k timer In-Reply-To: References: <1326983304-14619-1-git-send-email-hvaibhav@ti.com> <1326983304-14619-2-git-send-email-hvaibhav@ti.com> <87mx9ej8fp.fsf@ti.com> <79CD15C6BA57404B839C016229A409A83181EF3F@DBDE01.ent.ti.com> <4F672364.3020403@ti.com> <79CD15C6BA57404B839C016229A409A83182386C@DBDE01.ent.ti.com> <79CD15C6BA57404B839C016229A409A83183EA54@DBDE01.ent.ti.com> <79CD15C6BA57404B839C016229A409A83183EB47@DBDE01.ent.ti.com> <79CD15C6BA57404B839C016229A409A831840C2E@DBDE01.ent.ti.com> <79CD15C6BA57404B839C016229A409A831840E0C@DBDE01.ent.ti.com> <4F7570FC.8000907@ti.com> <79CD15C6BA57404B839C016229A409A831840F82@DBDE01.ent.ti.com> <79CD15C6BA57404B839C016229A409A831841009@DBDE01.ent.ti.com> Message-ID: <79CD15C6BA57404B839C016229A409A831841326@DBDE01.ent.ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Mar 30, 2012 at 15:12:19, Shilimkar, Santosh wrote: > On Fri, Mar 30, 2012 at 2:58 PM, Hiremath, Vaibhav wrote: > > On Fri, Mar 30, 2012 at 14:50:02, Shilimkar, Santosh wrote: > >> On Fri, Mar 30, 2012 at 2:42 PM, Hiremath, Vaibhav wrote: > >> > On Fri, Mar 30, 2012 at 14:08:20, Shilimkar, Santosh wrote: > >> >> On Friday 30 March 2012 02:02 PM, Hiremath, Vaibhav wrote: > >> >> > On Fri, Mar 30, 2012 at 13:11:35, Shilimkar, Santosh wrote: > >> <...> Santosh & others, Do you think, it makes sense to clean up the CONFIG_OMAP_32K_TIMER usage in mach-omap2/timer.c file now? Specifically below code-snippet - #ifdef CONFIG_OMAP_32K_TIMER #define OMAP2_CLKEV_SOURCE OMAP2_32K_SOURCE #define OMAP3_CLKEV_SOURCE OMAP3_32K_SOURCE #define OMAP4_CLKEV_SOURCE OMAP4_32K_SOURCE #define OMAP3_SECURE_TIMER 12 #else #define OMAP2_CLKEV_SOURCE OMAP2_MPU_SOURCE #define OMAP3_CLKEV_SOURCE OMAP3_MPU_SOURCE #define OMAP4_CLKEV_SOURCE OMAP4_MPU_SOURCE #define OMAP3_SECURE_TIMER 1 #endif And lets make 32k_fclk as default clocksource for gptimer, if it is being used as clocksource. Atleast with this I can clean whole omap2/3/4 families, and I can take omap1 thing later . (as I have to understand/read about omap1 first). If you agree, I can include this cleanup also in my next version of patch- series. What's your opinion here? Thanks, Vaibhav