From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hiremath, Vaibhav" Subject: RE: [PATCH 02/13] ARM: OMAP5: Add minimal support for OMAP5430 SOC Date: Tue, 8 May 2012 05:49:13 +0000 Message-ID: <79CD15C6BA57404B839C016229A409A83EA18A6A@DBDE01.ent.ti.com> References: <1336029982-31898-1-git-send-email-r.sricharan@ti.com> <1336029982-31898-3-git-send-email-r.sricharan@ti.com> <20120504223933.GX5613@atomide.com> <20120507191847.GJ5088@atomide.com> <20120507193500.GK5088@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:57594 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750834Ab2EHFtT convert rfc822-to-8bit (ORCPT ); Tue, 8 May 2012 01:49:19 -0400 In-Reply-To: <20120507193500.GK5088@atomide.com> Content-Language: en-US Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Tony Lindgren , Paul Walmsley Cc: "R, Sricharan" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Shilimkar, Santosh" , "Cousson, Benoit" On Tue, May 08, 2012 at 01:05:01, Tony Lindgren wrote: > * Tony Lindgren [120507 12:22]: > > * Paul Walmsley [120507 12:11]: > > > Hi, > > > > > > On Fri, 4 May 2012, Tony Lindgren wrote: > > > > > > > How about we add CONFIG_SOC_OMAP3PLUS in the clean-up series? > > > > Then this becomes just: > > > > > > > > #ifdef CONFIG_SOC_OMAP3PLUS > > > > > > We might want to consider having separate CONFIG_SOC_* values for each > > > SoC. So rather than CONFIG_SOC_OMAP3PLUS, we'd have CONFIG_SOC_OMAP3430, > > > CONFIG_SOC_OMAP3630, etc. > > > > Hmm but this would be in addition to the SOC specific options. The goal > > is to cut down the ifdeffery needed all over the place to add new SoCs, > > see the experimental patch I posted: > > > > http://www.mail-archive.com/linux-omap@vger.kernel.org/msg67938.html > > Of course we could make this finer grained based on features > like SOC_HAS_XYZ or SOC_HAS_OMAP3PLUS_PRMXYZBITS if you have some > grouping like that in mind. > This is much better approach than both ARCH_OMAPx and SOC_OMAPxxxx. Thanks, Vaibhav From mboxrd@z Thu Jan 1 00:00:00 1970 From: hvaibhav@ti.com (Hiremath, Vaibhav) Date: Tue, 8 May 2012 05:49:13 +0000 Subject: [PATCH 02/13] ARM: OMAP5: Add minimal support for OMAP5430 SOC In-Reply-To: <20120507193500.GK5088@atomide.com> References: <1336029982-31898-1-git-send-email-r.sricharan@ti.com> <1336029982-31898-3-git-send-email-r.sricharan@ti.com> <20120504223933.GX5613@atomide.com> <20120507191847.GJ5088@atomide.com> <20120507193500.GK5088@atomide.com> Message-ID: <79CD15C6BA57404B839C016229A409A83EA18A6A@DBDE01.ent.ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, May 08, 2012 at 01:05:01, Tony Lindgren wrote: > * Tony Lindgren [120507 12:22]: > > * Paul Walmsley [120507 12:11]: > > > Hi, > > > > > > On Fri, 4 May 2012, Tony Lindgren wrote: > > > > > > > How about we add CONFIG_SOC_OMAP3PLUS in the clean-up series? > > > > Then this becomes just: > > > > > > > > #ifdef CONFIG_SOC_OMAP3PLUS > > > > > > We might want to consider having separate CONFIG_SOC_* values for each > > > SoC. So rather than CONFIG_SOC_OMAP3PLUS, we'd have CONFIG_SOC_OMAP3430, > > > CONFIG_SOC_OMAP3630, etc. > > > > Hmm but this would be in addition to the SOC specific options. The goal > > is to cut down the ifdeffery needed all over the place to add new SoCs, > > see the experimental patch I posted: > > > > http://www.mail-archive.com/linux-omap at vger.kernel.org/msg67938.html > > Of course we could make this finer grained based on features > like SOC_HAS_XYZ or SOC_HAS_OMAP3PLUS_PRMXYZBITS if you have some > grouping like that in mind. > This is much better approach than both ARCH_OMAPx and SOC_OMAPxxxx. Thanks, Vaibhav