All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hiremath, Vaibhav <hvaibhav@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ARM: omap3: Set SPL stack size to 8KB, image to 54KB.
Date: Wed, 9 May 2012 10:03:21 +0000	[thread overview]
Message-ID: <79CD15C6BA57404B839C016229A409A83EA1C089@DBDE01.ent.ti.com> (raw)
In-Reply-To: <4FA962B7.3070109@ti.com>

On Tue, May 08, 2012 at 23:45:19, Rini, Tom wrote:
> On 05/08/2012 10:40 AM, Hiremath, Vaibhav wrote:
> > On Tue, May 08, 2012 at 22:59:31, Rini, Tom wrote:
> >> With older toolchains it is possible to not fit entirely into the 45KB
> >> that we had assigned to SPL.  Adjust to allow for 8KB of stack (which
> >> should be more than required) and 54KB of text/data.
> >>
> >
> > Tom,
> >
> > Can you provide more details on why 45Kb is not sufficient for SPL?
> 
> A combination of toolchains and enabled options will break this limit 
> (for example, beagle is size-broken once we enable i2c to whack the 
> twl4030 with ELDK4.2).  Rather than giving just one more KB to fix the 
> problem today, but run into it tomorrow, I'm pushing towards the biggest 
> split we can use.
> 

Exactly, I understand the need here. Can you please update the commit 
description with above details, the original patch commit description only 
talks about toolchain, but it is not only the toolchain, right?

Else looks ok to me.

Acked-by: Vaibhav Hiremath <hvaibhav@ti.com>

Thanks,
Vaibhav

> > You may have done some memory analysis on this; can you share that here?
> > Also, do we know how much ROM code is using out of 64KB of RAM?
> 
> We know that ROM loads us to 0x40200800 and we're allowed from there to 
> the end of SRAM to do as we please.  This is just adjusting the split 
> SPL makes into text+data and stack.
> 
> -- 
> Tom
> 

  reply	other threads:[~2012-05-09 10:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-08 17:29 [U-Boot] [PATCH 1/2] ARM: omap3: Set SPL stack size to 8KB, image to 54KB Tom Rini
2012-05-08 17:29 ` [U-Boot] [PATCH 2/2] ARM: omap3: Add CONFIG_SPL_BOARD_INIT for CONFIG_SPL_MMC_SUPPORT Tom Rini
2012-05-09  7:44   ` Thomas Weber
2012-05-09 14:13     ` Tom Rini
2012-05-09 18:54     ` Tom Rini
2012-05-08 17:40 ` [U-Boot] [PATCH 1/2] ARM: omap3: Set SPL stack size to 8KB, image to 54KB Hiremath, Vaibhav
2012-05-08 18:15   ` Tom Rini
2012-05-09 10:03     ` Hiremath, Vaibhav [this message]
2012-05-09  6:51 ` R, Sricharan
2012-05-09 14:05   ` Tom Rini
2012-05-09  9:45 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79CD15C6BA57404B839C016229A409A83EA1C089@DBDE01.ent.ti.com \
    --to=hvaibhav@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.