From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D3E2C433F5 for ; Tue, 5 Oct 2021 19:27:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70A006120F for ; Tue, 5 Oct 2021 19:27:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234762AbhJET3O (ORCPT ); Tue, 5 Oct 2021 15:29:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbhJET3N (ORCPT ); Tue, 5 Oct 2021 15:29:13 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E557AC061749 for ; Tue, 5 Oct 2021 12:27:22 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id t8so981585wri.1 for ; Tue, 05 Oct 2021 12:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gjGbZQFATwhF+BES3nhgMC8T008nZ3OInRqvg+24qlo=; b=UrohL+upv4vlrkwkvaFauYBW9yeI+t5LBdA74nxK6EUFBjQFfxSjZESHmsOL9VLdQQ m9syZF7vkkjdVm/nDeF/BYFoXmCpb1sMrewykOtb/hEFj29x4/Kg2VMLREKcpAHYTn1C 74avyLnpMeYxn0pNnZD6ffe71lVglJSgko83XgSyKjJAD4Ycl3ysLSiNEOvqh6JIMZh/ FZhEHGg+lieSd4QLk3BGoHv3u/H2U2F2NQXLaiaqdIf+Bk4iYz0di7QqP8GemttuUgi5 KcMMNOVowG5GuyXgbmmPs6JVTYqcPZg8JClLX58HPyuXDSYm2+v1nlMlrscpSL7VcPMP 9ngw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gjGbZQFATwhF+BES3nhgMC8T008nZ3OInRqvg+24qlo=; b=3Uo5Z0UbI+z3p1qidIm7+L43DOE07kIRooeE+jKtwI/VGReWQ7N5KIh4fjsqg+AvTA RxAoolnue1r4IYaevOOELe3/QCLL+UqWurzYrVnKBdN+MkeJrqbyGAlQM8m4+ong5N9b PpplEmo/VlTSChnJWSi3EuA5R2DPsBK5JCjF316z25BfoJlovq0fi+mgWOPd1Jp9EKHN mATQlwe9WLX0JwiyVyRMy1GcHoK5+WY4JW9OIb6sn9IAoZg0cBAxrLtNK9gJcEe8iKxj nJGcoHd16ds1Hg38J9mdaSGK0qDaYIjYLMWSWXdE8E75kWxi9Ixqbjw26aK4UsXNvmr4 Z2jQ== X-Gm-Message-State: AOAM531lqH4ry2LBDznaSEnCF4msE3N3WCQoZ8YR2IJvGiuObwEyKNLi oyWTSBT+8R8oX/oWnT5iluI= X-Google-Smtp-Source: ABdhPJxGvGzHYlon9ExqeHoSmKdWMwW1h9D3Y2v58vJK0sc8Pe5g8O3IcFEmry7YN9RlXZA+NbsL0A== X-Received: by 2002:a1c:4484:: with SMTP id r126mr5381571wma.150.1633462041536; Tue, 05 Oct 2021 12:27:21 -0700 (PDT) Received: from [192.168.1.36] (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id p18sm7312497wrt.96.2021.10.05.12.27.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 12:27:20 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Message-ID: <79bc4067-1ed0-0b06-e847-2875c75ffb9f@amsat.org> Date: Tue, 5 Oct 2021 21:27:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v3] target/i386: Include 'hw/i386/apic.h' locally Content-Language: en-US To: Laurent Vivier , "Michael S. Tsirkin" Cc: Eduardo Habkost , kvm@vger.kernel.org, qemu-trivial@nongnu.org, haxm-team@intel.com, Richard Henderson , qemu-devel@nongnu.org, Cameron Esfahani , Kamil Rytarowski , Reinoud Zandijk , Colin Xu , Roman Bolshakov , Paolo Bonzini , Sunil Muthuswamy , Wenchao Wang References: <20210929163124.2523413-1-f4bug@amsat.org> <20211005105745-mutt-send-email-mst@kernel.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 10/5/21 18:45, Laurent Vivier wrote: > Le 05/10/2021 à 16:57, Michael S. Tsirkin a écrit : >> On Wed, Sep 29, 2021 at 06:31:24PM +0200, Philippe Mathieu-Daudé wrote: >>> Instead of including a sysemu-specific header in "cpu.h" >>> (which is shared with user-mode emulations), include it >>> locally when required. >>> >>> Acked-by: Paolo Bonzini >>> Signed-off-by: Philippe Mathieu-Daudé >> >> Acked-by: Michael S. Tsirkin >> >> which tree? trivial I guess? > > Yes, but for me the patch was not correct because there is no need to update target/i386/cpu-dump.c > But perhaps I misunderstood the answer from Philippe? You understood correctly, this series requires a respin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65383C433EF for ; Tue, 5 Oct 2021 19:28:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0818761027 for ; Tue, 5 Oct 2021 19:28:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0818761027 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:36344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXq7T-0001Yz-6e for qemu-devel@archiver.kernel.org; Tue, 05 Oct 2021 15:28:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXq60-000088-Mq; Tue, 05 Oct 2021 15:27:24 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:38522) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mXq5z-0003bM-69; Tue, 05 Oct 2021 15:27:24 -0400 Received: by mail-wr1-x42e.google.com with SMTP id u18so939297wrg.5; Tue, 05 Oct 2021 12:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gjGbZQFATwhF+BES3nhgMC8T008nZ3OInRqvg+24qlo=; b=UrohL+upv4vlrkwkvaFauYBW9yeI+t5LBdA74nxK6EUFBjQFfxSjZESHmsOL9VLdQQ m9syZF7vkkjdVm/nDeF/BYFoXmCpb1sMrewykOtb/hEFj29x4/Kg2VMLREKcpAHYTn1C 74avyLnpMeYxn0pNnZD6ffe71lVglJSgko83XgSyKjJAD4Ycl3ysLSiNEOvqh6JIMZh/ FZhEHGg+lieSd4QLk3BGoHv3u/H2U2F2NQXLaiaqdIf+Bk4iYz0di7QqP8GemttuUgi5 KcMMNOVowG5GuyXgbmmPs6JVTYqcPZg8JClLX58HPyuXDSYm2+v1nlMlrscpSL7VcPMP 9ngw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gjGbZQFATwhF+BES3nhgMC8T008nZ3OInRqvg+24qlo=; b=dLtERjkAPOiJ4NiCKSUMIQk/ZAZ2Zgh4Mx50HhwRqwe1HFxxcKX2vU59EcRDc+l0WZ E71uUyRkSNHwRpCaiDaleIrZR6cTYPVENVyIJVJQ1g0qA/UOYAaro5stdJGiBku/tDNw R6QOVAbEUu98Mj9afb6m425N6jB2JLQ1iidtguTIxC22ci3JgGijM62isLFLA7kGxFkb jAnYLHmO9pEkMsXQ8Gcy1CTlDsqH1q2EO29L0hYhfG8vcKXilZHLkxLCt7ofAIxAA2by LDfX6nnVwVUCtfUjJPaW0sfVOfeJcxodL4oZeJYDc0o9UMdn2B3BXKo99iJehmuvyBlZ nqBw== X-Gm-Message-State: AOAM531QwisSDShiMib8RGedWLuyH9+c9R73MixVZuwDqETGpYvFYhwv aiHFo9BABWkcZW7z6oEwXSg= X-Google-Smtp-Source: ABdhPJxGvGzHYlon9ExqeHoSmKdWMwW1h9D3Y2v58vJK0sc8Pe5g8O3IcFEmry7YN9RlXZA+NbsL0A== X-Received: by 2002:a1c:4484:: with SMTP id r126mr5381571wma.150.1633462041536; Tue, 05 Oct 2021 12:27:21 -0700 (PDT) Received: from [192.168.1.36] (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id p18sm7312497wrt.96.2021.10.05.12.27.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Oct 2021 12:27:20 -0700 (PDT) Message-ID: <79bc4067-1ed0-0b06-e847-2875c75ffb9f@amsat.org> Date: Tue, 5 Oct 2021 21:27:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v3] target/i386: Include 'hw/i386/apic.h' locally Content-Language: en-US To: Laurent Vivier , "Michael S. Tsirkin" References: <20210929163124.2523413-1-f4bug@amsat.org> <20211005105745-mutt-send-email-mst@kernel.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42e.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , kvm@vger.kernel.org, qemu-trivial@nongnu.org, Richard Henderson , qemu-devel@nongnu.org, Cameron Esfahani , Kamil Rytarowski , Paolo Bonzini , haxm-team@intel.com, Colin Xu , Roman Bolshakov , Reinoud Zandijk , Sunil Muthuswamy , Wenchao Wang Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/5/21 18:45, Laurent Vivier wrote: > Le 05/10/2021 à 16:57, Michael S. Tsirkin a écrit : >> On Wed, Sep 29, 2021 at 06:31:24PM +0200, Philippe Mathieu-Daudé wrote: >>> Instead of including a sysemu-specific header in "cpu.h" >>> (which is shared with user-mode emulations), include it >>> locally when required. >>> >>> Acked-by: Paolo Bonzini >>> Signed-off-by: Philippe Mathieu-Daudé >> >> Acked-by: Michael S. Tsirkin >> >> which tree? trivial I guess? > > Yes, but for me the patch was not correct because there is no need to update target/i386/cpu-dump.c > But perhaps I misunderstood the answer from Philippe? You understood correctly, this series requires a respin.