From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 608E3C43334 for ; Wed, 8 Jun 2022 02:44:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B797B10E1F1; Wed, 8 Jun 2022 02:44:09 +0000 (UTC) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by gabe.freedesktop.org (Postfix) with ESMTPS id B34A510E376 for ; Wed, 8 Jun 2022 02:44:08 +0000 (UTC) X-UUID: 5d9d18f1fbb24968ad8220c6c8b67a62-20220608 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5, REQID:5582af41-9384-4a7e-976b-08a1a2fa5e80, OB:0, LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09, CLOUDID:56ac8f7e-c8dc-403a-96e8-6237210dceee, C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 5d9d18f1fbb24968ad8220c6c8b67a62-20220608 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 246062154; Wed, 08 Jun 2022 10:44:03 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Wed, 8 Jun 2022 10:44:01 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Wed, 8 Jun 2022 10:44:01 +0800 Message-ID: <79bea587e20de842d48dcb2e1da19e276f9d635b.camel@mediatek.com> Subject: Re: [PATCH v10 18/21] drm/mediatek: Add mt8195 Embedded DisplayPort driver From: CK Hu To: Rex-BC Chen , Guillaume Ranquet , Chun-Kuang Hu , "Philipp Zabel" , David Airlie , "Daniel Vetter" , Rob Herring , "Krzysztof Kozlowski" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Matthias Brugger , Chunfeng Yun =?UTF-8?Q?=28=E4=BA=91=E6=98=A5=E5=B3=B0=29?= , Kishon Vijay Abraham I , Vinod Koul , Helge Deller , Jitao Shi =?UTF-8?Q?=28=E7=9F=B3=E8=AE=B0=E6=B6=9B=29?= Date: Wed, 8 Jun 2022 10:44:01 +0800 In-Reply-To: <4329859ca11c13e7f6a9951b01a779fc391f029b.camel@mediatek.com> References: <20220523104758.29531-1-granquet@baylibre.com> <20220523104758.29531-19-granquet@baylibre.com> <4329859ca11c13e7f6a9951b01a779fc391f029b.camel@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "linux-fbdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Markus Schneider-Pargmann , "linux-mediatek@lists.infradead.org" , "linux-phy@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Rex: On Tue, 2022-06-07 at 20:44 +0800, Rex-BC Chen wrote: > On Tue, 2022-06-07 at 14:44 +0800, CK Hu wrote: > > Hi, Rex: > > > > On Mon, 2022-05-23 at 12:47 +0200, Guillaume Ranquet wrote: > > > From: Markus Schneider-Pargmann > > > > > > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. > > > > > > It supports the mt8195, the embedded DisplayPort units. It offers > > > DisplayPort 1.4 with up to 4 lanes. > > > > > > The driver creates a child device for the phy. The child device > > > will > > > never exist without the parent being active. As they are sharing > > > a > > > register range, the parent passes a regmap pointer to the child > > > so > > > that > > > both can work with the same register range. The phy driver sets > > > device > > > data that is read by the parent to get the phy device that can be > > > used > > > to control the phy properties. > > > > > > This driver is based on an initial version by > > > Jason-JH.Lin . > > > > > > Signed-off-by: Markus Schneider-Pargmann > > > Signed-off-by: Guillaume Ranquet > > > --- > > > > [snip] > > > > > + > > > +static int mtk_dp_train_handler(struct mtk_dp *mtk_dp) > > > +{ > > > + bool training_done = false; > > > + short max_retry = 50; > > > + int ret = 0; > > > + > > > + do { > > > + switch (mtk_dp->train_state) { > > > + case MTK_DP_TRAIN_STATE_STARTUP: > > > > mtk_dp->train_state is initialized as MTK_DP_TRAIN_STATE_STARTUP > > even > > though HPD ISR does not exist. Does this mean HPD ISR is redundant? > > If > > HPD ISR is not redundant, create a new state > > MTK_DP_TRAIN_STATE_NONE > > for init state. > > > > Hello CK, > > I think we don't need MTK_DP_TRAIN_STATE_NONE. > Because it's "DP_TRAIN_STATE" not "DP_STATE", I think it's ok if we > start this state machine with "MTK_DP_TRAIN_STATE_STARTUP". The initial state is MTK_DP_TRAIN_STATE_STARTUP, and HPD thread would change state from MTK_DP_TRAIN_STATE_STARTUP to MTK_DP_TRAIN_STATE_STARTUP, this is redundant. So drop the state change in HPD thread. > > > > + mtk_dp_state_handler(mtk_dp); > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_CHECKCAP; > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_CHECKCAP: > > > + if (mtk_dp_parse_capabilities(mtk_dp)) { > > > + mtk_dp->train_info.check_cap_count = 0; > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_CHECKEDID; > > > + } else { > > > + mtk_dp->train_info.check_cap_count++; > > > + > > > + if (mtk_dp->train_info.check_cap_count > > > > > > > > > > + MTK_DP_CHECK_SINK_CAP_TIMEOUT_COUNT > > > ) { > > > + mtk_dp- > > > > train_info.check_cap_count = 0; > > > > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_DPIDLE; > > > + ret = -ETIMEDOUT; > > > + } > > > + } > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_CHECKEDID: > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_TRAINING_PRE; > > > > MTK_DP_TRAIN_STATE_CHECKEDID is a redundant state, drop it. > > > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_TRAINING_PRE: > > > + mtk_dp_state_handler(mtk_dp); > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_TRAINING; > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_TRAINING: > > > + ret = mtk_dp_train_start(mtk_dp); > > > + if (ret == 0) { > > > + mtk_dp_video_mute(mtk_dp, true); > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_NORMAL; > > > + mtk_dp_fec_enable(mtk_dp, mtk_dp- > > > > has_fec); > > > > > > + } else if (ret != -EAGAIN) { > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_DPIDLE; > > > + } > > > + break; > > > + case MTK_DP_TRAIN_STATE_NORMAL: > > > + mtk_dp_state_handler(mtk_dp); > > > + training_done = true; > > > + break; > > > + case MTK_DP_TRAIN_STATE_DPIDLE: > > > > When would this case happen? > > > > Regards, > > CK > > Yes, if it's disconnected if we are still training for dp. > or failed to training min spec RBR. I mean, every time state change to MTK_DP_TRAIN_STATE_DPIDLE, it would jump out of this loop and would not get into this loop, so this case would never get in. This is redundant, so remove this. Regards, CK > > BRs, > Rex > > > > > + break; > > > + default: > > > + break; > > > + } > > > + > > > + if (ret) { > > > + if (ret == -EAGAIN) > > > + continue; > > > + /* > > > + * If we get any other error number, it doesn't > > > + * make any sense to keep iterating. > > > + */ > > > + break; > > > + } > > > + } while (!training_done || --max_retry); > > > + > > > + return ret; > > > +} > > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE123C433EF for ; Wed, 8 Jun 2022 02:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=16bhuf/S8ldivz2POndsmVmKEsNj/g+en3esJS81Tj4=; b=MAAO/v42AvPcMc LsLkP3hLHJf/EuGHzoB/kLQ+b2scsKd/8B3ljMm9sO4qjpXtCbb7cYpycUltBHYk9jGRhtRdiqGSk EuQ/LJYUtuLqIOpAyOZpu8rJE4H4UBJQCIuwUBCHl4C4nqpr+KAUH1T4k/COnOy7ukdlAbx/bNSWR ikknUaOrvm0jIw7ryiOSUvy0Z6FoaMsQNQMUsZtY81GVf4OXJ7hyPmy/RTtlssNitA5PkrG6+X1PE lKC7U/xxHXgvfVKfMVj84flzUKUMvvoPgXvNUnu7jxaaCJiyIZxgrGawwrfsf1+9HnFwo/GYk6vOh y+j29EimBVzygB516Y0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nylim-00AQW6-Uy; Wed, 08 Jun 2022 02:47:00 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nylia-00AQPu-H1; Wed, 08 Jun 2022 02:46:50 +0000 X-UUID: 08ff7bd8e3654236866e7400ee690e5a-20220607 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:91eb4bbd-dca9-43b6-9baf-f9fb2ee08b10,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09,CLOUDID:e3cc8f7e-c8dc-403a-96e8-6237210dceee,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 08ff7bd8e3654236866e7400ee690e5a-20220607 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 600789370; Tue, 07 Jun 2022 19:46:43 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Jun 2022 19:44:03 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Wed, 8 Jun 2022 10:44:01 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Wed, 8 Jun 2022 10:44:01 +0800 Message-ID: <79bea587e20de842d48dcb2e1da19e276f9d635b.camel@mediatek.com> Subject: Re: [PATCH v10 18/21] drm/mediatek: Add mt8195 Embedded DisplayPort driver From: CK Hu To: Rex-BC Chen , Guillaume Ranquet , Chun-Kuang Hu , "Philipp Zabel" , David Airlie , "Daniel Vetter" , Rob Herring , "Krzysztof Kozlowski" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Matthias Brugger , Chunfeng Yun =?UTF-8?Q?=28=E4=BA=91=E6=98=A5=E5=B3=B0=29?= , Kishon Vijay Abraham I , Vinod Koul , "Helge Deller" , Jitao Shi =?UTF-8?Q?=28=E7=9F=B3=E8=AE=B0=E6=B6=9B=29?= CC: Markus Schneider-Pargmann , "dri-devel@lists.freedesktop.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-phy@lists.infradead.org" , "linux-fbdev@vger.kernel.org" Date: Wed, 8 Jun 2022 10:44:01 +0800 In-Reply-To: <4329859ca11c13e7f6a9951b01a779fc391f029b.camel@mediatek.com> References: <20220523104758.29531-1-granquet@baylibre.com> <20220523104758.29531-19-granquet@baylibre.com> <4329859ca11c13e7f6a9951b01a779fc391f029b.camel@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220607_194648_605231_4421F3BC X-CRM114-Status: GOOD ( 40.86 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi, Rex: On Tue, 2022-06-07 at 20:44 +0800, Rex-BC Chen wrote: > On Tue, 2022-06-07 at 14:44 +0800, CK Hu wrote: > > Hi, Rex: > > > > On Mon, 2022-05-23 at 12:47 +0200, Guillaume Ranquet wrote: > > > From: Markus Schneider-Pargmann > > > > > > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. > > > > > > It supports the mt8195, the embedded DisplayPort units. It offers > > > DisplayPort 1.4 with up to 4 lanes. > > > > > > The driver creates a child device for the phy. The child device > > > will > > > never exist without the parent being active. As they are sharing > > > a > > > register range, the parent passes a regmap pointer to the child > > > so > > > that > > > both can work with the same register range. The phy driver sets > > > device > > > data that is read by the parent to get the phy device that can be > > > used > > > to control the phy properties. > > > > > > This driver is based on an initial version by > > > Jason-JH.Lin . > > > > > > Signed-off-by: Markus Schneider-Pargmann > > > Signed-off-by: Guillaume Ranquet > > > --- > > > > [snip] > > > > > + > > > +static int mtk_dp_train_handler(struct mtk_dp *mtk_dp) > > > +{ > > > + bool training_done = false; > > > + short max_retry = 50; > > > + int ret = 0; > > > + > > > + do { > > > + switch (mtk_dp->train_state) { > > > + case MTK_DP_TRAIN_STATE_STARTUP: > > > > mtk_dp->train_state is initialized as MTK_DP_TRAIN_STATE_STARTUP > > even > > though HPD ISR does not exist. Does this mean HPD ISR is redundant? > > If > > HPD ISR is not redundant, create a new state > > MTK_DP_TRAIN_STATE_NONE > > for init state. > > > > Hello CK, > > I think we don't need MTK_DP_TRAIN_STATE_NONE. > Because it's "DP_TRAIN_STATE" not "DP_STATE", I think it's ok if we > start this state machine with "MTK_DP_TRAIN_STATE_STARTUP". The initial state is MTK_DP_TRAIN_STATE_STARTUP, and HPD thread would change state from MTK_DP_TRAIN_STATE_STARTUP to MTK_DP_TRAIN_STATE_STARTUP, this is redundant. So drop the state change in HPD thread. > > > > + mtk_dp_state_handler(mtk_dp); > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_CHECKCAP; > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_CHECKCAP: > > > + if (mtk_dp_parse_capabilities(mtk_dp)) { > > > + mtk_dp->train_info.check_cap_count = 0; > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_CHECKEDID; > > > + } else { > > > + mtk_dp->train_info.check_cap_count++; > > > + > > > + if (mtk_dp->train_info.check_cap_count > > > > > > > > > > + MTK_DP_CHECK_SINK_CAP_TIMEOUT_COUNT > > > ) { > > > + mtk_dp- > > > > train_info.check_cap_count = 0; > > > > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_DPIDLE; > > > + ret = -ETIMEDOUT; > > > + } > > > + } > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_CHECKEDID: > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_TRAINING_PRE; > > > > MTK_DP_TRAIN_STATE_CHECKEDID is a redundant state, drop it. > > > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_TRAINING_PRE: > > > + mtk_dp_state_handler(mtk_dp); > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_TRAINING; > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_TRAINING: > > > + ret = mtk_dp_train_start(mtk_dp); > > > + if (ret == 0) { > > > + mtk_dp_video_mute(mtk_dp, true); > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_NORMAL; > > > + mtk_dp_fec_enable(mtk_dp, mtk_dp- > > > > has_fec); > > > > > > + } else if (ret != -EAGAIN) { > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_DPIDLE; > > > + } > > > + break; > > > + case MTK_DP_TRAIN_STATE_NORMAL: > > > + mtk_dp_state_handler(mtk_dp); > > > + training_done = true; > > > + break; > > > + case MTK_DP_TRAIN_STATE_DPIDLE: > > > > When would this case happen? > > > > Regards, > > CK > > Yes, if it's disconnected if we are still training for dp. > or failed to training min spec RBR. I mean, every time state change to MTK_DP_TRAIN_STATE_DPIDLE, it would jump out of this loop and would not get into this loop, so this case would never get in. This is redundant, so remove this. Regards, CK > > BRs, > Rex > > > > > + break; > > > + default: > > > + break; > > > + } > > > + > > > + if (ret) { > > > + if (ret == -EAGAIN) > > > + continue; > > > + /* > > > + * If we get any other error number, it doesn't > > > + * make any sense to keep iterating. > > > + */ > > > + break; > > > + } > > > + } while (!training_done || --max_retry); > > > + > > > + return ret; > > > +} > > > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42512C43334 for ; Wed, 8 Jun 2022 02:47:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k2Nqjg2A2aAV6grWstq7wSE8Njch2b3UjBt0VultOJ0=; b=1b0XeOtSceLorv sCN1SiXFfuHyKQHSkiKatLAcofaeTAKFjL8gjgbubeWchKBAqV0cggni7ZdgA/Vzjd4dhFDCwygth 9x+uyjfj15Smwt9MO1sFFTQdfsJdK0qTjnz5H8um0QwkPEWONh8DFv0u3aVwI0SJke4KhW4rdNwdP 22OAgxYAfj8UzCTu4DpGca7mjPUSbnLmG3hnFBjFMs7UuLcXlWHm2odi95fZeEl3kXgYUddFMBd+7 Dyn9CzbG32ngPHdDA6vwGMwJaI+AIHxTyzb0FbcsJog3QyRluhG1ZCVr1D9mPJ0fh7FTinlgB/XVe D9Y6fXZwH1ONj0w9wO9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nylin-00AQWN-Kk; Wed, 08 Jun 2022 02:47:01 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nylia-00AQPu-H1; Wed, 08 Jun 2022 02:46:50 +0000 X-UUID: 08ff7bd8e3654236866e7400ee690e5a-20220607 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:91eb4bbd-dca9-43b6-9baf-f9fb2ee08b10,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09,CLOUDID:e3cc8f7e-c8dc-403a-96e8-6237210dceee,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 08ff7bd8e3654236866e7400ee690e5a-20220607 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 600789370; Tue, 07 Jun 2022 19:46:43 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Jun 2022 19:44:03 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Wed, 8 Jun 2022 10:44:01 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Wed, 8 Jun 2022 10:44:01 +0800 Message-ID: <79bea587e20de842d48dcb2e1da19e276f9d635b.camel@mediatek.com> Subject: Re: [PATCH v10 18/21] drm/mediatek: Add mt8195 Embedded DisplayPort driver From: CK Hu To: Rex-BC Chen , Guillaume Ranquet , Chun-Kuang Hu , "Philipp Zabel" , David Airlie , "Daniel Vetter" , Rob Herring , "Krzysztof Kozlowski" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Matthias Brugger , Chunfeng Yun =?UTF-8?Q?=28=E4=BA=91=E6=98=A5=E5=B3=B0=29?= , Kishon Vijay Abraham I , Vinod Koul , "Helge Deller" , Jitao Shi =?UTF-8?Q?=28=E7=9F=B3=E8=AE=B0=E6=B6=9B=29?= CC: Markus Schneider-Pargmann , "dri-devel@lists.freedesktop.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-phy@lists.infradead.org" , "linux-fbdev@vger.kernel.org" Date: Wed, 8 Jun 2022 10:44:01 +0800 In-Reply-To: <4329859ca11c13e7f6a9951b01a779fc391f029b.camel@mediatek.com> References: <20220523104758.29531-1-granquet@baylibre.com> <20220523104758.29531-19-granquet@baylibre.com> <4329859ca11c13e7f6a9951b01a779fc391f029b.camel@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220607_194648_605231_4421F3BC X-CRM114-Status: GOOD ( 40.86 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi, Rex: On Tue, 2022-06-07 at 20:44 +0800, Rex-BC Chen wrote: > On Tue, 2022-06-07 at 14:44 +0800, CK Hu wrote: > > Hi, Rex: > > > > On Mon, 2022-05-23 at 12:47 +0200, Guillaume Ranquet wrote: > > > From: Markus Schneider-Pargmann > > > > > > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. > > > > > > It supports the mt8195, the embedded DisplayPort units. It offers > > > DisplayPort 1.4 with up to 4 lanes. > > > > > > The driver creates a child device for the phy. The child device > > > will > > > never exist without the parent being active. As they are sharing > > > a > > > register range, the parent passes a regmap pointer to the child > > > so > > > that > > > both can work with the same register range. The phy driver sets > > > device > > > data that is read by the parent to get the phy device that can be > > > used > > > to control the phy properties. > > > > > > This driver is based on an initial version by > > > Jason-JH.Lin . > > > > > > Signed-off-by: Markus Schneider-Pargmann > > > Signed-off-by: Guillaume Ranquet > > > --- > > > > [snip] > > > > > + > > > +static int mtk_dp_train_handler(struct mtk_dp *mtk_dp) > > > +{ > > > + bool training_done = false; > > > + short max_retry = 50; > > > + int ret = 0; > > > + > > > + do { > > > + switch (mtk_dp->train_state) { > > > + case MTK_DP_TRAIN_STATE_STARTUP: > > > > mtk_dp->train_state is initialized as MTK_DP_TRAIN_STATE_STARTUP > > even > > though HPD ISR does not exist. Does this mean HPD ISR is redundant? > > If > > HPD ISR is not redundant, create a new state > > MTK_DP_TRAIN_STATE_NONE > > for init state. > > > > Hello CK, > > I think we don't need MTK_DP_TRAIN_STATE_NONE. > Because it's "DP_TRAIN_STATE" not "DP_STATE", I think it's ok if we > start this state machine with "MTK_DP_TRAIN_STATE_STARTUP". The initial state is MTK_DP_TRAIN_STATE_STARTUP, and HPD thread would change state from MTK_DP_TRAIN_STATE_STARTUP to MTK_DP_TRAIN_STATE_STARTUP, this is redundant. So drop the state change in HPD thread. > > > > + mtk_dp_state_handler(mtk_dp); > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_CHECKCAP; > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_CHECKCAP: > > > + if (mtk_dp_parse_capabilities(mtk_dp)) { > > > + mtk_dp->train_info.check_cap_count = 0; > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_CHECKEDID; > > > + } else { > > > + mtk_dp->train_info.check_cap_count++; > > > + > > > + if (mtk_dp->train_info.check_cap_count > > > > > > > > > > + MTK_DP_CHECK_SINK_CAP_TIMEOUT_COUNT > > > ) { > > > + mtk_dp- > > > > train_info.check_cap_count = 0; > > > > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_DPIDLE; > > > + ret = -ETIMEDOUT; > > > + } > > > + } > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_CHECKEDID: > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_TRAINING_PRE; > > > > MTK_DP_TRAIN_STATE_CHECKEDID is a redundant state, drop it. > > > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_TRAINING_PRE: > > > + mtk_dp_state_handler(mtk_dp); > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_TRAINING; > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_TRAINING: > > > + ret = mtk_dp_train_start(mtk_dp); > > > + if (ret == 0) { > > > + mtk_dp_video_mute(mtk_dp, true); > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_NORMAL; > > > + mtk_dp_fec_enable(mtk_dp, mtk_dp- > > > > has_fec); > > > > > > + } else if (ret != -EAGAIN) { > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_DPIDLE; > > > + } > > > + break; > > > + case MTK_DP_TRAIN_STATE_NORMAL: > > > + mtk_dp_state_handler(mtk_dp); > > > + training_done = true; > > > + break; > > > + case MTK_DP_TRAIN_STATE_DPIDLE: > > > > When would this case happen? > > > > Regards, > > CK > > Yes, if it's disconnected if we are still training for dp. > or failed to training min spec RBR. I mean, every time state change to MTK_DP_TRAIN_STATE_DPIDLE, it would jump out of this loop and would not get into this loop, so this case would never get in. This is redundant, so remove this. Regards, CK > > BRs, > Rex > > > > > + break; > > > + default: > > > + break; > > > + } > > > + > > > + if (ret) { > > > + if (ret == -EAGAIN) > > > + continue; > > > + /* > > > + * If we get any other error number, it doesn't > > > + * make any sense to keep iterating. > > > + */ > > > + break; > > > + } > > > + } while (!training_done || --max_retry); > > > + > > > + return ret; > > > +} > > > > > > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D324C433EF for ; Wed, 8 Jun 2022 02:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W823cKZCkxIayNJvWGJnIUtEDriE6ELvEfwHtRz4nqM=; b=tU6mRaF61OQaQH 1qg4gHlgfbfnHLjAMt9R0wDjdNzX7t62ltzyHPVP8GPCHMuaIuRNyougRGeSU2HbChBWiZaAg43Nh kMZPVAG6aSIexyV9Yu7USgCIBqX8oYAgECZLIWn4JAKvhFviSlYaZyQ4apFThEtpqj+rsu7DiqQLa iuM/JAXk8GOzIlgXjxCeiEvf4II1jzqMc17E2f3nG8mrsnUIhgmy+YZ3RHRbVoS8rAlFom78XRHuK re6qcnVj5KlrpwzeKujU+G8y8t8dipvUM1eaL1Ci5nY32YNxofoOvVLMIgiDjbU6Bn94ri9G5cawE cmP1916v/tOYEJlDt5WA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nylie-00AQSP-Az; Wed, 08 Jun 2022 02:46:52 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nylia-00AQPu-H1; Wed, 08 Jun 2022 02:46:50 +0000 X-UUID: 08ff7bd8e3654236866e7400ee690e5a-20220607 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:91eb4bbd-dca9-43b6-9baf-f9fb2ee08b10,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09,CLOUDID:e3cc8f7e-c8dc-403a-96e8-6237210dceee,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 08ff7bd8e3654236866e7400ee690e5a-20220607 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 600789370; Tue, 07 Jun 2022 19:46:43 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 7 Jun 2022 19:44:03 -0700 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Wed, 8 Jun 2022 10:44:01 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Wed, 8 Jun 2022 10:44:01 +0800 Message-ID: <79bea587e20de842d48dcb2e1da19e276f9d635b.camel@mediatek.com> Subject: Re: [PATCH v10 18/21] drm/mediatek: Add mt8195 Embedded DisplayPort driver From: CK Hu To: Rex-BC Chen , Guillaume Ranquet , Chun-Kuang Hu , "Philipp Zabel" , David Airlie , "Daniel Vetter" , Rob Herring , "Krzysztof Kozlowski" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Matthias Brugger , Chunfeng Yun =?UTF-8?Q?=28=E4=BA=91=E6=98=A5=E5=B3=B0=29?= , Kishon Vijay Abraham I , Vinod Koul , "Helge Deller" , Jitao Shi =?UTF-8?Q?=28=E7=9F=B3=E8=AE=B0=E6=B6=9B=29?= CC: Markus Schneider-Pargmann , "dri-devel@lists.freedesktop.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-phy@lists.infradead.org" , "linux-fbdev@vger.kernel.org" Date: Wed, 8 Jun 2022 10:44:01 +0800 In-Reply-To: <4329859ca11c13e7f6a9951b01a779fc391f029b.camel@mediatek.com> References: <20220523104758.29531-1-granquet@baylibre.com> <20220523104758.29531-19-granquet@baylibre.com> <4329859ca11c13e7f6a9951b01a779fc391f029b.camel@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220607_194648_605231_4421F3BC X-CRM114-Status: GOOD ( 40.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Rex: On Tue, 2022-06-07 at 20:44 +0800, Rex-BC Chen wrote: > On Tue, 2022-06-07 at 14:44 +0800, CK Hu wrote: > > Hi, Rex: > > > > On Mon, 2022-05-23 at 12:47 +0200, Guillaume Ranquet wrote: > > > From: Markus Schneider-Pargmann > > > > > > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. > > > > > > It supports the mt8195, the embedded DisplayPort units. It offers > > > DisplayPort 1.4 with up to 4 lanes. > > > > > > The driver creates a child device for the phy. The child device > > > will > > > never exist without the parent being active. As they are sharing > > > a > > > register range, the parent passes a regmap pointer to the child > > > so > > > that > > > both can work with the same register range. The phy driver sets > > > device > > > data that is read by the parent to get the phy device that can be > > > used > > > to control the phy properties. > > > > > > This driver is based on an initial version by > > > Jason-JH.Lin . > > > > > > Signed-off-by: Markus Schneider-Pargmann > > > Signed-off-by: Guillaume Ranquet > > > --- > > > > [snip] > > > > > + > > > +static int mtk_dp_train_handler(struct mtk_dp *mtk_dp) > > > +{ > > > + bool training_done = false; > > > + short max_retry = 50; > > > + int ret = 0; > > > + > > > + do { > > > + switch (mtk_dp->train_state) { > > > + case MTK_DP_TRAIN_STATE_STARTUP: > > > > mtk_dp->train_state is initialized as MTK_DP_TRAIN_STATE_STARTUP > > even > > though HPD ISR does not exist. Does this mean HPD ISR is redundant? > > If > > HPD ISR is not redundant, create a new state > > MTK_DP_TRAIN_STATE_NONE > > for init state. > > > > Hello CK, > > I think we don't need MTK_DP_TRAIN_STATE_NONE. > Because it's "DP_TRAIN_STATE" not "DP_STATE", I think it's ok if we > start this state machine with "MTK_DP_TRAIN_STATE_STARTUP". The initial state is MTK_DP_TRAIN_STATE_STARTUP, and HPD thread would change state from MTK_DP_TRAIN_STATE_STARTUP to MTK_DP_TRAIN_STATE_STARTUP, this is redundant. So drop the state change in HPD thread. > > > > + mtk_dp_state_handler(mtk_dp); > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_CHECKCAP; > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_CHECKCAP: > > > + if (mtk_dp_parse_capabilities(mtk_dp)) { > > > + mtk_dp->train_info.check_cap_count = 0; > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_CHECKEDID; > > > + } else { > > > + mtk_dp->train_info.check_cap_count++; > > > + > > > + if (mtk_dp->train_info.check_cap_count > > > > > > > > > > + MTK_DP_CHECK_SINK_CAP_TIMEOUT_COUNT > > > ) { > > > + mtk_dp- > > > > train_info.check_cap_count = 0; > > > > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_DPIDLE; > > > + ret = -ETIMEDOUT; > > > + } > > > + } > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_CHECKEDID: > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_TRAINING_PRE; > > > > MTK_DP_TRAIN_STATE_CHECKEDID is a redundant state, drop it. > > > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_TRAINING_PRE: > > > + mtk_dp_state_handler(mtk_dp); > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_TRAINING; > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_TRAINING: > > > + ret = mtk_dp_train_start(mtk_dp); > > > + if (ret == 0) { > > > + mtk_dp_video_mute(mtk_dp, true); > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_NORMAL; > > > + mtk_dp_fec_enable(mtk_dp, mtk_dp- > > > > has_fec); > > > > > > + } else if (ret != -EAGAIN) { > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_DPIDLE; > > > + } > > > + break; > > > + case MTK_DP_TRAIN_STATE_NORMAL: > > > + mtk_dp_state_handler(mtk_dp); > > > + training_done = true; > > > + break; > > > + case MTK_DP_TRAIN_STATE_DPIDLE: > > > > When would this case happen? > > > > Regards, > > CK > > Yes, if it's disconnected if we are still training for dp. > or failed to training min spec RBR. I mean, every time state change to MTK_DP_TRAIN_STATE_DPIDLE, it would jump out of this loop and would not get into this loop, so this case would never get in. This is redundant, so remove this. Regards, CK > > BRs, > Rex > > > > > + break; > > > + default: > > > + break; > > > + } > > > + > > > + if (ret) { > > > + if (ret == -EAGAIN) > > > + continue; > > > + /* > > > + * If we get any other error number, it doesn't > > > + * make any sense to keep iterating. > > > + */ > > > + break; > > > + } > > > + } while (!training_done || --max_retry); > > > + > > > + return ret; > > > +} > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4EDAC43334 for ; Wed, 8 Jun 2022 05:28:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230308AbiFHF2A (ORCPT ); Wed, 8 Jun 2022 01:28:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233689AbiFHF1g (ORCPT ); Wed, 8 Jun 2022 01:27:36 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C12E7188E8B; Tue, 7 Jun 2022 19:44:08 -0700 (PDT) X-UUID: 5d9d18f1fbb24968ad8220c6c8b67a62-20220608 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.5,REQID:5582af41-9384-4a7e-976b-08a1a2fa5e80,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:0 X-CID-META: VersionHash:2a19b09,CLOUDID:56ac8f7e-c8dc-403a-96e8-6237210dceee,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,QS:0,BEC:nil X-UUID: 5d9d18f1fbb24968ad8220c6c8b67a62-20220608 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 246062154; Wed, 08 Jun 2022 10:44:03 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Wed, 8 Jun 2022 10:44:01 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.3 via Frontend Transport; Wed, 8 Jun 2022 10:44:01 +0800 Message-ID: <79bea587e20de842d48dcb2e1da19e276f9d635b.camel@mediatek.com> Subject: Re: [PATCH v10 18/21] drm/mediatek: Add mt8195 Embedded DisplayPort driver From: CK Hu To: Rex-BC Chen , Guillaume Ranquet , Chun-Kuang Hu , "Philipp Zabel" , David Airlie , "Daniel Vetter" , Rob Herring , "Krzysztof Kozlowski" , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Matthias Brugger , Chunfeng Yun =?UTF-8?Q?=28=E4=BA=91=E6=98=A5=E5=B3=B0=29?= , Kishon Vijay Abraham I , Vinod Koul , Helge Deller , Jitao Shi =?UTF-8?Q?=28=E7=9F=B3=E8=AE=B0=E6=B6=9B=29?= CC: Markus Schneider-Pargmann , "dri-devel@lists.freedesktop.org" , "linux-mediatek@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-phy@lists.infradead.org" , "linux-fbdev@vger.kernel.org" Date: Wed, 8 Jun 2022 10:44:01 +0800 In-Reply-To: <4329859ca11c13e7f6a9951b01a779fc391f029b.camel@mediatek.com> References: <20220523104758.29531-1-granquet@baylibre.com> <20220523104758.29531-19-granquet@baylibre.com> <4329859ca11c13e7f6a9951b01a779fc391f029b.camel@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Rex: On Tue, 2022-06-07 at 20:44 +0800, Rex-BC Chen wrote: > On Tue, 2022-06-07 at 14:44 +0800, CK Hu wrote: > > Hi, Rex: > > > > On Mon, 2022-05-23 at 12:47 +0200, Guillaume Ranquet wrote: > > > From: Markus Schneider-Pargmann > > > > > > This patch adds a DisplayPort driver for the Mediatek mt8195 SoC. > > > > > > It supports the mt8195, the embedded DisplayPort units. It offers > > > DisplayPort 1.4 with up to 4 lanes. > > > > > > The driver creates a child device for the phy. The child device > > > will > > > never exist without the parent being active. As they are sharing > > > a > > > register range, the parent passes a regmap pointer to the child > > > so > > > that > > > both can work with the same register range. The phy driver sets > > > device > > > data that is read by the parent to get the phy device that can be > > > used > > > to control the phy properties. > > > > > > This driver is based on an initial version by > > > Jason-JH.Lin . > > > > > > Signed-off-by: Markus Schneider-Pargmann > > > Signed-off-by: Guillaume Ranquet > > > --- > > > > [snip] > > > > > + > > > +static int mtk_dp_train_handler(struct mtk_dp *mtk_dp) > > > +{ > > > + bool training_done = false; > > > + short max_retry = 50; > > > + int ret = 0; > > > + > > > + do { > > > + switch (mtk_dp->train_state) { > > > + case MTK_DP_TRAIN_STATE_STARTUP: > > > > mtk_dp->train_state is initialized as MTK_DP_TRAIN_STATE_STARTUP > > even > > though HPD ISR does not exist. Does this mean HPD ISR is redundant? > > If > > HPD ISR is not redundant, create a new state > > MTK_DP_TRAIN_STATE_NONE > > for init state. > > > > Hello CK, > > I think we don't need MTK_DP_TRAIN_STATE_NONE. > Because it's "DP_TRAIN_STATE" not "DP_STATE", I think it's ok if we > start this state machine with "MTK_DP_TRAIN_STATE_STARTUP". The initial state is MTK_DP_TRAIN_STATE_STARTUP, and HPD thread would change state from MTK_DP_TRAIN_STATE_STARTUP to MTK_DP_TRAIN_STATE_STARTUP, this is redundant. So drop the state change in HPD thread. > > > > + mtk_dp_state_handler(mtk_dp); > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_CHECKCAP; > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_CHECKCAP: > > > + if (mtk_dp_parse_capabilities(mtk_dp)) { > > > + mtk_dp->train_info.check_cap_count = 0; > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_CHECKEDID; > > > + } else { > > > + mtk_dp->train_info.check_cap_count++; > > > + > > > + if (mtk_dp->train_info.check_cap_count > > > > > > > > > > + MTK_DP_CHECK_SINK_CAP_TIMEOUT_COUNT > > > ) { > > > + mtk_dp- > > > > train_info.check_cap_count = 0; > > > > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_DPIDLE; > > > + ret = -ETIMEDOUT; > > > + } > > > + } > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_CHECKEDID: > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_TRAINING_PRE; > > > > MTK_DP_TRAIN_STATE_CHECKEDID is a redundant state, drop it. > > > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_TRAINING_PRE: > > > + mtk_dp_state_handler(mtk_dp); > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_TRAINING; > > > + break; > > > + > > > + case MTK_DP_TRAIN_STATE_TRAINING: > > > + ret = mtk_dp_train_start(mtk_dp); > > > + if (ret == 0) { > > > + mtk_dp_video_mute(mtk_dp, true); > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_NORMAL; > > > + mtk_dp_fec_enable(mtk_dp, mtk_dp- > > > > has_fec); > > > > > > + } else if (ret != -EAGAIN) { > > > + mtk_dp->train_state = > > > MTK_DP_TRAIN_STATE_DPIDLE; > > > + } > > > + break; > > > + case MTK_DP_TRAIN_STATE_NORMAL: > > > + mtk_dp_state_handler(mtk_dp); > > > + training_done = true; > > > + break; > > > + case MTK_DP_TRAIN_STATE_DPIDLE: > > > > When would this case happen? > > > > Regards, > > CK > > Yes, if it's disconnected if we are still training for dp. > or failed to training min spec RBR. I mean, every time state change to MTK_DP_TRAIN_STATE_DPIDLE, it would jump out of this loop and would not get into this loop, so this case would never get in. This is redundant, so remove this. Regards, CK > > BRs, > Rex > > > > > + break; > > > + default: > > > + break; > > > + } > > > + > > > + if (ret) { > > > + if (ret == -EAGAIN) > > > + continue; > > > + /* > > > + * If we get any other error number, it doesn't > > > + * make any sense to keep iterating. > > > + */ > > > + break; > > > + } > > > + } while (!training_done || --max_retry); > > > + > > > + return ret; > > > +} > > > > > >