All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Daniel Vetter" <daniel.vetter@intel.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, Martin Peres <martin.peres@free.fr>
Subject: Re: [PATCH RFC] drm/i915: reduce cursor size for GEN5 hardware
Date: Tue, 31 Jan 2017 10:03:26 +0100	[thread overview]
Message-ID: <79c23893-7a84-6bc6-140c-7db4d599aa48@linux.intel.com> (raw)
In-Reply-To: <20170131080949.13044-1-uwe@kleine-koenig.org>

Op 31-01-17 om 09:09 schreef Uwe Kleine-König:
> From: Chris Wilson <chris@chris-wilson.co.uk>
>
> As the introduced comment admits this is clearly a workaround, but for
> me this is the only known way to make my Lenovo X201 work without
> flickering and crashing.
>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> [uwe: added changelog, comment and restrict to GEN5]
> ---
> Hello,
>
> as I don't like having to compile my own kernel (which has this workaround) I
> suggest to apply this patch until someone with more knowledge than me about
> i915 finds the muse and time to work on this.
>
> If applying this patch means that I will become i915 maintainer, then please
> don't apply; I'm not ready for this :-)
>
> Best regards
> Uwe
Just curious, does this help?

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index ae2c0bb4b2e8..13de4c526ca6 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -1838,7 +1838,7 @@ static uint32_t ilk_compute_cur_wm(const struct intel_crtc_state *cstate,
 	 * this is necessary to avoid flickering.
 	 */
 	int cpp = 4;
-	int width = pstate->base.visible ? pstate->base.crtc_w : 64;
+	int width = 256;
 
 	if (!cstate->base.active)
 		return 0;

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-01-31  9:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-31  8:09 [PATCH RFC] drm/i915: reduce cursor size for GEN5 hardware Uwe Kleine-König
2017-01-31  9:03 ` Maarten Lankhorst [this message]
2017-01-31 19:13   ` Uwe Kleine-König
2017-02-01 12:41     ` Maarten Lankhorst
2017-02-01 14:37       ` Ville Syrjälä
2017-02-07 13:22         ` Uwe Kleine-König
2017-02-07 15:03           ` Martin Peres
2017-02-07 15:35             ` Ville Syrjälä
2017-02-07 17:51               ` Maarten Lankhorst
2017-02-07 17:58                 ` Ville Syrjälä
2017-02-17 11:10               ` Uwe Kleine-König
2017-02-17 15:01                 ` [PATCH] drm/i915: Fix legacy cursor vs. watermarks for ILK-BDW ville.syrjala
2017-02-17 20:04                   ` Uwe Kleine-König
2017-02-17 20:18                     ` Ville Syrjälä
2017-02-20  9:04                   ` Maarten Lankhorst
2017-02-20 13:38                     ` Ville Syrjälä
2017-02-20 14:30                       ` Maarten Lankhorst
2017-02-24 13:11                         ` Ville Syrjälä
2017-02-25 15:31                           ` Maarten Lankhorst
2017-03-02 14:58                             ` Ville Syrjälä
2017-03-21 13:42                               ` Ander Conselvan De Oliveira
2017-03-21 14:43                                 ` Ville Syrjälä
2017-01-31  9:25 ` ✗ Fi.CI.BAT: warning for drm/i915: reduce cursor size for GEN5 hardware Patchwork
2017-02-17 17:52 ` ✓ Fi.CI.BAT: success for drm/i915: reduce cursor size for GEN5 hardware (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79c23893-7a84-6bc6-140c-7db4d599aa48@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=martin.peres@free.fr \
    --cc=uwe@kleine-koenig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.