From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 611E6C04AAF for ; Mon, 20 May 2019 08:12:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F4BD2081C for ; Mon, 20 May 2019 08:12:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730975AbfETIMJ (ORCPT ); Mon, 20 May 2019 04:12:09 -0400 Received: from regular1.263xmail.com ([211.150.70.199]:60552 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728551AbfETIMJ (ORCPT ); Mon, 20 May 2019 04:12:09 -0400 X-Greylist: delayed 466 seconds by postgrey-1.27 at vger.kernel.org; Mon, 20 May 2019 04:12:07 EDT Received: from wxt?rock-chips.com (unknown [192.168.167.161]) by regular1.263xmail.com (Postfix) with ESMTP id 1F4D63EE; Mon, 20 May 2019 16:04:14 +0800 (CST) X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from [172.16.21.194] (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P32757T140039436609280S1558339450334725_; Mon, 20 May 2019 16:04:11 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: wxt@rock-chips.com X-SENDER: wxt@rock-chips.com X-LOGIN-NAME: wxt@rock-chips.com X-FST-TO: hjc@rock-chips.com X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] phy: rockchip-dp: Avoid power leak by leaving the PHY power on To: Douglas Anderson , Kishon Vijay Abraham I , Heiko Stuebner Cc: hl@rock-chips.com, linux-rockchip@lists.infradead.org, dbasehore@chromium.org, mka@chromium.org, ryandcase@chromium.org, groeck@chromium.org, Elaine Zhang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "nickey.yang (nickey.yang@rock-chips.com)" , wzz , Huang Jiachai References: <20190507234857.81414-1-dianders@chromium.org> From: Caesar Wang Message-ID: <79ca5499-6b7d-fe55-2030-283f5cfb1d27@rock-chips.com> Date: Mon, 20 May 2019 16:04:11 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190507234857.81414-1-dianders@chromium.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Doug, For now,  nobody of rockchip is responsible for this driver. Cc: Nickey, Zain, Hjc On 5/8/19 7:48 AM, Douglas Anderson wrote: > While testing a newer kernel on rk3288-based Chromebooks I found that > the power draw in suspend was higher on newer kernels compared to the > downstream Chrome OS 3.14 kernel. Specifically the power of an > rk3288-veyron-jerry board that I tested (as measured by the smart > battery) was ~16 mA on Chrome OS 3.14 and ~21 mA on a newer kernel. > > I tracked the regression down to the fact that the "DP PHY" driver > didn't exist in our downstream 3.14. We relied on the eDP driver to > turn on the clock and relied on the fact that the power for the PHY > was default turned on. > > Specifically the thing that caused the power regression was turning > the eDP PHY _off_. Presumably there is some sort of power leak in the > system and when we turn the PHY off something is leaching power from > something else and causing excessive power draw. > > Doing a search through device trees shows that this PHY is only ever > used on rk3288. Presumably this power leak is present on all > rk3288-SoCs running upstream Linux so let's just whack the driver to > make sure we never turn off power. We'll still leave the parts that > turn _on_ the power and grab the clock, though. > > NOTES: > A) If someone can identify what this power leak is and fix it in some > other way we can revert this patch. > B) If someone can show that their particular board doesn't have this > power leak (maybe they have rails hooked up differently?) we can > perhaps add a device tree property indicating that for some boards > it's OK to turn this rail off. I don't want to add this property > until I know of a board that needs it. > > Fixes: fd968973de95 ("phy: Add driver for rockchip Display Port PHY") > Signed-off-by: Douglas Anderson Reviewed-by: Caesar Wang > --- > As far as I know Yakir (the original author) is no longer at Rockchip. > I've added a few other Rockchip people and hopefully one of them can > help direct even if they're not directly responsible. > > drivers/phy/rockchip/phy-rockchip-dp.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/phy/rockchip/phy-rockchip-dp.c b/drivers/phy/rockchip/phy-rockchip-dp.c > index 8b267a746576..10bbcd69d6f5 100644 > --- a/drivers/phy/rockchip/phy-rockchip-dp.c > +++ b/drivers/phy/rockchip/phy-rockchip-dp.c > @@ -35,7 +35,7 @@ struct rockchip_dp_phy { > static int rockchip_set_phy_state(struct phy *phy, bool enable) > { > struct rockchip_dp_phy *dp = phy_get_drvdata(phy); > - int ret; > + int ret = 0; > > if (enable) { > ret = regmap_write(dp->grf, GRF_SOC_CON12, > @@ -50,9 +50,12 @@ static int rockchip_set_phy_state(struct phy *phy, bool enable) > } else { > clk_disable_unprepare(dp->phy_24m); > > - ret = regmap_write(dp->grf, GRF_SOC_CON12, > - GRF_EDP_PHY_SIDDQ_HIWORD_MASK | > - GRF_EDP_PHY_SIDDQ_OFF); > + /* > + * Intentionally don't turn SIDDQ off when disabling > + * the PHY. There is a power leak on rk3288 and > + * suspend power _increases_ by 5 mA if you turn this > + * off. > + */ As described by TRM, The “GRF_EDP_PHY_SIDDQ_OFF” that all circuits are power down, all IO are high-Z. That should make sure the PD_VIO[0] was disabled first, no active. But the rk3288 can't turn pd_vio off at the moment. [0] PD_VIO Which clock are device clocks:              *    clocks        devices              *    *_IEP        IEP:Image Enhancement Processor              *    *_ISP        ISP:Image Signal Processing              *    *_VIP        VIP:Video Input Processor              *    *_VOP*        VOP:Visual Output Processor              *    *_RGA        RGA              *    *_EDP*        EDP              *    *_LVDS_*    LVDS              *    *_HDMI        HDMI              *    *_MIPI_*    MIPI Thanks, -Caesar > } > > return ret; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Caesar Wang Subject: Re: [PATCH] phy: rockchip-dp: Avoid power leak by leaving the PHY power on Date: Mon, 20 May 2019 16:04:11 +0800 Message-ID: <79ca5499-6b7d-fe55-2030-283f5cfb1d27@rock-chips.com> References: <20190507234857.81414-1-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190507234857.81414-1-dianders@chromium.org> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Douglas Anderson , Kishon Vijay Abraham I , Heiko Stuebner Cc: Elaine Zhang , hl@rock-chips.com, dbasehore@chromium.org, linux-kernel@vger.kernel.org, Huang Jiachai , linux-rockchip@lists.infradead.org, "nickey.yang (nickey.yang@rock-chips.com)" , mka@chromium.org, ryandcase@chromium.org, groeck@chromium.org, wzz , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgRG91ZywKCkZvciBub3cswqAgbm9ib2R5IG9mIHJvY2tjaGlwIGlzIHJlc3BvbnNpYmxlIGZv ciB0aGlzIGRyaXZlci4KQ2M6IE5pY2tleSwgWmFpbiwgSGpjCgoKT24gNS84LzE5IDc6NDggQU0s IERvdWdsYXMgQW5kZXJzb24gd3JvdGU6Cj4gV2hpbGUgdGVzdGluZyBhIG5ld2VyIGtlcm5lbCBv biByazMyODgtYmFzZWQgQ2hyb21lYm9va3MgSSBmb3VuZCB0aGF0Cj4gdGhlIHBvd2VyIGRyYXcg aW4gc3VzcGVuZCB3YXMgaGlnaGVyIG9uIG5ld2VyIGtlcm5lbHMgY29tcGFyZWQgdG8gdGhlCj4g ZG93bnN0cmVhbSBDaHJvbWUgT1MgMy4xNCBrZXJuZWwuICBTcGVjaWZpY2FsbHkgdGhlIHBvd2Vy IG9mIGFuCj4gcmszMjg4LXZleXJvbi1qZXJyeSBib2FyZCB0aGF0IEkgdGVzdGVkIChhcyBtZWFz dXJlZCBieSB0aGUgc21hcnQKPiBiYXR0ZXJ5KSB3YXMgfjE2IG1BIG9uIENocm9tZSBPUyAzLjE0 IGFuZCB+MjEgbUEgb24gYSBuZXdlciBrZXJuZWwuCj4KPiBJIHRyYWNrZWQgdGhlIHJlZ3Jlc3Np b24gZG93biB0byB0aGUgZmFjdCB0aGF0IHRoZSAiRFAgUEhZIiBkcml2ZXIKPiBkaWRuJ3QgZXhp c3QgaW4gb3VyIGRvd25zdHJlYW0gMy4xNC4gIFdlIHJlbGllZCBvbiB0aGUgZURQIGRyaXZlciB0 bwo+IHR1cm4gb24gdGhlIGNsb2NrIGFuZCByZWxpZWQgb24gdGhlIGZhY3QgdGhhdCB0aGUgcG93 ZXIgZm9yIHRoZSBQSFkKPiB3YXMgZGVmYXVsdCB0dXJuZWQgb24uCj4KPiBTcGVjaWZpY2FsbHkg dGhlIHRoaW5nIHRoYXQgY2F1c2VkIHRoZSBwb3dlciByZWdyZXNzaW9uIHdhcyB0dXJuaW5nCj4g dGhlIGVEUCBQSFkgX29mZl8uICBQcmVzdW1hYmx5IHRoZXJlIGlzIHNvbWUgc29ydCBvZiBwb3dl ciBsZWFrIGluIHRoZQo+IHN5c3RlbSBhbmQgd2hlbiB3ZSB0dXJuIHRoZSBQSFkgb2ZmIHNvbWV0 aGluZyBpcyBsZWFjaGluZyBwb3dlciBmcm9tCj4gc29tZXRoaW5nIGVsc2UgYW5kIGNhdXNpbmcg ZXhjZXNzaXZlIHBvd2VyIGRyYXcuCj4KPiBEb2luZyBhIHNlYXJjaCB0aHJvdWdoIGRldmljZSB0 cmVlcyBzaG93cyB0aGF0IHRoaXMgUEhZIGlzIG9ubHkgZXZlcgo+IHVzZWQgb24gcmszMjg4LiAg UHJlc3VtYWJseSB0aGlzIHBvd2VyIGxlYWsgaXMgcHJlc2VudCBvbiBhbGwKPiByazMyODgtU29D cyBydW5uaW5nIHVwc3RyZWFtIExpbnV4IHNvIGxldCdzIGp1c3Qgd2hhY2sgdGhlIGRyaXZlciB0 bwo+IG1ha2Ugc3VyZSB3ZSBuZXZlciB0dXJuIG9mZiBwb3dlci4gIFdlJ2xsIHN0aWxsIGxlYXZl IHRoZSBwYXJ0cyB0aGF0Cj4gdHVybiBfb25fIHRoZSBwb3dlciBhbmQgZ3JhYiB0aGUgY2xvY2ss IHRob3VnaC4KPgo+IE5PVEVTOgo+IEEpIElmIHNvbWVvbmUgY2FuIGlkZW50aWZ5IHdoYXQgdGhp cyBwb3dlciBsZWFrIGlzIGFuZCBmaXggaXQgaW4gc29tZQo+ICAgICBvdGhlciB3YXkgd2UgY2Fu IHJldmVydCB0aGlzIHBhdGNoLgo+IEIpIElmIHNvbWVvbmUgY2FuIHNob3cgdGhhdCB0aGVpciBw YXJ0aWN1bGFyIGJvYXJkIGRvZXNuJ3QgaGF2ZSB0aGlzCj4gICAgIHBvd2VyIGxlYWsgKG1heWJl IHRoZXkgaGF2ZSByYWlscyBob29rZWQgdXAgZGlmZmVyZW50bHk/KSB3ZSBjYW4KPiAgICAgcGVy aGFwcyBhZGQgYSBkZXZpY2UgdHJlZSBwcm9wZXJ0eSBpbmRpY2F0aW5nIHRoYXQgZm9yIHNvbWUg Ym9hcmRzCj4gICAgIGl0J3MgT0sgdG8gdHVybiB0aGlzIHJhaWwgb2ZmLiAgSSBkb24ndCB3YW50 IHRvIGFkZCB0aGlzIHByb3BlcnR5Cj4gICAgIHVudGlsIEkga25vdyBvZiBhIGJvYXJkIHRoYXQg bmVlZHMgaXQuCj4KPiBGaXhlczogZmQ5Njg5NzNkZTk1ICgicGh5OiBBZGQgZHJpdmVyIGZvciBy b2NrY2hpcCBEaXNwbGF5IFBvcnQgUEhZIikKPiBTaWduZWQtb2ZmLWJ5OiBEb3VnbGFzIEFuZGVy c29uIDxkaWFuZGVyc0BjaHJvbWl1bS5vcmc+CgoKUmV2aWV3ZWQtYnk6IENhZXNhciBXYW5nIDx3 eHRAcm9jay1jaGlwcy5jb20+Cgo+IC0tLQo+IEFzIGZhciBhcyBJIGtub3cgWWFraXIgKHRoZSBv cmlnaW5hbCBhdXRob3IpIGlzIG5vIGxvbmdlciBhdCBSb2NrY2hpcC4KPiBJJ3ZlIGFkZGVkIGEg ZmV3IG90aGVyIFJvY2tjaGlwIHBlb3BsZSBhbmQgaG9wZWZ1bGx5IG9uZSBvZiB0aGVtIGNhbgo+ IGhlbHAgZGlyZWN0IGV2ZW4gaWYgdGhleSdyZSBub3QgZGlyZWN0bHkgcmVzcG9uc2libGUuCj4K PiAgIGRyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC1kcC5jIHwgMTEgKysrKysrKy0t LS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLWRwLmMgYi9k cml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtZHAuYwo+IGluZGV4IDhiMjY3YTc0NjU3 Ni4uMTBiYmNkNjlkNmY1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1y b2NrY2hpcC1kcC5jCj4gKysrIGIvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLWRw LmMKPiBAQCAtMzUsNyArMzUsNyBAQCBzdHJ1Y3Qgcm9ja2NoaXBfZHBfcGh5IHsKPiAgIHN0YXRp YyBpbnQgcm9ja2NoaXBfc2V0X3BoeV9zdGF0ZShzdHJ1Y3QgcGh5ICpwaHksIGJvb2wgZW5hYmxl KQo+ICAgewo+ICAgCXN0cnVjdCByb2NrY2hpcF9kcF9waHkgKmRwID0gcGh5X2dldF9kcnZkYXRh KHBoeSk7Cj4gLQlpbnQgcmV0Owo+ICsJaW50IHJldCA9IDA7Cj4gICAKPiAgIAlpZiAoZW5hYmxl KSB7Cj4gICAJCXJldCA9IHJlZ21hcF93cml0ZShkcC0+Z3JmLCBHUkZfU09DX0NPTjEyLAo+IEBA IC01MCw5ICs1MCwxMiBAQCBzdGF0aWMgaW50IHJvY2tjaGlwX3NldF9waHlfc3RhdGUoc3RydWN0 IHBoeSAqcGh5LCBib29sIGVuYWJsZSkKPiAgIAl9IGVsc2Ugewo+ICAgCQljbGtfZGlzYWJsZV91 bnByZXBhcmUoZHAtPnBoeV8yNG0pOwo+ICAgCj4gLQkJcmV0ID0gcmVnbWFwX3dyaXRlKGRwLT5n cmYsIEdSRl9TT0NfQ09OMTIsCj4gLQkJCQkgICBHUkZfRURQX1BIWV9TSUREUV9ISVdPUkRfTUFT SyB8Cj4gLQkJCQkgICBHUkZfRURQX1BIWV9TSUREUV9PRkYpOwo+ICsJCS8qCj4gKwkJICogSW50 ZW50aW9uYWxseSBkb24ndCB0dXJuIFNJRERRIG9mZiB3aGVuIGRpc2FibGluZwo+ICsJCSAqIHRo ZSBQSFkuICBUaGVyZSBpcyBhIHBvd2VyIGxlYWsgb24gcmszMjg4IGFuZAo+ICsJCSAqIHN1c3Bl bmQgcG93ZXIgX2luY3JlYXNlc18gYnkgNSBtQSBpZiB5b3UgdHVybiB0aGlzCj4gKwkJICogb2Zm Lgo+ICsJCSAqLwoKCkFzIGRlc2NyaWJlZCBieSBUUk0sIFRoZSDigJxHUkZfRURQX1BIWV9TSURE UV9PRkbigJ0gdGhhdCBhbGwgY2lyY3VpdHMgYXJlIApwb3dlciBkb3duLCBhbGwKSU8gYXJlIGhp Z2gtWi4gVGhhdCBzaG91bGQgbWFrZSBzdXJlIHRoZSBQRF9WSU9bMF0gd2FzIGRpc2FibGVkIGZp cnN0LCAKbm8gYWN0aXZlLgpCdXQgdGhlIHJrMzI4OCBjYW4ndCB0dXJuIHBkX3ZpbyBvZmYgYXQg dGhlIG1vbWVudC4KClswXQpQRF9WSU8gV2hpY2ggY2xvY2sgYXJlIGRldmljZSBjbG9ja3M6CiDC oMKgwqAgwqDCoMKgIMKgwqDCoCDCoCrCoMKgwqAgY2xvY2tzwqDCoMKgIMKgwqDCoCBkZXZpY2Vz CiDCoMKgwqAgwqDCoMKgIMKgwqDCoCDCoCrCoMKgwqAgKl9JRVDCoMKgwqAgwqDCoMKgIElFUDpJ bWFnZSBFbmhhbmNlbWVudCBQcm9jZXNzb3IKIMKgwqDCoCDCoMKgwqAgwqDCoMKgIMKgKsKgwqDC oCAqX0lTUMKgwqDCoCDCoMKgwqAgSVNQOkltYWdlIFNpZ25hbCBQcm9jZXNzaW5nCiDCoMKgwqAg wqDCoMKgIMKgwqDCoCDCoCrCoMKgwqAgKl9WSVDCoMKgwqAgwqDCoMKgIFZJUDpWaWRlbyBJbnB1 dCBQcm9jZXNzb3IKIMKgwqDCoCDCoMKgwqAgwqDCoMKgIMKgKsKgwqDCoCAqX1ZPUCrCoMKgwqAg wqDCoMKgIFZPUDpWaXN1YWwgT3V0cHV0IFByb2Nlc3NvcgogwqDCoMKgIMKgwqDCoCDCoMKgwqAg wqAqwqDCoMKgICpfUkdBwqDCoMKgIMKgwqDCoCBSR0EKIMKgwqDCoCDCoMKgwqAgwqDCoMKgIMKg KsKgwqDCoCAqX0VEUCrCoMKgwqAgwqDCoMKgIEVEUAogwqDCoMKgIMKgwqDCoCDCoMKgwqAgwqAq wqDCoMKgICpfTFZEU18qwqDCoMKgIExWRFMKIMKgwqDCoCDCoMKgwqAgwqDCoMKgIMKgKsKgwqDC oCAqX0hETUnCoMKgwqAgwqDCoMKgIEhETUkKIMKgwqDCoCDCoMKgwqAgwqDCoMKgIMKgKsKgwqDC oCAqX01JUElfKsKgwqDCoCBNSVBJCgoKVGhhbmtzLAotQ2Flc2FyCgoKPiAgIAl9Cj4gICAKPiAg IAlyZXR1cm4gcmV0OwoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 763B3C04AAF for ; Mon, 20 May 2019 08:04:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C54220859 for ; Mon, 20 May 2019 08:04:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EkNTTDbl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C54220859 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rock-chips.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hlLvnQr3KZuse00BNeXJoyxvkij+/CEe0qab7qSUy10=; b=EkNTTDblneOVM8o0RTvIJ5Ld3 jYW3UEppNNM/f2VD5F9mR7/mcDrWZVpnGe/CN5ST6eDTDBt2EyL5J6lv7HS7EM8zQ3sfdnNTsUrmu D/+1uwkcH+r2ngcSfNbVe+yth69lv2JmEnVWVu203AAN2qwKsxhvITJk/cMPIKN17rLw7ehBTyRAi rV8pP46gj8rJt7DLF3EcF526vP4Row/jWTVef/bXv4HWfczIFFCnDGue956BmDmqg5bNwR8YFCMPj vy6I5Yw++ethoZdxUPiIVky7/3dJTY3TOCXR+96zaLz2Q9mOXsuiinpPbWLNPUBnacyVsop+yiETt lmjWH2Emw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSdHY-00089m-8k; Mon, 20 May 2019 08:04:28 +0000 Received: from regular1.263xmail.com ([211.150.70.199]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSdHS-0007zE-Qu; Mon, 20 May 2019 08:04:25 +0000 Received: from wxt?rock-chips.com (unknown [192.168.167.161]) by regular1.263xmail.com (Postfix) with ESMTP id 1F4D63EE; Mon, 20 May 2019 16:04:14 +0800 (CST) X-263anti-spam: KSV:0;BIG:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ADDR-CHECKED4: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ANTISPAM-LEVEL: 2 Received: from [172.16.21.194] (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P32757T140039436609280S1558339450334725_; Mon, 20 May 2019 16:04:11 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: wxt@rock-chips.com X-SENDER: wxt@rock-chips.com X-LOGIN-NAME: wxt@rock-chips.com X-FST-TO: hjc@rock-chips.com X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] phy: rockchip-dp: Avoid power leak by leaving the PHY power on To: Douglas Anderson , Kishon Vijay Abraham I , Heiko Stuebner References: <20190507234857.81414-1-dianders@chromium.org> From: Caesar Wang Message-ID: <79ca5499-6b7d-fe55-2030-283f5cfb1d27@rock-chips.com> Date: Mon, 20 May 2019 16:04:11 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190507234857.81414-1-dianders@chromium.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190520_010423_182291_1D391298 X-CRM114-Status: GOOD ( 25.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Elaine Zhang , hl@rock-chips.com, dbasehore@chromium.org, linux-kernel@vger.kernel.org, Huang Jiachai , linux-rockchip@lists.infradead.org, "nickey.yang \(nickey.yang@rock-chips.com\)" , mka@chromium.org, ryandcase@chromium.org, groeck@chromium.org, wzz , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgRG91ZywKCkZvciBub3cswqAgbm9ib2R5IG9mIHJvY2tjaGlwIGlzIHJlc3BvbnNpYmxlIGZv ciB0aGlzIGRyaXZlci4KQ2M6IE5pY2tleSwgWmFpbiwgSGpjCgoKT24gNS84LzE5IDc6NDggQU0s IERvdWdsYXMgQW5kZXJzb24gd3JvdGU6Cj4gV2hpbGUgdGVzdGluZyBhIG5ld2VyIGtlcm5lbCBv biByazMyODgtYmFzZWQgQ2hyb21lYm9va3MgSSBmb3VuZCB0aGF0Cj4gdGhlIHBvd2VyIGRyYXcg aW4gc3VzcGVuZCB3YXMgaGlnaGVyIG9uIG5ld2VyIGtlcm5lbHMgY29tcGFyZWQgdG8gdGhlCj4g ZG93bnN0cmVhbSBDaHJvbWUgT1MgMy4xNCBrZXJuZWwuICBTcGVjaWZpY2FsbHkgdGhlIHBvd2Vy IG9mIGFuCj4gcmszMjg4LXZleXJvbi1qZXJyeSBib2FyZCB0aGF0IEkgdGVzdGVkIChhcyBtZWFz dXJlZCBieSB0aGUgc21hcnQKPiBiYXR0ZXJ5KSB3YXMgfjE2IG1BIG9uIENocm9tZSBPUyAzLjE0 IGFuZCB+MjEgbUEgb24gYSBuZXdlciBrZXJuZWwuCj4KPiBJIHRyYWNrZWQgdGhlIHJlZ3Jlc3Np b24gZG93biB0byB0aGUgZmFjdCB0aGF0IHRoZSAiRFAgUEhZIiBkcml2ZXIKPiBkaWRuJ3QgZXhp c3QgaW4gb3VyIGRvd25zdHJlYW0gMy4xNC4gIFdlIHJlbGllZCBvbiB0aGUgZURQIGRyaXZlciB0 bwo+IHR1cm4gb24gdGhlIGNsb2NrIGFuZCByZWxpZWQgb24gdGhlIGZhY3QgdGhhdCB0aGUgcG93 ZXIgZm9yIHRoZSBQSFkKPiB3YXMgZGVmYXVsdCB0dXJuZWQgb24uCj4KPiBTcGVjaWZpY2FsbHkg dGhlIHRoaW5nIHRoYXQgY2F1c2VkIHRoZSBwb3dlciByZWdyZXNzaW9uIHdhcyB0dXJuaW5nCj4g dGhlIGVEUCBQSFkgX29mZl8uICBQcmVzdW1hYmx5IHRoZXJlIGlzIHNvbWUgc29ydCBvZiBwb3dl ciBsZWFrIGluIHRoZQo+IHN5c3RlbSBhbmQgd2hlbiB3ZSB0dXJuIHRoZSBQSFkgb2ZmIHNvbWV0 aGluZyBpcyBsZWFjaGluZyBwb3dlciBmcm9tCj4gc29tZXRoaW5nIGVsc2UgYW5kIGNhdXNpbmcg ZXhjZXNzaXZlIHBvd2VyIGRyYXcuCj4KPiBEb2luZyBhIHNlYXJjaCB0aHJvdWdoIGRldmljZSB0 cmVlcyBzaG93cyB0aGF0IHRoaXMgUEhZIGlzIG9ubHkgZXZlcgo+IHVzZWQgb24gcmszMjg4LiAg UHJlc3VtYWJseSB0aGlzIHBvd2VyIGxlYWsgaXMgcHJlc2VudCBvbiBhbGwKPiByazMyODgtU29D cyBydW5uaW5nIHVwc3RyZWFtIExpbnV4IHNvIGxldCdzIGp1c3Qgd2hhY2sgdGhlIGRyaXZlciB0 bwo+IG1ha2Ugc3VyZSB3ZSBuZXZlciB0dXJuIG9mZiBwb3dlci4gIFdlJ2xsIHN0aWxsIGxlYXZl IHRoZSBwYXJ0cyB0aGF0Cj4gdHVybiBfb25fIHRoZSBwb3dlciBhbmQgZ3JhYiB0aGUgY2xvY2ss IHRob3VnaC4KPgo+IE5PVEVTOgo+IEEpIElmIHNvbWVvbmUgY2FuIGlkZW50aWZ5IHdoYXQgdGhp cyBwb3dlciBsZWFrIGlzIGFuZCBmaXggaXQgaW4gc29tZQo+ICAgICBvdGhlciB3YXkgd2UgY2Fu IHJldmVydCB0aGlzIHBhdGNoLgo+IEIpIElmIHNvbWVvbmUgY2FuIHNob3cgdGhhdCB0aGVpciBw YXJ0aWN1bGFyIGJvYXJkIGRvZXNuJ3QgaGF2ZSB0aGlzCj4gICAgIHBvd2VyIGxlYWsgKG1heWJl IHRoZXkgaGF2ZSByYWlscyBob29rZWQgdXAgZGlmZmVyZW50bHk/KSB3ZSBjYW4KPiAgICAgcGVy aGFwcyBhZGQgYSBkZXZpY2UgdHJlZSBwcm9wZXJ0eSBpbmRpY2F0aW5nIHRoYXQgZm9yIHNvbWUg Ym9hcmRzCj4gICAgIGl0J3MgT0sgdG8gdHVybiB0aGlzIHJhaWwgb2ZmLiAgSSBkb24ndCB3YW50 IHRvIGFkZCB0aGlzIHByb3BlcnR5Cj4gICAgIHVudGlsIEkga25vdyBvZiBhIGJvYXJkIHRoYXQg bmVlZHMgaXQuCj4KPiBGaXhlczogZmQ5Njg5NzNkZTk1ICgicGh5OiBBZGQgZHJpdmVyIGZvciBy b2NrY2hpcCBEaXNwbGF5IFBvcnQgUEhZIikKPiBTaWduZWQtb2ZmLWJ5OiBEb3VnbGFzIEFuZGVy c29uIDxkaWFuZGVyc0BjaHJvbWl1bS5vcmc+CgoKUmV2aWV3ZWQtYnk6IENhZXNhciBXYW5nIDx3 eHRAcm9jay1jaGlwcy5jb20+Cgo+IC0tLQo+IEFzIGZhciBhcyBJIGtub3cgWWFraXIgKHRoZSBv cmlnaW5hbCBhdXRob3IpIGlzIG5vIGxvbmdlciBhdCBSb2NrY2hpcC4KPiBJJ3ZlIGFkZGVkIGEg ZmV3IG90aGVyIFJvY2tjaGlwIHBlb3BsZSBhbmQgaG9wZWZ1bGx5IG9uZSBvZiB0aGVtIGNhbgo+ IGhlbHAgZGlyZWN0IGV2ZW4gaWYgdGhleSdyZSBub3QgZGlyZWN0bHkgcmVzcG9uc2libGUuCj4K PiAgIGRyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC1kcC5jIHwgMTEgKysrKysrKy0t LS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLWRwLmMgYi9k cml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtZHAuYwo+IGluZGV4IDhiMjY3YTc0NjU3 Ni4uMTBiYmNkNjlkNmY1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1y b2NrY2hpcC1kcC5jCj4gKysrIGIvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLWRw LmMKPiBAQCAtMzUsNyArMzUsNyBAQCBzdHJ1Y3Qgcm9ja2NoaXBfZHBfcGh5IHsKPiAgIHN0YXRp YyBpbnQgcm9ja2NoaXBfc2V0X3BoeV9zdGF0ZShzdHJ1Y3QgcGh5ICpwaHksIGJvb2wgZW5hYmxl KQo+ICAgewo+ICAgCXN0cnVjdCByb2NrY2hpcF9kcF9waHkgKmRwID0gcGh5X2dldF9kcnZkYXRh KHBoeSk7Cj4gLQlpbnQgcmV0Owo+ICsJaW50IHJldCA9IDA7Cj4gICAKPiAgIAlpZiAoZW5hYmxl KSB7Cj4gICAJCXJldCA9IHJlZ21hcF93cml0ZShkcC0+Z3JmLCBHUkZfU09DX0NPTjEyLAo+IEBA IC01MCw5ICs1MCwxMiBAQCBzdGF0aWMgaW50IHJvY2tjaGlwX3NldF9waHlfc3RhdGUoc3RydWN0 IHBoeSAqcGh5LCBib29sIGVuYWJsZSkKPiAgIAl9IGVsc2Ugewo+ICAgCQljbGtfZGlzYWJsZV91 bnByZXBhcmUoZHAtPnBoeV8yNG0pOwo+ICAgCj4gLQkJcmV0ID0gcmVnbWFwX3dyaXRlKGRwLT5n cmYsIEdSRl9TT0NfQ09OMTIsCj4gLQkJCQkgICBHUkZfRURQX1BIWV9TSUREUV9ISVdPUkRfTUFT SyB8Cj4gLQkJCQkgICBHUkZfRURQX1BIWV9TSUREUV9PRkYpOwo+ICsJCS8qCj4gKwkJICogSW50 ZW50aW9uYWxseSBkb24ndCB0dXJuIFNJRERRIG9mZiB3aGVuIGRpc2FibGluZwo+ICsJCSAqIHRo ZSBQSFkuICBUaGVyZSBpcyBhIHBvd2VyIGxlYWsgb24gcmszMjg4IGFuZAo+ICsJCSAqIHN1c3Bl bmQgcG93ZXIgX2luY3JlYXNlc18gYnkgNSBtQSBpZiB5b3UgdHVybiB0aGlzCj4gKwkJICogb2Zm Lgo+ICsJCSAqLwoKCkFzIGRlc2NyaWJlZCBieSBUUk0sIFRoZSDigJxHUkZfRURQX1BIWV9TSURE UV9PRkbigJ0gdGhhdCBhbGwgY2lyY3VpdHMgYXJlIApwb3dlciBkb3duLCBhbGwKSU8gYXJlIGhp Z2gtWi4gVGhhdCBzaG91bGQgbWFrZSBzdXJlIHRoZSBQRF9WSU9bMF0gd2FzIGRpc2FibGVkIGZp cnN0LCAKbm8gYWN0aXZlLgpCdXQgdGhlIHJrMzI4OCBjYW4ndCB0dXJuIHBkX3ZpbyBvZmYgYXQg dGhlIG1vbWVudC4KClswXQpQRF9WSU8gV2hpY2ggY2xvY2sgYXJlIGRldmljZSBjbG9ja3M6CiDC oMKgwqAgwqDCoMKgIMKgwqDCoCDCoCrCoMKgwqAgY2xvY2tzwqDCoMKgIMKgwqDCoCBkZXZpY2Vz CiDCoMKgwqAgwqDCoMKgIMKgwqDCoCDCoCrCoMKgwqAgKl9JRVDCoMKgwqAgwqDCoMKgIElFUDpJ bWFnZSBFbmhhbmNlbWVudCBQcm9jZXNzb3IKIMKgwqDCoCDCoMKgwqAgwqDCoMKgIMKgKsKgwqDC oCAqX0lTUMKgwqDCoCDCoMKgwqAgSVNQOkltYWdlIFNpZ25hbCBQcm9jZXNzaW5nCiDCoMKgwqAg wqDCoMKgIMKgwqDCoCDCoCrCoMKgwqAgKl9WSVDCoMKgwqAgwqDCoMKgIFZJUDpWaWRlbyBJbnB1 dCBQcm9jZXNzb3IKIMKgwqDCoCDCoMKgwqAgwqDCoMKgIMKgKsKgwqDCoCAqX1ZPUCrCoMKgwqAg wqDCoMKgIFZPUDpWaXN1YWwgT3V0cHV0IFByb2Nlc3NvcgogwqDCoMKgIMKgwqDCoCDCoMKgwqAg wqAqwqDCoMKgICpfUkdBwqDCoMKgIMKgwqDCoCBSR0EKIMKgwqDCoCDCoMKgwqAgwqDCoMKgIMKg KsKgwqDCoCAqX0VEUCrCoMKgwqAgwqDCoMKgIEVEUAogwqDCoMKgIMKgwqDCoCDCoMKgwqAgwqAq wqDCoMKgICpfTFZEU18qwqDCoMKgIExWRFMKIMKgwqDCoCDCoMKgwqAgwqDCoMKgIMKgKsKgwqDC oCAqX0hETUnCoMKgwqAgwqDCoMKgIEhETUkKIMKgwqDCoCDCoMKgwqAgwqDCoMKgIMKgKsKgwqDC oCAqX01JUElfKsKgwqDCoCBNSVBJCgoKVGhhbmtzLAotQ2Flc2FyCgoKPiAgIAl9Cj4gICAKPiAg IAlyZXR1cm4gcmV0OwoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==