From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Aubrey Li <aubrey.li@intel.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Aubrey Li <aubrey.li@linux.intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] ACPI/PRM: Find PRMT table before parse it
Date: Wed, 8 Sep 2021 12:06:54 +0200 [thread overview]
Message-ID: <79d42839-729e-559b-beda-8f1cdbc1e113@molgen.mpg.de> (raw)
In-Reply-To: <1631066984-63501-1-git-send-email-aubrey.li@intel.com>
Dear Aubrey,
Am 08.09.21 um 04:09 schrieb Aubrey Li:
> Find and verify PRMT table before parse it, this eliminates a
> warning on machines without PRMT table.
>
> [ 7.197173] ACPI: PRMT not present
Please also add:
Fixes: cefc7ca462 ("ACPI: PRM: implement OperationRegion handler for the
PlatformRtMechanism subtype")
> Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com>
> Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
> drivers/acpi/prmt.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/prmt.c b/drivers/acpi/prmt.c
> index 1f6007a..89c22bc 100644
> --- a/drivers/acpi/prmt.c
> +++ b/drivers/acpi/prmt.c
> @@ -288,10 +288,18 @@ static acpi_status acpi_platformrt_space_handler(u32 function,
>
> void __init init_prmt(void)
> {
> + struct acpi_table_header *tbl;
> acpi_status status;
> - int mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) +
> + int mc;
> +
> + status = acpi_get_table(ACPI_SIG_PRMT, 0, &tbl);
> + if (ACPI_FAILURE(status))
> + return;
> +
> + mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) +
> sizeof (struct acpi_table_prmt_header),
> 0, acpi_parse_prmt, 0);
> + acpi_put_table(tbl);
> /*
> * Return immediately if PRMT table is not present or no PRM module found.
> */
Thank you very much for preparing the patch.
Kind regards,
Paul
prev parent reply other threads:[~2021-09-08 10:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 2:09 [PATCH] ACPI/PRM: Find PRMT table before parse it Aubrey Li
2021-09-08 10:06 ` Paul Menzel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79d42839-729e-559b-beda-8f1cdbc1e113@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=aubrey.li@intel.com \
--cc=aubrey.li@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.