From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F356C74A5B for ; Wed, 22 Mar 2023 20:54:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230250AbjCVUy4 (ORCPT ); Wed, 22 Mar 2023 16:54:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229670AbjCVUyy (ORCPT ); Wed, 22 Mar 2023 16:54:54 -0400 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 959701024F; Wed, 22 Mar 2023 13:54:52 -0700 (PDT) Received: from [192.168.1.103] (31.173.85.97) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.14; Wed, 22 Mar 2023 23:54:43 +0300 Subject: Re: [PATCH net-next] sh_eth: remove open coded netif_running() To: Wolfram Sang , CC: , Geert Uytterhoeven , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , References: <20230321065826.2044-1-wsa+renesas@sang-engineering.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <79d945a4-e105-4bc4-3e73-64971731660e@omp.ru> Date: Wed, 22 Mar 2023 23:54:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20230321065826.2044-1-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [31.173.85.97] X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.59, Database issued on: 03/22/2023 20:24:55 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 176220 [Mar 22 2023] X-KSE-AntiSpam-Info: Version: 5.9.59.0 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 507 507 08d345461d9bcca7095738422a5279ab257bb65a X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;31.173.85.97:7.1.2;127.0.0.199:7.1.2 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.85.97 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 03/22/2023 20:28:00 X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 3/22/2023 2:20:00 PM X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/21/23 9:58 AM, Wolfram Sang wrote: > It had a purpose back in the days, but today we have a handy helper. Well, the is_opened flag doesn't get set/cleared at the same time as __LINK_STATE_START. I'm not sure they are interchangeable... > Reported-by: Geert Uytterhoeven > Signed-off-by: Wolfram Sang > --- > > Based on 6.3-rc3 and tested on a Renesas Lager board (R-Car H2). > > drivers/net/ethernet/renesas/sh_eth.c | 6 +----- > drivers/net/ethernet/renesas/sh_eth.h | 1 - > 2 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c > index d8ec729825be..2d9787231099 100644 > --- a/drivers/net/ethernet/renesas/sh_eth.c > +++ b/drivers/net/ethernet/renesas/sh_eth.c > @@ -2441,8 +2441,6 @@ static int sh_eth_open(struct net_device *ndev) > > netif_start_queue(ndev); > > - mdp->is_opened = 1; > - __LINK_STATE_START gets set before the ndo_open() method call, so before the RPM call that enbales the clocks... > return ret; > > out_free_irq: > @@ -2565,7 +2563,7 @@ static struct net_device_stats *sh_eth_get_stats(struct net_device *ndev) > if (mdp->cd->no_tx_cntrs) > return &ndev->stats; > > - if (!mdp->is_opened) > + if (!netif_running(ndev)) > return &ndev->stats; I guess mdp->is_opened is checked here to avoid reading the counter regs when RPM hasn't been called yet to enable the clocks... [...] MBR, Sergey