From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0960C3A5A0 for ; Mon, 20 Apr 2020 14:01:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 69D4420857 for ; Mon, 20 Apr 2020 14:01:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HIpqY6r4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69D4420857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 159378E0006; Mon, 20 Apr 2020 10:01:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1095F8E0003; Mon, 20 Apr 2020 10:01:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEB878E0006; Mon, 20 Apr 2020 10:01:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id D4EFD8E0003 for ; Mon, 20 Apr 2020 10:01:20 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9D46C180ACF76 for ; Mon, 20 Apr 2020 14:01:20 +0000 (UTC) X-FDA: 76728395520.05.yard15_28bc5aade1a01 X-HE-Tag: yard15_28bc5aade1a01 X-Filterd-Recvd-Size: 7786 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Apr 2020 14:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587391279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CRCdhBzjtov7RvcoLcOwUA5fYrO6qOb+mWbouXaiL5k=; b=HIpqY6r43kH/FzbD5R1+A5UZ+BgK28llVnveeeHeX2tXhDuGWJahaxx8nE2jQ2HscVo06u eFPiqlfnbb0CMKbCBPkbuNjRXAIT4KcPj7Y/j+AmBsOhu9xafYxZricmItF0y6lnUPKnjm b3rTskufbbHZHwOURsKs14cZW4bJhQI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-177-smiE4b6TNaeIXVl5q6B31A-1; Mon, 20 Apr 2020 10:01:15 -0400 X-MC-Unique: smiE4b6TNaeIXVl5q6B31A-1 Received: by mail-wr1-f72.google.com with SMTP id r17so5742340wrg.19 for ; Mon, 20 Apr 2020 07:01:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CRCdhBzjtov7RvcoLcOwUA5fYrO6qOb+mWbouXaiL5k=; b=YlSuMuzNRSv19BhVn62cqwccM2eqtYvTN4LmSdLLBjT0rsRz3Wyo2l4L0FzJVE5ffT Gknit5+GeMUUv6mvQQKIG8g6yRAOzJqg1jyTzkLuXPb6YPo0wMWB/ynCWB9/ku5McrX4 lb22wrZcG+DKKf9++tRpwiSrByiJYVwUKVn5xepkKR80jnEUuD6vcwdVkIXrZx6jBMFu dbB+swYEjtBjQQH1M+ZyQywK1aBHqiwAeojpUfNNeKwsXxKpyWSfnQ6xvUDYrbcQ10Nz hBr2O0TmViz/VmBpMHHC0hehdQinfTX3gn1NF36KeM7IgtfPSoC06iGv4HaU7ja2u1ws bJPg== X-Gm-Message-State: AGi0PuZNnApQhSykqAvqFOy5v5qWNkxB4RLiKebCNK/VeKbxPq4b+Qca NKK5xe3ty40aQhIuXWrmge8tRFGRyrUGfesQaoNJxETRscjz+ZKUSSRQ0NGmkaGMF4jMBhlfhqm FDiOfhwvNN6k= X-Received: by 2002:adf:dd8f:: with SMTP id x15mr20314169wrl.201.1587391274302; Mon, 20 Apr 2020 07:01:14 -0700 (PDT) X-Google-Smtp-Source: APiQypKPnHC5LPyU8TDLr76kncprhTGb3bGNWjc4FM2HGpGEeoX6O6gIYtgQcBPwl5xg+T4TCSCY0A== X-Received: by 2002:adf:dd8f:: with SMTP id x15mr20314132wrl.201.1587391274111; Mon, 20 Apr 2020 07:01:14 -0700 (PDT) Received: from localhost.localdomain ([194.230.155.102]) by smtp.gmail.com with ESMTPSA id q17sm1265501wmj.45.2020.04.20.07.01.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2020 07:01:13 -0700 (PDT) From: Emanuele Giuseppe Esposito Subject: Re: [PATCH 0/8] Simplefs: group and simplify linux fs code To: Luis Chamberlain Cc: linux-nfs@vger.kernel.org, Paolo Bonzini , Jeremy Kerr , Arnd Bergmann , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Dennis Dalessandro , Mike Marciniszyn , Doug Ledford , Jason Gunthorpe , Frederic Barrat , Andrew Donnellan , Greg Kroah-Hartman , Robert Richter , "Manoj N. Kumar" , "Matthew R. Ochs" , Uma Krishnan , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , Alexander Viro , Ian Kent , Joel Becker , Christoph Hellwig , "Rafael J. Wysocki" , Matthew Garrett , Ard Biesheuvel , Miklos Szeredi , Mike Kravetz , Mark Fasheh , Joseph Qi , Alexey Dobriyan , Kees Cook , Iurii Zaikin , Anton Vorontsov , Colin Cross , Tony Luck , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Hugh Dickins , Andrew Morton , Trond Myklebust , Anna Schumaker , "J. Bruce Fields" , Chuck Lever , "David S. Miller" , Jakub Kicinski , James Morris , "Serge E. Hallyn" , John Johansen , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-fsdevel@vger.kernel.org, autofs@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org References: <20200414124304.4470-1-eesposit@redhat.com> <20200416065922.GS11244@42.do-not-panic.com> Message-ID: <79e3dd06-7cea-7798-42a2-596c185abd7b@redhat.com> Date: Mon, 20 Apr 2020 16:01:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200416065922.GS11244@42.do-not-panic.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/16/20 8:59 AM, Luis Chamberlain wrote: > On Tue, Apr 14, 2020 at 02:42:54PM +0200, Emanuele Giuseppe Esposito wrote: >> This series of patches introduce wrappers for functions, >> arguments simplification in functions calls and most importantly >> groups duplicated code in a single header, simplefs, to avoid redundancy >> in the linux fs, especially debugfs and tracefs. > > The general goal seems worthy, but here I don't see explained why hasn't > this gone through libfs, and what the intention was long term. For > instance, you added some other generalizations which you have found. It > was not clear that this was the goal here, to expand on these paths. > > What if common code on fs is found which are not part of debugfs and > tracefs, how does one decide if to move to libfs or simplefs? The idea of simplefs (that I will also explain better in the cover letter and commit messages) is that not only it groups common code, but also introduces a new struct simple_fs that simplifies parameter passing. This means all fs that use these functions and the struct should include linux/simplefs.h, while all common functions that take a simple_fs struct will be added in simplefs.c Thank you for all the feedback, I will incorporate it and send a new patch series soon. Emanuele From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D853DC3815B for ; Mon, 20 Apr 2020 17:58:25 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 898BC20B1F for ; Mon, 20 Apr 2020 17:58:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HIpqY6r4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HIpqY6r4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 898BC20B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 495ZDt4XmHzDqcm for ; Tue, 21 Apr 2020 03:58:22 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=205.139.110.120; helo=us-smtp-1.mimecast.com; envelope-from=eesposit@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HIpqY6r4; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HIpqY6r4; dkim-atps=neutral Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 495SzQ1MjkzDqdk for ; Tue, 21 Apr 2020 00:01:21 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587391279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CRCdhBzjtov7RvcoLcOwUA5fYrO6qOb+mWbouXaiL5k=; b=HIpqY6r43kH/FzbD5R1+A5UZ+BgK28llVnveeeHeX2tXhDuGWJahaxx8nE2jQ2HscVo06u eFPiqlfnbb0CMKbCBPkbuNjRXAIT4KcPj7Y/j+AmBsOhu9xafYxZricmItF0y6lnUPKnjm b3rTskufbbHZHwOURsKs14cZW4bJhQI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587391279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CRCdhBzjtov7RvcoLcOwUA5fYrO6qOb+mWbouXaiL5k=; b=HIpqY6r43kH/FzbD5R1+A5UZ+BgK28llVnveeeHeX2tXhDuGWJahaxx8nE2jQ2HscVo06u eFPiqlfnbb0CMKbCBPkbuNjRXAIT4KcPj7Y/j+AmBsOhu9xafYxZricmItF0y6lnUPKnjm b3rTskufbbHZHwOURsKs14cZW4bJhQI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-76-kh6aG5ngOK-SR_TMaSQK1A-1; Mon, 20 Apr 2020 10:01:16 -0400 X-MC-Unique: kh6aG5ngOK-SR_TMaSQK1A-1 Received: by mail-wm1-f71.google.com with SMTP id h22so4201341wml.1 for ; Mon, 20 Apr 2020 07:01:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CRCdhBzjtov7RvcoLcOwUA5fYrO6qOb+mWbouXaiL5k=; b=EV5etKKTtywKndlGK7aA/JsdbhXNler4N4BdaDwftnt8mH/yFxmRAsd+yYkriyBE5j hfVTsoySAHbYgH1eO8QXYMlXKAqJCtxpbN8tTSdD0nVBVblDRgDs19imN5hcUTPqzjId uy3xcFQE+GdL2DeZSXG/ciWA8/s1Emm1xxP52LFvMMBT2qBwYYiJh+eu1ejD2Fg+mQsi 0pOls8NuVdQuGuu2zJgQfXGSPMBkktg0Xw8g2vzxOCEkx1j5cbVYThfZVRYm3KUjUak9 EkxuSAnlS6hfdCVnXPpkchHJoFqcIJo64tgCCUmCiJJVNpZ3On6gxfRBC3lf96Z5Z+KK NBOQ== X-Gm-Message-State: AGi0PubSWlQSmD4GQLHDtlrmnpfSVUkCgxZJ+aN+Ffd1MhfdoRmZIkjH +Es7ztBjjPvF64RSMySZ14uyCOOK9r9XF7SjjAXo6JNU0/t8bOTJgZfCvAhuDeRUwn1YQTAA+ov Q52/UhtGhozw8zI4wrndqHL8kdQ== X-Received: by 2002:adf:dd8f:: with SMTP id x15mr20314204wrl.201.1587391274309; Mon, 20 Apr 2020 07:01:14 -0700 (PDT) X-Google-Smtp-Source: APiQypKPnHC5LPyU8TDLr76kncprhTGb3bGNWjc4FM2HGpGEeoX6O6gIYtgQcBPwl5xg+T4TCSCY0A== X-Received: by 2002:adf:dd8f:: with SMTP id x15mr20314132wrl.201.1587391274111; Mon, 20 Apr 2020 07:01:14 -0700 (PDT) Received: from localhost.localdomain ([194.230.155.102]) by smtp.gmail.com with ESMTPSA id q17sm1265501wmj.45.2020.04.20.07.01.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2020 07:01:13 -0700 (PDT) From: Emanuele Giuseppe Esposito Subject: Re: [PATCH 0/8] Simplefs: group and simplify linux fs code To: Luis Chamberlain References: <20200414124304.4470-1-eesposit@redhat.com> <20200416065922.GS11244@42.do-not-panic.com> Message-ID: <79e3dd06-7cea-7798-42a2-596c185abd7b@redhat.com> Date: Mon, 20 Apr 2020 16:01:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200416065922.GS11244@42.do-not-panic.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Tue, 21 Apr 2020 03:37:31 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , linux-usb@vger.kernel.org, bpf@vger.kernel.org, "Rafael J. Wysocki" , David Airlie , Heiko Carstens , Alexei Starovoitov , dri-devel@lists.freedesktop.org, "J. Bruce Fields" , Joseph Qi , Hugh Dickins , Paul Mackerras , John Johansen , netdev@vger.kernel.org, linux-s390@vger.kernel.org, Christoph Hellwig , Andrew Donnellan , Matthew Garrett , linux-efi@vger.kernel.org, Arnd Bergmann , Daniel Borkmann , Christian Borntraeger , linux-rdma@vger.kernel.org, Mark Fasheh , Anton Vorontsov , John Fastabend , James Morris , Ard Biesheuvel , Jason Gunthorpe , Doug Ledford , Yonghong Song , Ian Kent , Andrii Nakryiko , Alexey Dobriyan , "Serge E. Hallyn" , Robert Richter , Thomas Zimmermann , Vasily Gorbik , Tony Luck , Kees Cook , "James E.J. Bottomley" , autofs@vger.kernel.org, Maarten Lankhorst , Mike Marciniszyn , Maxime Ripard , linux-fsdevel@vger.kernel.org, "Manoj N. Kumar" , Uma Krishnan , Jakub Kicinski , KP Singh , Trond Myklebust , "Matthew R. Ochs" , "David S. Miller" , Felipe Balbi , linux-nfs@vger.kernel.org, Iurii Zaikin , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-mm@kvack.org, Greg Kroah-Hartman , Dennis Dalessandro , Miklos Szeredi , linux-kernel@vger.kernel.org, Anna Schumaker , linux-security-module@vger.kernel.org, Chuck Lever , Jeremy Kerr , Daniel Vetter , Colin Cross , Frederic Barrat , Paolo Bonzini , Andrew Morton , Mike Kravetz , linuxppc-dev@lists.ozlabs.org, Martin KaFai Lau , Joel Becker , Alexander Viro Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 4/16/20 8:59 AM, Luis Chamberlain wrote: > On Tue, Apr 14, 2020 at 02:42:54PM +0200, Emanuele Giuseppe Esposito wrote: >> This series of patches introduce wrappers for functions, >> arguments simplification in functions calls and most importantly >> groups duplicated code in a single header, simplefs, to avoid redundancy >> in the linux fs, especially debugfs and tracefs. > > The general goal seems worthy, but here I don't see explained why hasn't > this gone through libfs, and what the intention was long term. For > instance, you added some other generalizations which you have found. It > was not clear that this was the goal here, to expand on these paths. > > What if common code on fs is found which are not part of debugfs and > tracefs, how does one decide if to move to libfs or simplefs? The idea of simplefs (that I will also explain better in the cover letter and commit messages) is that not only it groups common code, but also introduces a new struct simple_fs that simplifies parameter passing. This means all fs that use these functions and the struct should include linux/simplefs.h, while all common functions that take a simple_fs struct will be added in simplefs.c Thank you for all the feedback, I will incorporate it and send a new patch series soon. Emanuele From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CE09C54FD0 for ; Mon, 20 Apr 2020 14:01:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DA8B20722 for ; Mon, 20 Apr 2020 14:01:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fY2LJP82" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DA8B20722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AD6976E58A; Mon, 20 Apr 2020 14:01:19 +0000 (UTC) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by gabe.freedesktop.org (Postfix) with ESMTPS id 001C86E58A for ; Mon, 20 Apr 2020 14:01:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587391277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CRCdhBzjtov7RvcoLcOwUA5fYrO6qOb+mWbouXaiL5k=; b=fY2LJP82b0mA0vso6+vcqqdyQj2JpD112nTAJEGNfUpNAdbBe+i85z3rpxxALtKH4pm5Hy /OjtPoxC8rxvXA570yuO26k+VScdVpVnKqORC87b9oMhf8XqlH7yiEVm9qkOrfmiKYZjPP p37PDcwSI1a+2VokulA0+eKYJOuZpqo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-466-U4TlAGbhPkqaHlO7Vyk-8Q-1; Mon, 20 Apr 2020 10:01:15 -0400 X-MC-Unique: U4TlAGbhPkqaHlO7Vyk-8Q-1 Received: by mail-wr1-f72.google.com with SMTP id p2so4992179wrx.12 for ; Mon, 20 Apr 2020 07:01:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CRCdhBzjtov7RvcoLcOwUA5fYrO6qOb+mWbouXaiL5k=; b=AfDRQVrEAglnJ+XLanPMM0jnZBaba+1E8qdSSRmV/VIHYUgFFxulADbeakUdfRvsig IvR0HQcrmdo27kETCZ8Re97PRLn+jET2cITw1DNvUn/6Zgfkv/ddejRaAyJtAIGd/wI0 xprN+SXQy+jl6WME6Pr0MlEiA/MeUQ1Nxy/Jo2nFs/JcBJUqdjRRUNaJTCgiN2ZzDqap egr+b+1y48ez4AJBoWzOIVNyHavEONZ3qb9LsXWBi4VOp5fWD4E9wPU2sfn9uy8nTXeB A9B9NIhdb2ed79W7MHrraoA6HUcxZ3N/mV2V9v5lF1tH7X4Fl8aTbn8yKt+ItNsmgTzp ZV4A== X-Gm-Message-State: AGi0PuZqjIC0pp3MmDdAV58Il/voCaT0G8wP/8s0ta5EN05opAmwcv+x 8E/PfC6zKtV5ItayYkkDDSFbS9AAbBGKBGhP48Mc+7t94I5QGWCA36iwhLJqXBlAMZ1zLsbbKvM txEmyorcqVLop9KzdZnb//OnPP6/Z X-Received: by 2002:adf:dd8f:: with SMTP id x15mr20314171wrl.201.1587391274302; Mon, 20 Apr 2020 07:01:14 -0700 (PDT) X-Google-Smtp-Source: APiQypKPnHC5LPyU8TDLr76kncprhTGb3bGNWjc4FM2HGpGEeoX6O6gIYtgQcBPwl5xg+T4TCSCY0A== X-Received: by 2002:adf:dd8f:: with SMTP id x15mr20314132wrl.201.1587391274111; Mon, 20 Apr 2020 07:01:14 -0700 (PDT) Received: from localhost.localdomain ([194.230.155.102]) by smtp.gmail.com with ESMTPSA id q17sm1265501wmj.45.2020.04.20.07.01.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2020 07:01:13 -0700 (PDT) From: Emanuele Giuseppe Esposito Subject: Re: [PATCH 0/8] Simplefs: group and simplify linux fs code To: Luis Chamberlain References: <20200414124304.4470-1-eesposit@redhat.com> <20200416065922.GS11244@42.do-not-panic.com> Message-ID: <79e3dd06-7cea-7798-42a2-596c185abd7b@redhat.com> Date: Mon, 20 Apr 2020 16:01:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200416065922.GS11244@42.do-not-panic.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , linux-usb@vger.kernel.org, bpf@vger.kernel.org, "Rafael J. Wysocki" , David Airlie , Heiko Carstens , Alexei Starovoitov , dri-devel@lists.freedesktop.org, "J. Bruce Fields" , Joseph Qi , Hugh Dickins , Paul Mackerras , John Johansen , linux-s390@vger.kernel.org, Christoph Hellwig , Andrew Donnellan , Matthew Garrett , linux-efi@vger.kernel.org, Arnd Bergmann , Daniel Borkmann , Christian Borntraeger , linux-rdma@vger.kernel.org, Michael Ellerman , Mark Fasheh , Anton Vorontsov , John Fastabend , James Morris , Ard Biesheuvel , Jason Gunthorpe , Doug Ledford , Yonghong Song , Ian Kent , Andrii Nakryiko , Alexey Dobriyan , "Serge E. Hallyn" , netdev@vger.kernel.org, Robert Richter , Thomas Zimmermann , Vasily Gorbik , Tony Luck , Kees Cook , "James E.J. Bottomley" , autofs@vger.kernel.org, Mike Marciniszyn , linux-fsdevel@vger.kernel.org, "Manoj N. Kumar" , Uma Krishnan , Jakub Kicinski , KP Singh , Trond Myklebust , "Matthew R. Ochs" , "David S. Miller" , Felipe Balbi , linux-nfs@vger.kernel.org, Iurii Zaikin , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-mm@kvack.org, Greg Kroah-Hartman , Dennis Dalessandro , Miklos Szeredi , linux-kernel@vger.kernel.org, Anna Schumaker , linux-security-module@vger.kernel.org, Chuck Lever , Jeremy Kerr , Colin Cross , Frederic Barrat , Paolo Bonzini , Andrew Morton , Mike Kravetz , linuxppc-dev@lists.ozlabs.org, Martin KaFai Lau , Joel Becker , Alexander Viro Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 4/16/20 8:59 AM, Luis Chamberlain wrote: > On Tue, Apr 14, 2020 at 02:42:54PM +0200, Emanuele Giuseppe Esposito wrote: >> This series of patches introduce wrappers for functions, >> arguments simplification in functions calls and most importantly >> groups duplicated code in a single header, simplefs, to avoid redundancy >> in the linux fs, especially debugfs and tracefs. > > The general goal seems worthy, but here I don't see explained why hasn't > this gone through libfs, and what the intention was long term. For > instance, you added some other generalizations which you have found. It > was not clear that this was the goal here, to expand on these paths. > > What if common code on fs is found which are not part of debugfs and > tracefs, how does one decide if to move to libfs or simplefs? The idea of simplefs (that I will also explain better in the cover letter and commit messages) is that not only it groups common code, but also introduces a new struct simple_fs that simplifies parameter passing. This means all fs that use these functions and the struct should include linux/simplefs.h, while all common functions that take a simple_fs struct will be added in simplefs.c Thank you for all the feedback, I will incorporate it and send a new patch series soon. Emanuele _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emanuele Giuseppe Esposito Subject: Re: [PATCH 0/8] Simplefs: group and simplify linux fs code Date: Mon, 20 Apr 2020 16:01:08 +0200 Message-ID: <79e3dd06-7cea-7798-42a2-596c185abd7b@redhat.com> References: <20200414124304.4470-1-eesposit@redhat.com> <20200416065922.GS11244@42.do-not-panic.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587391279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CRCdhBzjtov7RvcoLcOwUA5fYrO6qOb+mWbouXaiL5k=; b=HIpqY6r43kH/FzbD5R1+A5UZ+BgK28llVnveeeHeX2tXhDuGWJahaxx8nE2jQ2HscVo06u eFPiqlfnbb0CMKbCBPkbuNjRXAIT4KcPj7Y/j+AmBsOhu9xafYxZricmItF0y6lnUPKnjm b3rTskufbbHZHwOURsKs14cZW4bJhQI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587391279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CRCdhBzjtov7RvcoLcOwUA5fYrO6qOb+mWbouXaiL5k=; b=HIpqY6r43kH/FzbD5R1+A5UZ+BgK28llVnveeeHeX2tXhDuGWJahaxx8nE2jQ2HscVo06u eFPiqlfnbb0CMKbCBPkbuNjRXAIT4KcPj7Y/j+AmBsOhu9xafYxZricmItF0y6lnUPKnjm b3rTskufbbHZHwOURsKs14cZW4bJhQI= In-Reply-To: <20200416065922.GS11244@42.do-not-panic.com> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane-mx.org@lists.ozlabs.org Sender: "Linuxppc-dev" Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Luis Chamberlain Cc: Song Liu , linux-usb@vger.kernel.org, bpf@vger.kernel.org, "Rafael J. Wysocki" , David Airlie , Heiko Carstens , Alexei Starovoitov , dri-devel@lists.freedesktop.org, "J. Bruce Fields" , Joseph Qi , Hugh Dickins , Paul Mackerras , John Johansen , netdev@vger.kernel.org, linux-s390@vger.kernel.org, Christoph Hellwig , Andrew Donnellan , Matthew Garrett , linux-efi@vger.kernel.org, Arnd Bergmann , Daniel Borkmann , Christian Borntraeger , linux-rdma@vger.kernel.org, Mark Fasheh , Anton Vorontsov , John On 4/16/20 8:59 AM, Luis Chamberlain wrote: > On Tue, Apr 14, 2020 at 02:42:54PM +0200, Emanuele Giuseppe Esposito wrote: >> This series of patches introduce wrappers for functions, >> arguments simplification in functions calls and most importantly >> groups duplicated code in a single header, simplefs, to avoid redundancy >> in the linux fs, especially debugfs and tracefs. > > The general goal seems worthy, but here I don't see explained why hasn't > this gone through libfs, and what the intention was long term. For > instance, you added some other generalizations which you have found. It > was not clear that this was the goal here, to expand on these paths. > > What if common code on fs is found which are not part of debugfs and > tracefs, how does one decide if to move to libfs or simplefs? The idea of simplefs (that I will also explain better in the cover letter and commit messages) is that not only it groups common code, but also introduces a new struct simple_fs that simplifies parameter passing. This means all fs that use these functions and the struct should include linux/simplefs.h, while all common functions that take a simple_fs struct will be added in simplefs.c Thank you for all the feedback, I will incorporate it and send a new patch series soon. Emanuele