From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422704AbcK3Sab (ORCPT ); Wed, 30 Nov 2016 13:30:31 -0500 Received: from lelnx193.ext.ti.com ([198.47.27.77]:57348 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422662AbcK3SaS (ORCPT ); Wed, 30 Nov 2016 13:30:18 -0500 Subject: Re: [PATCH v2 07/13] net: ethernet: ti: cpts: rework initialization/deinitialization To: Richard Cochran References: <20161128230337.6731-1-grygorii.strashko@ti.com> <20161128230337.6731-8-grygorii.strashko@ti.com> <20161129100737.GF3110@localhost.localdomain> <2037427d-0ab6-9446-450d-21c34123c03b@ti.com> CC: "David S. Miller" , , Mugunthan V N , Sekhar Nori , , , Rob Herring , , Murali Karicheri , Wingman Kwok From: Grygorii Strashko Message-ID: <79e4cb8d-b824-d7cb-56e1-7828ded5caef@ti.com> Date: Wed, 30 Nov 2016 12:30:06 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <2037427d-0ab6-9446-450d-21c34123c03b@ti.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [128.247.83.173] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Richard, On 11/29/2016 09:50 AM, Grygorii Strashko wrote: > On 11/29/2016 04:07 AM, Richard Cochran wrote: >> On Mon, Nov 28, 2016 at 05:03:31PM -0600, Grygorii Strashko wrote: >>> +int cpts_register(struct cpts *cpts) >>> { >>> int err, i; >>> >>> - cpts->info = cpts_info; >>> - spin_lock_init(&cpts->lock); >>> - >>> - cpts->cc.read = cpts_systim_read; >>> - cpts->cc.mask = CLOCKSOURCE_MASK(32); >>> - cpts->cc_mult = mult; >>> - cpts->cc.mult = mult; >>> - cpts->cc.shift = shift; >>> - >>> INIT_LIST_HEAD(&cpts->events); >>> INIT_LIST_HEAD(&cpts->pool); >>> for (i = 0; i < CPTS_MAX_EVENTS; i++) >>> list_add(&cpts->pool_data[i].list, &cpts->pool); >>> >>> - cpts_clk_init(dev, cpts); >>> + clk_enable(cpts->refclk); >>> + >>> cpts_write32(cpts, CPTS_EN, control); >>> cpts_write32(cpts, TS_PEND_EN, int_enable); >>> >>> + cpts->cc.mult = cpts->cc_mult; >> >> It is not clear why you set cc.mult in a different place than >> cc.shift. That isn't logical, but maybe later patches make it >> clear... > > cc.mult has to be reloaded to original value each time CPTS is registered(restarted) > as it can be modified by cpts_ptp_adjfreq(). > > While cc.shift is static. > > Will it ok if i will add comment here and re-send series? -- regards, -grygorii From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [PATCH v2 07/13] net: ethernet: ti: cpts: rework initialization/deinitialization Date: Wed, 30 Nov 2016 12:30:06 -0600 Message-ID: <79e4cb8d-b824-d7cb-56e1-7828ded5caef@ti.com> References: <20161128230337.6731-1-grygorii.strashko@ti.com> <20161128230337.6731-8-grygorii.strashko@ti.com> <20161129100737.GF3110@localhost.localdomain> <2037427d-0ab6-9446-450d-21c34123c03b@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , , Mugunthan V N , Sekhar Nori , , , Rob Herring , , Murali Karicheri , Wingman Kwok To: Richard Cochran Return-path: In-Reply-To: <2037427d-0ab6-9446-450d-21c34123c03b-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hi Richard, On 11/29/2016 09:50 AM, Grygorii Strashko wrote: > On 11/29/2016 04:07 AM, Richard Cochran wrote: >> On Mon, Nov 28, 2016 at 05:03:31PM -0600, Grygorii Strashko wrote: >>> +int cpts_register(struct cpts *cpts) >>> { >>> int err, i; >>> >>> - cpts->info = cpts_info; >>> - spin_lock_init(&cpts->lock); >>> - >>> - cpts->cc.read = cpts_systim_read; >>> - cpts->cc.mask = CLOCKSOURCE_MASK(32); >>> - cpts->cc_mult = mult; >>> - cpts->cc.mult = mult; >>> - cpts->cc.shift = shift; >>> - >>> INIT_LIST_HEAD(&cpts->events); >>> INIT_LIST_HEAD(&cpts->pool); >>> for (i = 0; i < CPTS_MAX_EVENTS; i++) >>> list_add(&cpts->pool_data[i].list, &cpts->pool); >>> >>> - cpts_clk_init(dev, cpts); >>> + clk_enable(cpts->refclk); >>> + >>> cpts_write32(cpts, CPTS_EN, control); >>> cpts_write32(cpts, TS_PEND_EN, int_enable); >>> >>> + cpts->cc.mult = cpts->cc_mult; >> >> It is not clear why you set cc.mult in a different place than >> cc.shift. That isn't logical, but maybe later patches make it >> clear... > > cc.mult has to be reloaded to original value each time CPTS is registered(restarted) > as it can be modified by cpts_ptp_adjfreq(). > > While cc.shift is static. > > Will it ok if i will add comment here and re-send series? -- regards, -grygorii -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [PATCH v2 07/13] net: ethernet: ti: cpts: rework initialization/deinitialization Date: Wed, 30 Nov 2016 12:30:06 -0600 Message-ID: <79e4cb8d-b824-d7cb-56e1-7828ded5caef@ti.com> References: <20161128230337.6731-1-grygorii.strashko@ti.com> <20161128230337.6731-8-grygorii.strashko@ti.com> <20161129100737.GF3110@localhost.localdomain> <2037427d-0ab6-9446-450d-21c34123c03b@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2037427d-0ab6-9446-450d-21c34123c03b-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Richard Cochran Cc: "David S. Miller" , netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mugunthan V N , Sekhar Nori , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Murali Karicheri , Wingman Kwok List-Id: devicetree@vger.kernel.org Hi Richard, On 11/29/2016 09:50 AM, Grygorii Strashko wrote: > On 11/29/2016 04:07 AM, Richard Cochran wrote: >> On Mon, Nov 28, 2016 at 05:03:31PM -0600, Grygorii Strashko wrote: >>> +int cpts_register(struct cpts *cpts) >>> { >>> int err, i; >>> >>> - cpts->info = cpts_info; >>> - spin_lock_init(&cpts->lock); >>> - >>> - cpts->cc.read = cpts_systim_read; >>> - cpts->cc.mask = CLOCKSOURCE_MASK(32); >>> - cpts->cc_mult = mult; >>> - cpts->cc.mult = mult; >>> - cpts->cc.shift = shift; >>> - >>> INIT_LIST_HEAD(&cpts->events); >>> INIT_LIST_HEAD(&cpts->pool); >>> for (i = 0; i < CPTS_MAX_EVENTS; i++) >>> list_add(&cpts->pool_data[i].list, &cpts->pool); >>> >>> - cpts_clk_init(dev, cpts); >>> + clk_enable(cpts->refclk); >>> + >>> cpts_write32(cpts, CPTS_EN, control); >>> cpts_write32(cpts, TS_PEND_EN, int_enable); >>> >>> + cpts->cc.mult = cpts->cc_mult; >> >> It is not clear why you set cc.mult in a different place than >> cc.shift. That isn't logical, but maybe later patches make it >> clear... > > cc.mult has to be reloaded to original value each time CPTS is registered(restarted) > as it can be modified by cpts_ptp_adjfreq(). > > While cc.shift is static. > > Will it ok if i will add comment here and re-send series? -- regards, -grygorii -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html