From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42753C433FE for ; Wed, 27 Apr 2022 05:33:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357868AbiD0Fga (ORCPT ); Wed, 27 Apr 2022 01:36:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242326AbiD0Fg3 (ORCPT ); Wed, 27 Apr 2022 01:36:29 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B65514D9C7; Tue, 26 Apr 2022 22:33:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1651037599; x=1682573599; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=mWPi76UoDbrAXwod72PEjvq5pSqYwhGyKy1hsijf+Ds=; b=Ji+KngHW5fgige0WVJHBJMDX3+q1REff6mzBz7BNkIGfJDZT+nXBYoxe G0gsv4cC9usG+NArXX1s/8lDyW1abEKIlmHDGwNr6ShuE9lUKPdsBuuVA hdb0n0bgTtKRxKc/6NTnyO8dG4DfBGT7t2j6RGuxFe2N05iJigIEvlMow w=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-01.qualcomm.com with ESMTP; 26 Apr 2022 22:33:19 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 22:33:18 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 26 Apr 2022 22:33:18 -0700 Received: from [10.50.15.218] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 26 Apr 2022 22:33:16 -0700 Message-ID: <79f6caba-7d61-f89d-48f6-b9c6a04ab7b9@quicinc.com> Date: Wed, 27 Apr 2022 11:02:57 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v5 00/12] add support for WCN6750 Content-Language: en-US To: Kalle Valo CC: , , , , References: <20220426145456.8055-1-quic_mpubbise@quicinc.com> <87v8uvhzuk.fsf@kernel.org> <87o80nhzrd.fsf@kernel.org> From: Manikanta Pubbisetty In-Reply-To: <87o80nhzrd.fsf@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 4/27/2022 10:46 AM, Kalle Valo wrote: > Kalle Valo writes: > >> Manikanta Pubbisetty writes: >> >>> WCN6750 is non-DBS 2x2 11AX chipset. Unlike QCA6390/WCN6855 which >>> are DBS (dual band simultaneous) solutions (2 LMACs), WCN6750 has a >>> single LMAC supporting 2G, 5G and 6G bands. It can be operated only >>> on one band at any given point. >>> >>> WCN6750 is a PCIe device. Unlike other supported ATH11K PCIe devices >>> which are directly attached to APSS (Application Processor SubSystem), >>> WCN6750 is not attached to APSS, it is attached to the WPSS >>> (Wireless Processor SubSystem) Q6 processor, the FW which runs on the >>> Q6 processor will enumerate the PCIe device. Since APSS is unaware of >>> such a device, it has to be registered as a platform device(AHB) to the >>> kernel for device probing. Like other AHB devices, remoteproc APIs are >>> used to boot up or shutdown of WCN6750. >>> >>> WCN6750 uses both AHB and PCIe ATH11K APIs for it's operation. >>> It uses AHB APIs for device probe and booting of the remote processor. >>> Once device is booted up, it uses ATH11K PCIe APIs for initialization >>> and register access. Hence, it is referred as hybrid bus device in >>> the rest of this series. >>> >>> Since the chip is enumerated by WPSS Q6, device information like >>> BAR and BAR size is not known to the APSS processor. A new QMI message >>> called device info QMI request will be sent to the target for fetching >>> these details. >>> >>> STA and AP modes are supported; Basic connectivity and ping are >>> verified in both the modes. >>> >>> An important point to note is that though WCN6750 is a PCIe device, >>> it cannot be attached to any other platform except on Qualcomm >>> Snapdragon SoCs due to the aforementioned reasons. >>> >>> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1 >>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 >>> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1 >>> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1 >>> >>> Manikanta Pubbisetty (12): >>> dt: bindings: net: add bindings of WCN6750 for ath11k >>> ath11k: Add HW params for WCN6750 >>> ath11k: Add bus params for WCN6750 >>> ath11k: Add register access logic for WCN6750 >>> ath11k: Fetch device information via QMI for WCN6750 >>> ath11k: Add QMI changes for WCN6750 >>> ath11k: HAL changes to support WCN6750 >>> ath11k: Datapath changes to support WCN6750 >>> ath11k: Do not put HW in DBS mode for WCN6750 >>> ath11k: WMI changes to support WCN6750 >>> ath11k: Update WBM idle ring HP after FW mode on >>> ath11k: Add support for WCN6750 device >>> --- >>> V5: >>> - Rebased on ToT SHAID: 01be26cde012478db958d9bde530877c46031e76 >> >> I already had v4 applied to the pending branch so I'm going to drop v5 >> and look at v4 instead. > > I see that you also added Rob's reviewed-by to patch 1. Please include > ALL changes in the changes list, otherwise review is difficult as we > don't know what you changed. > Sorry for the inconvenience caused, I thought the reviewed-by addition is trivial and did not add it to the change list. Going forward, I'll take care of it. Thanks, Manikanta From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20FEEC433F5 for ; Wed, 27 Apr 2022 05:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rESayv9Uk8O+VDyV0cmiAI5YnJEl+CcZy9YGRQoDeMc=; b=PAvf1EhVLyntum hp9b6GqRvd9K330qQqWIXTPTBuMj5N3QBJgeP2xOfURCznSHSdTG1loAM3bTS3n+rNR4XQY1rC2Pq FSoWizo8DeRjHje7dB3L++KbHR5EU3R3H5PaxUNkQYDG7blumlw+HGIldm9bE2A3iSFEIA57lnsvM FCRIq3yMvC5PsUfR/vBfG+aqWubRUbKf7M1M5hSaUnOUDumXQttdTy9vTJ57PDiF1pkA3w3uCRa98 +1/D6kQaPWhP8zvg0A/Mxh1dNr93zNC6HNVvn2oMenJuHrdVNb8uSQfEBen+rGPuQwN9nmGGKy25g 8TKYjuqwwrzIkOqS0Pqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njaIr-00HU4P-HU; Wed, 27 Apr 2022 05:33:29 +0000 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njaIo-00HU3S-MC for ath11k@lists.infradead.org; Wed, 27 Apr 2022 05:33:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1651037606; x=1682573606; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=mWPi76UoDbrAXwod72PEjvq5pSqYwhGyKy1hsijf+Ds=; b=Pmu3hItkOzHP4sX7vezBFGWI1j7fH5GamECfDKRcgeu5m9qT0/LXkkhc xnNSE0UZNLk/2FLQgOWL8tdQkL+KYdj7TXHDQdeevdbN4NgoW5aBEqt+H WtWt3NIewXIlti5fjvm70CFaW3FE2pUaLpaW5vpPrmWT6vHvpTocj9b+E 4=; Received: from unknown (HELO ironmsg02-sd.qualcomm.com) ([10.53.140.142]) by alexa-out-sd-01.qualcomm.com with ESMTP; 26 Apr 2022 22:33:19 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg02-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2022 22:33:18 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 26 Apr 2022 22:33:18 -0700 Received: from [10.50.15.218] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 26 Apr 2022 22:33:16 -0700 Message-ID: <79f6caba-7d61-f89d-48f6-b9c6a04ab7b9@quicinc.com> Date: Wed, 27 Apr 2022 11:02:57 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v5 00/12] add support for WCN6750 Content-Language: en-US To: Kalle Valo CC: , , , , References: <20220426145456.8055-1-quic_mpubbise@quicinc.com> <87v8uvhzuk.fsf@kernel.org> <87o80nhzrd.fsf@kernel.org> From: Manikanta Pubbisetty In-Reply-To: <87o80nhzrd.fsf@kernel.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220426_223326_777257_7CFFDD80 X-CRM114-Status: GOOD ( 15.62 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org On 4/27/2022 10:46 AM, Kalle Valo wrote: > Kalle Valo writes: > >> Manikanta Pubbisetty writes: >> >>> WCN6750 is non-DBS 2x2 11AX chipset. Unlike QCA6390/WCN6855 which >>> are DBS (dual band simultaneous) solutions (2 LMACs), WCN6750 has a >>> single LMAC supporting 2G, 5G and 6G bands. It can be operated only >>> on one band at any given point. >>> >>> WCN6750 is a PCIe device. Unlike other supported ATH11K PCIe devices >>> which are directly attached to APSS (Application Processor SubSystem), >>> WCN6750 is not attached to APSS, it is attached to the WPSS >>> (Wireless Processor SubSystem) Q6 processor, the FW which runs on the >>> Q6 processor will enumerate the PCIe device. Since APSS is unaware of >>> such a device, it has to be registered as a platform device(AHB) to the >>> kernel for device probing. Like other AHB devices, remoteproc APIs are >>> used to boot up or shutdown of WCN6750. >>> >>> WCN6750 uses both AHB and PCIe ATH11K APIs for it's operation. >>> It uses AHB APIs for device probe and booting of the remote processor. >>> Once device is booted up, it uses ATH11K PCIe APIs for initialization >>> and register access. Hence, it is referred as hybrid bus device in >>> the rest of this series. >>> >>> Since the chip is enumerated by WPSS Q6, device information like >>> BAR and BAR size is not known to the APSS processor. A new QMI message >>> called device info QMI request will be sent to the target for fetching >>> these details. >>> >>> STA and AP modes are supported; Basic connectivity and ping are >>> verified in both the modes. >>> >>> An important point to note is that though WCN6750 is a PCIe device, >>> it cannot be attached to any other platform except on Qualcomm >>> Snapdragon SoCs due to the aforementioned reasons. >>> >>> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1 >>> Tested-on: WCN6855 hw2.0 PCI WLAN.HSP.1.1-01720.1-QCAHSPSWPL_V1_V2_SILICONZ_LITE-1 >>> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.5.0.1-01100-QCAHKSWPL_SILICONZ-1 >>> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-00192-QCAHKSWPL_SILICONZ-1 >>> >>> Manikanta Pubbisetty (12): >>> dt: bindings: net: add bindings of WCN6750 for ath11k >>> ath11k: Add HW params for WCN6750 >>> ath11k: Add bus params for WCN6750 >>> ath11k: Add register access logic for WCN6750 >>> ath11k: Fetch device information via QMI for WCN6750 >>> ath11k: Add QMI changes for WCN6750 >>> ath11k: HAL changes to support WCN6750 >>> ath11k: Datapath changes to support WCN6750 >>> ath11k: Do not put HW in DBS mode for WCN6750 >>> ath11k: WMI changes to support WCN6750 >>> ath11k: Update WBM idle ring HP after FW mode on >>> ath11k: Add support for WCN6750 device >>> --- >>> V5: >>> - Rebased on ToT SHAID: 01be26cde012478db958d9bde530877c46031e76 >> >> I already had v4 applied to the pending branch so I'm going to drop v5 >> and look at v4 instead. > > I see that you also added Rob's reviewed-by to patch 1. Please include > ALL changes in the changes list, otherwise review is difficult as we > don't know what you changed. > Sorry for the inconvenience caused, I thought the reviewed-by addition is trivial and did not add it to the change list. Going forward, I'll take care of it. Thanks, Manikanta -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k