From mboxrd@z Thu Jan 1 00:00:00 1970 From: Menon, Nishanth Date: Wed, 10 Jun 2009 11:16:48 -0500 Subject: [U-Boot] [PATCH 3/4] ZOOM2 Add power reset button In-Reply-To: <4A2FD4BE.8050405@googlemail.com> References: <1244638432-30893-1-git-send-email-Tom.Rix@windriver.com> <1244638432-30893-2-git-send-email-Tom.Rix@windriver.com> <1244638432-30893-3-git-send-email-Tom.Rix@windriver.com> <1244638432-30893-4-git-send-email-Tom.Rix@windriver.com> <1244644042 <4A2FD4BE.8050405@googlemail.com> Message-ID: <7A436F7769CA33409C6B44B358BFFF0C0115CBB3F9@dlee02.ent.ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > -----Original Message----- > From: Dirk Behme [mailto:dirk.behme at googlemail.com] > Sent: Wednesday, June 10, 2009 10:44 AM > >>> --- a/drivers/i2c/twl4030_i2c.c > >> All other drivers in drivers/i2c are host adapter drivers. Ie they > >> implement i2c_read(), i2c_write(), i2c_probe(), and i2c_init(). The > >> twl4030_i2c.c driver doesn't seem to fit this mold. Perhaps it would > be > >> better placed in drivers/misc or a new drivers/power directory similar > >> to Linux? > > > > This function probably belongs to board/omap3/common/power.c -> or even > better to the board file itself? > > I was about to mention the opposite ;) > > Jean-Christophe asked to move the code from power.c to driver directory > > http://lists.denx.de/pipermail/u-boot/2009-May/052400.html > > If you follow above discussion, I was fine with power.c. If we get now > a twl4030_i2c.c, we should merge the code from power.c into it, too > (where ever it will be located and named, then). > This IMHO is the right approach -> but the real question is where in drivers/ directory? How about drivers/i2c/chips and moving the current drivers/i2c/* to drivers/i2c/busses - following the kernel organization? Regards, Nishanth Menon