From mboxrd@z Thu Jan  1 00:00:00 1970
From: "He, Shaopeng" <shaopeng.he@intel.com>
Subject: Re: [PATCH V5 5/7] bus: add helper to handle sigbus
Date: Fri, 6 Jul 2018 15:22:01 +0000
Message-ID: <7A795063ED59344FA044FE7D577A3D9878C73D@SHSMSX101.ccr.corp.intel.com>
References: <1498711073-42917-1-git-send-email-jia.guo@intel.com>
 <1530776333-30318-1-git-send-email-jia.guo@intel.com>
 <1530776333-30318-6-git-send-email-jia.guo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "jblunck@infradead.org" <jblunck@infradead.org>, "shreyansh.jain@nxp.com"
 <shreyansh.jain@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Helin"
 <helin.zhang@intel.com>
To: "Guo, Jia" <jia.guo@intel.com>, "stephen@networkplumber.org"
 <stephen@networkplumber.org>, "Richardson, Bruce"
 <bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net>,
 "motih@mellanox.com" <motih@mellanox.com>, "matan@mellanox.com"
 <matan@mellanox.com>, "Van Haaren, Harry" <harry.van.haaren@intel.com>,
 "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Iremonger, Bernard"
 <bernard.iremonger@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 408F91BDFB
 for <dev@dpdk.org>; Fri,  6 Jul 2018 17:22:13 +0200 (CEST)
In-Reply-To: <1530776333-30318-6-git-send-email-jia.guo@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> -----Original Message-----
> From: Guo, Jia
> Sent: Thursday, July 5, 2018 3:39 PM
>=20
> This patch aim to add a helper to iterate all buses to find the
> corresponding bus to handle the sigbus error.
>=20

[...]

> +	bus =3D rte_bus_find(NULL, bus_handle_sigbus, failure_addr);
> +	/* failed to handle the sigbus, pass the new errno. */
> +	if (bus && rte_errno =3D=3D -1)
> +		return -1;
> +	else if (!bus)
> +		ret =3D 1;

Change the compare order, code will be a little bit shorter?
	if (!bus)
		ret =3D 1
	else if (rte_errno =3D=3D -1)
		return -1;

[...]

Acked-by: Shaopeng He <shaopeng.he@intel.com>