All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] mk: fix eal shared library dependencies -lrt
Date: Tue, 22 Mar 2016 09:25:50 +0000	[thread overview]
Message-ID: <7ADD74816B4C8A45B56203CBA65FE5A6377417BA@IRSMSX107.ger.corp.intel.com> (raw)
In-Reply-To: <2532380.h4kKuHkruB@xps13>

>-----Original Message-----
>From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
>Sent: Tuesday, March 22, 2016 9:55 AM
>To: Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>
>Cc: dev@dpdk.org
>Subject: Re: [dpdk-dev] [PATCH] mk: fix eal shared library dependencies -lrt
>
>2016-03-22 09:09, Daniel Mrzyglod:
>> For GLIBC < 2.17 it is necessery to add -lrt for linker
>> from glibc > 2.17 The `clock_*' suite of functions (declared in <time.h>) is now
>> available directly in the main C library. This affect Ubuntu 12.04 in i686
>> and other older Linux Distros).
>[...]
>> --- a/app/test/Makefile
>> +++ b/app/test/Makefile
>> @@ -114,6 +114,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) +=
>test_cmdline_string.c
>>  SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test_cmdline_lib.c
>>
>>  ifeq ($(CONFIG_RTE_LIBRTE_SCHED),y)
>> +LDFLAGS += -lrt
>
>Why are you adding it only for librte_sched?
>Is it needed by librte_sched or by some functions testing librte_sched?

Every clock_gettime() needs -lrt for >=GLIBC2.17. For glibc2.17 and above  `clock_*' suite of functions (declared in <time.h>) is now available
directly in the main C library.
In test it's only in test_red.c and I see that I missed it in ptpclient example probably. So I will send Patch v2

  reply	other threads:[~2016-03-22  9:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22  8:09 [PATCH] mk: fix eal shared library dependencies -lrt Daniel Mrzyglod
2016-03-22  8:55 ` Thomas Monjalon
2016-03-22  9:25   ` Mrzyglod, DanielX T [this message]
2016-03-22  9:58 ` [PATCH v2] " Daniel Mrzyglod
2016-03-22 12:18   ` Panu Matilainen
2016-03-22 12:49 ` Daniel Mrzyglod
2016-03-22 12:51 ` [PATCH v3] " Daniel Mrzyglod
2016-03-22 19:47   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ADD74816B4C8A45B56203CBA65FE5A6377417BA@IRSMSX107.ger.corp.intel.com \
    --to=danielx.t.mrzyglod@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.