From mboxrd@z Thu Jan 1 00:00:00 1970 From: nikolay@cumulusnetworks.com Subject: Re: [PATCH net] bridge: do not add port to router list when receives query with source 0.0.0.0 Date: Fri, 26 Oct 2018 19:26:31 +0300 Message-ID: <7B2209C1-6FC9-42EA-AA27-9457815797CB@cumulusnetworks.com> References: <1540520923-17589-1-git-send-email-liuhangbin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Jiri Pirko , =?ISO-8859-1?Q?Linus_L=FCssing?= , "David S. Miller" To: Hangbin Liu , netdev@vger.kernel.org Return-path: Received: from mail-wm1-f66.google.com ([209.85.128.66]:33370 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726373AbeJ0BES (ORCPT ); Fri, 26 Oct 2018 21:04:18 -0400 Received: by mail-wm1-f66.google.com with SMTP id y140-v6so4565629wmd.0 for ; Fri, 26 Oct 2018 09:26:36 -0700 (PDT) In-Reply-To: <1540520923-17589-1-git-send-email-liuhangbin@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On 26 October 2018 05:28:43 EEST, Hangbin Liu wrot= e: >Based on RFC 4541, 2=2E1=2E1=2E IGMP Forwarding Rules > > The switch supporting IGMP snooping must maintain a list of > multicast routers and the ports on which they are attached=2E This > list can be constructed in any combination of the following ways: > > a) This list should be built by the snooping switch sending > Multicast Router Solicitation messages as described in IGMP > Multicast Router Discovery [MRDISC]=2E It may also snoop > Multicast Router Advertisement messages sent by and to other > nodes=2E > > b) The arrival port for IGMP Queries (sent by multicast routers) > where the source address is not 0=2E0=2E0=2E0=2E > >We should not add the port to router list when receives query with >source >0=2E0=2E0=2E0=2E > >Reported-by: Ying Xu >Signed-off-by: Hangbin Liu >--- Acked-by: Nikolay Aleksandrov