From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936318AbdIZF3W (ORCPT ); Tue, 26 Sep 2017 01:29:22 -0400 Received: from mga02.intel.com ([134.134.136.20]:4349 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934482AbdIZF3U (ORCPT ); Tue, 26 Sep 2017 01:29:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,439,1500966000"; d="scan'208";a="155993882" From: "Mohandass, Divagar" To: Andy Shevchenko , "Mani, Rajmohan" CC: "robh+dt@kernel.org" , "mark.rutland@arm.com" , "wsa@the-dreams.de" , "sakari.ailus@iki.fi" , "devicetree@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tfiga@chromium.org" Subject: RE: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device property "size" Thread-Topic: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device property "size" Thread-Index: AQHTJWiECibaB709iEy9EcM98aZcmKK84MWAgAPzKQCABeib4A== Date: Tue, 26 Sep 2017 05:29:06 +0000 Message-ID: <7B8CE47BD58441468D2BB13285B50E6031DF0721@BGSMSX107.gar.corp.intel.com> References: <1504520928-5191-1-git-send-email-divagar.mohandass@intel.com> <1504520928-5191-3-git-send-email-divagar.mohandass@intel.com> <6F87890CF0F5204F892DEA1EF0D77A5972FC126B@FMSMSX114.amr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v8Q5TfRF011348 Hi Andy, Sorry missed the 'Suggested-by' tag. Can I resend the v6 with this change, so that Wolfram can pick these patches ? --- ^Divagar >-----Original Message----- >From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com] >Sent: Friday, September 22, 2017 9:42 PM >To: Mani, Rajmohan >Cc: Mohandass, Divagar ; >robh+dt@kernel.org; mark.rutland@arm.com; wsa@the-dreams.de; >sakari.ailus@iki.fi; devicetree@vger.kernel.org; linux-i2c@vger.kernel.org; >linux-kernel@vger.kernel.org; tfiga@chromium.org >Subject: Re: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom >device property "size" > >On Wed, Sep 20, 2017 at 6:52 AM, Mani, Rajmohan > wrote: >> Adding Tomasz... > >Please, don't top post. >Better to resend entire series with all stakeholders included. > >>> Obtain the size of the EEPROM chip from DT if the "size" property is >>> specified for the device. >>> > >I guess it lacks >Suggested-by: Andy Shevchenko > >Other than that, looks good to me! > >Reviewed-by: Andy Shevchenko > > >Wolfram, the binding is ACKed by Rob and this one is in a good shape. >Moreover, it seems like a demand for the property since some IoT stuff >would like to use the driver on ACPI enabled platforms with different sizes. > >Can you go ahead and apply first two patches? It would be really appreciated. > >>> Signed-off-by: Divagar Mohandass >>> --- >>> drivers/misc/eeprom/at24.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c >>> index >>> 764ff5df..2199c42 100644 >>> --- a/drivers/misc/eeprom/at24.c >>> +++ b/drivers/misc/eeprom/at24.c >>> @@ -570,6 +570,10 @@ static void at24_get_pdata(struct device *dev, >>> struct at24_platform_data *chip) >>> if (device_property_present(dev, "read-only")) >>> chip->flags |= AT24_FLAG_READONLY; >>> >>> + err = device_property_read_u32(dev, "size", &val); >>> + if (!err) >>> + chip->byte_len = val; >>> + >>> err = device_property_read_u32(dev, "pagesize", &val); >>> if (!err) { >>> chip->page_size = val; >>> -- >>> 1.9.1 >> > > > >-- >With Best Regards, >Andy Shevchenko