From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: [PATCH] Bluetooth: btusb: use irqsave() in URB's complete callback From: Marcel Holtmann In-Reply-To: <20180619215657.13745-1-bigeasy@linutronix.de> Date: Fri, 6 Jul 2018 12:46:22 +0200 Cc: linux-bluetooth@vger.kernel.org, linux-usb@vger.kernel.org, Thomas Gleixner , Johan Hedberg Message-Id: <7C7F6423-3DFE-47F7-9A68-31817C1A3DC5@holtmann.org> References: <20180619215657.13745-1-bigeasy@linutronix.de> To: Sebastian Andrzej Siewior Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Sebastian, > The USB completion callback does not disable interrupts while acquiring > the ->lock. We want to remove the local_irq_disable() invocation from > __usb_hcd_giveback_urb() and therefore it is required for the callback > handler to disable the interrupts while acquiring the lock. > The callback may be invoked either in IRQ or BH context depending on the > USB host controller. > Use the _irqsave variant of the locking primitives. > > Cc: Marcel Holtmann > Cc: Johan Hedberg > Cc: linux-bluetooth@vger.kernel.org > Signed-off-by: Sebastian Andrzej Siewior > --- > drivers/bluetooth/btusb.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: Bluetooth: btusb: use irqsave() in URB's complete callback From: Marcel Holtmann Message-Id: <7C7F6423-3DFE-47F7-9A68-31817C1A3DC5@holtmann.org> Date: Fri, 6 Jul 2018 12:46:22 +0200 To: Sebastian Andrzej Siewior Cc: linux-bluetooth@vger.kernel.org, linux-usb@vger.kernel.org, Thomas Gleixner , Johan Hedberg List-ID: SGkgU2ViYXN0aWFuLAoKPiBUaGUgVVNCIGNvbXBsZXRpb24gY2FsbGJhY2sgZG9lcyBub3QgZGlz YWJsZSBpbnRlcnJ1cHRzIHdoaWxlIGFjcXVpcmluZwo+IHRoZSAtPmxvY2suIFdlIHdhbnQgdG8g cmVtb3ZlIHRoZSBsb2NhbF9pcnFfZGlzYWJsZSgpIGludm9jYXRpb24gZnJvbQo+IF9fdXNiX2hj ZF9naXZlYmFja191cmIoKSBhbmQgdGhlcmVmb3JlIGl0IGlzIHJlcXVpcmVkIGZvciB0aGUgY2Fs bGJhY2sKPiBoYW5kbGVyIHRvIGRpc2FibGUgdGhlIGludGVycnVwdHMgd2hpbGUgYWNxdWlyaW5n IHRoZSBsb2NrLgo+IFRoZSBjYWxsYmFjayBtYXkgYmUgaW52b2tlZCBlaXRoZXIgaW4gSVJRIG9y IEJIIGNvbnRleHQgZGVwZW5kaW5nIG9uIHRoZQo+IFVTQiBob3N0IGNvbnRyb2xsZXIuCj4gVXNl IHRoZSBfaXJxc2F2ZSB2YXJpYW50IG9mIHRoZSBsb2NraW5nIHByaW1pdGl2ZXMuCj4gCj4gQ2M6 IE1hcmNlbCBIb2x0bWFubiA8bWFyY2VsQGhvbHRtYW5uLm9yZz4KPiBDYzogSm9oYW4gSGVkYmVy ZyA8am9oYW4uaGVkYmVyZ0BnbWFpbC5jb20+Cj4gQ2M6IGxpbnV4LWJsdWV0b290aEB2Z2VyLmtl cm5lbC5vcmcKPiBTaWduZWQtb2ZmLWJ5OiBTZWJhc3RpYW4gQW5kcnplaiBTaWV3aW9yIDxiaWdl YXN5QGxpbnV0cm9uaXguZGU+Cj4gLS0tCj4gZHJpdmVycy9ibHVldG9vdGgvYnR1c2IuYyB8IDIw ICsrKysrKysrKysrKy0tLS0tLS0tCj4gMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyks IDggZGVsZXRpb25zKC0pCgpwYXRjaCBoYXMgYmVlbiBhcHBsaWVkIHRvIGJsdWV0b290aC1uZXh0 IHRyZWUuCgpSZWdhcmRzCgpNYXJjZWwKLS0tClRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0 OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEg bWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8g YXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbAo=