From mboxrd@z Thu Jan  1 00:00:00 1970
From: Frediano Ziglio <frediano.ziglio@citrix.com>
Subject: Re: [PATCH 4/5] Check no constructor section
Date: Wed, 6 Feb 2013 16:10:09 +0000
Message-ID: <7CE799CC0E4DE04B88D5FDF226E18AC201058D45836D@LONPMAILBOX01.citrite.net>
References: <1360161180-3448-1-git-send-email-frediano.ziglio@citrix.com>
	<1360161180-3448-5-git-send-email-frediano.ziglio@citrix.com>
	<51127E6302000078000BC834@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <51127E6302000078000BC834@nat28.tlf.novell.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "JBeulich@suse.com" <JBeulich@suse.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, "konrad@kernel.org" <konrad@kernel.org>, Frediano Ziglio <frediano.ziglio@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2013-02-06 at 15:01 +0000, Jan Beulich wrote:
> >>> On 06.02.13 at 15:32, Frediano Ziglio <frediano.ziglio@citrix.com> wrote:
> > Safety check for initialization objects.
> > Constructors are not used so check some module does not use them.
> 
> Once again - why?
> 
> And repeating earlier complaints of mine - why do you continue to
> re-post without having addressed all comments on prior revisions
> (verbally or by changing the patches)? This is just wasting
> reviewers' time.
> 
> Jan
> 

Nothing personal, I'm just a bad mail reader. In this case I checked
mails filtering with "cover" but your reply didn't have it on the
subject.

Sometimes I search if there are courses for reading mail but strangely
there are only courses on how use use some mail products or how to write
them.

Frediano

> > Signed-off-by: Frediano Ziglio <frediano.ziglio@citrix.com>
> > ---
> >  xen/Rules.mk |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/xen/Rules.mk b/xen/Rules.mk
> > index 3f0b262..ae35a08 100644
> > --- a/xen/Rules.mk
> > +++ b/xen/Rules.mk
> > @@ -166,7 +166,7 @@ SPECIAL_DATA_SECTIONS := rodata $(foreach n,1 2 4 
> > 8,rodata.str1.$(n)) \
> >  $(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): %.init.o: %.o Makefile
> >  	$(OBJDUMP) -h $< | sed -n '/[0-9]/{s,00*,0,g;p}' | while read idx name sz rest; 
> > do \
> >  		case "$$name" in \
> > -		.text|.text.*|.data|.data.*|.bss) \
> > +		.text|.text.*|.data|.data.*|.bss|.ctors) \
> >  			test $$sz != 0 || continue; \
> >  			echo "Error: size of $<:$$name is 0x$$sz" >&2; \
> >  			exit $$(expr $$idx + 1);; \
> > -- 
> > 1.7.9.5
> 
> 
>