Re: [PATCH 2/2][for-comments] omap3-sgx-modules: Add v4.08.00.01 of the SGX modules

["Maupin, Chase" <chase.maupin@ti.com>]

> -----Original Message-----
> From: Cooper Jr., Franklin
> Sent: Wednesday, October 10, 2012 11:23 AM
> To: Maupin, Chase; Franklin S. Cooper Jr; meta-
> ti@yoctoproject.org
> Subject: RE: [meta-ti] [PATCH 2/2][for-comments] omap3-sgx-
> modules: Add v4.08.00.01 of the SGX modules
> 
> 
> ________________________________________
> From: meta-ti-bounces@yoctoproject.org [meta-ti-
> bounces@yoctoproject.org] on behalf of Maupin, Chase
> Sent: Wednesday, October 10, 2012 10:55 AM
> To: Franklin S. Cooper Jr; meta-ti@yoctoproject.org
> Subject: Re: [meta-ti] [PATCH 2/2][for-comments] omap3-sgx-
> modules:     Add     v4.08.00.01 of the SGX modules
> 
> > -----Original Message-----
> > From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-
> > bounces@yoctoproject.org] On Behalf Of Franklin S. Cooper Jr
> > Sent: Tuesday, October 09, 2012 11:28 PM
> > To: meta-ti@yoctoproject.org
> > Subject: [meta-ti] [PATCH 2/2][for-comments] omap3-sgx-modules:
> > Add v4.08.00.01 of the SGX modules
> >
> > * Add version 4.08.00.01 of the SGX modules.
> >
> > Signed-off-by: Franklin S. Cooper Jr <fcooper@ti.com>
> > ---
> >  .../omap3-sgx-modules_4.08.00.01.bb                |   55
> > ++++++++++++++++++++
> >  1 files changed, 55 insertions(+), 0 deletions(-)
> >  create mode 100644 recipes-bsp/powervr-drivers/omap3-sgx-
> > modules_4.08.00.01.bb
> >
> > diff --git a/recipes-bsp/powervr-drivers/omap3-sgx-
> > modules_4.08.00.01.bb b/recipes-bsp/powervr-drivers/omap3-sgx-
> > modules_4.08.00.01.bb
> > new file mode 100644
> > index 0000000..f45934f
> > --- /dev/null
> > +++ b/recipes-bsp/powervr-drivers/omap3-sgx-
> modules_4.08.00.01.bb
> > @@ -0,0 +1,55 @@
> > +DESCRIPTION = "Kernel drivers for the PowerVR SGX chipset
> found
> > in the omap3 SoCs"
> > +LICENSE = "GPLv2"
> > +LIC_FILES_CHKSUM =
> > "file://COPYING;md5=ea5743acf520dd81ca172e69f818a3d4"
> > +
> > +TI_BIN_UNPK_CMDS="Y: qY:workdir:Y"
> > +require ../../recipes-ti/includes/ti-eula-unpack.inc
> > +
> > +SGXPV = "4_08_00_01"
> > +IMGPV = "1.7.867897"
> > +BINFILE = "Graphics_SDK_setuplinux_${SGXPV}.bin"
> > +
> > +inherit module
> > +
> > +MACHINE_KERNEL_PR_append = "a"
> 
> As we learned the other day MACHINE_KERNEL_PR adds a dependency
> on the kernel.bbclass in meta-openembedded.  Should this check if
> MACHINE_KERNEL_PR is defined before doing the append?
> 
> Franklin: MACHINE_KERNEL_PR is used by 25+ include files,patches
> and machine files within meta-ti as of today. With that being
> said your change does make sense. I can add that to v2

Denys,

As I asked before, what should we do about MACHINE_KERNEL_PR in general for meta-ti?  I know we want to move away from meta-oe dependencies, so should we be trying to add MACHINE_KERNEL_PR to oe-core?  I see a patch for this was submitted back in 2011 but not picked up (http://lists.linuxtogo.org/pipermail/openembedded-core/2011-September/010193.html).  There was a lot of discussion but still no conclusion.  There was talk about the autoPR making this unneeded, but I think people skipped the issue of recipes that should be re-built when the kernel changes.

So for now should we leave this alone but take the question back to oe-core about why not to use this feature?

> 
> > +PR = "${MACHINE_KERNEL_PR}"
> > +
> > +DEFAULT_PREFERENCE = "-1"
> > +
> > +SRC_URI = "<ti-internal-
> > url>/Graphics_SDK_setuplinux_4_08_00_01.bin"
> > +SRC_URI[md5sum] = "95b8f02923d6ea52ea104fa3d93ce1f0"
> > +SRC_URI[sha256sum] =
> >
> "1db2d46ec3c6a97db146357841e02a95a15be658c2297dc571e6e61b32238561
> > "
> > +
> > +TI_BIN_UNPK_WDEXT="/Graphics_SDK_${SGXPV}"
> > +S = "${WORKDIR}${TI_BIN_UNPK_WDEXT}/GFX_Linux_KM"
> > +
> > +PVRBUILD = "release"
> > +export KERNELDIR = "${STAGING_KERNEL_DIR}"
> > +
> > +INHIBIT_PACKAGE_STRIP = "1"
> > +
> > +TI_PLATFORM_omap3 = "omap3630"
> > +TI_PLATFORM_ti814x = "ti81xx"
> > +TI_PLATFORM_ti816x = "ti81xx"
> > +TI_PLATFORM_ti33x = "ti335x"
> > +
> > +MODULESLOCATION_omap3 = "dc_omapfb3_linux"
> > +MODULESLOCATION_ti814x = "dc_ti81xx_linux"
> > +MODULESLOCATION_ti816x = "dc_ti81xx_linux"
> > +MODULESLOCATION_ti33x = "dc_ti335x_linux"
> > +
> > +export SUPPORT_XORG ?= "${@base_contains('DISTRO_FEATURES',
> > 'x11', '1', '0', d)}"
> > +
> > +MAKE_TARGETS = " BUILD=${PVRBUILD} TI_PLATFORM=${TI_PLATFORM}
> > SUPPORT_XORG=${SUPPORT_XORG}"
> 
> What is this used for?
> 
> > +
> > +do_install() {
> > +    mkdir -p
> > ${D}/lib/modules/${KERNEL_VERSION}/kernel/drivers/gpu/pvr
> > +    cp  ${S}/pvrsrvkm.ko \
> > +        ${S}/services4/3rdparty/${MODULESLOCATION}/omaplfb.ko
> \
> > +
> ${S}/services4/3rdparty/bufferclass_ti/bufferclass_ti.ko
> > \
> > +
> > ${D}/lib/modules/${KERNEL_VERSION}/kernel/drivers/gpu/pvr
> > +
> > +     if [ "${SUPPORT_XORG}" = "1" ]; then
> > +         cp ${S}/services4/3rdparty/linux_drm/drm.ko
> > ${D}/lib/modules/${KERNEL_VERSION}/kernel/drivers/gpu/pvr
> > +     fi
> > +}
> > --
> > 1.7.0.4
> >
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti