From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: "Wu, Feng" <feng.wu@intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
"george.dunlap@eu.citrix.com" <george.dunlap@eu.citrix.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"dario.faggioli@citrix.com" <dario.faggioli@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
"jbeulich@suse.com" <jbeulich@suse.com>
Subject: Re: [PATCH v7 1/6] VMX: Permanently assign PI hook vmx_pi_switch_to()
Date: Sat, 12 Nov 2016 09:07:30 -0500 [thread overview]
Message-ID: <7E8CF409-7C0C-4CAD-BCA3-47149117F4D4@oracle.com> (raw)
In-Reply-To: <E959C4978C3B6342920538CF579893F0198C8773@SHSMSX104.ccr.corp.intel.com>
On November 12, 2016 4:14:50 AM EST, "Wu, Feng" <feng.wu@intel.com> wrote:
>> > diff --git a/xen/arch/x86/hvm/vmx/vmx.c
>b/xen/arch/x86/hvm/vmx/vmx.c
>> > index 3d330b6..10546af 100644
>> > --- a/xen/arch/x86/hvm/vmx/vmx.c
>> > +++ b/xen/arch/x86/hvm/vmx/vmx.c
>> > @@ -222,8 +222,13 @@ void vmx_pi_hooks_deassign(struct domain *d)
>> >
>> > d->arch.hvm_domain.vmx.vcpu_block = NULL;
>> > d->arch.hvm_domain.vmx.pi_switch_from = NULL;
>> > - d->arch.hvm_domain.vmx.pi_switch_to = NULL;
>> > d->arch.hvm_domain.vmx.pi_do_resume = NULL;
>> > +
>> > + /*
>> > + * In fact, we could remove 'vmx_pi_switch_to' inside itself
>if no new
>> device
>>
>> I am having a hard time parsing that. What is the 'inside itself'?
>
>Thanks for your review. It means we could set '
>d->arch.hvm_domain.vmx.pi_switch_to'
>to NULL in vmx_pi_switch_to(). It would be good if you have any better
>description! :)
Your above description is perfect:
"We could set d-arch.hvm_domain.vmx.pi_switch_to
to NULL in vmx_pi_switch_to() if no new device ..."
Thanks!
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-11-12 14:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 8:07 [PATCH v7 0/6] VMX: Properly handle pi descriptor and per-cpu blocking list Feng Wu
2016-11-07 8:07 ` [PATCH v7 1/6] VMX: Permanently assign PI hook vmx_pi_switch_to() Feng Wu
2016-11-11 18:28 ` Konrad Rzeszutek Wilk
2016-11-12 9:14 ` Wu, Feng
2016-11-12 14:07 ` Konrad Rzeszutek Wilk [this message]
2016-11-07 8:07 ` [PATCH v7 2/6] VMX: Properly handle pi when all the assigned devices are removed Feng Wu
2016-11-07 16:53 ` Jan Beulich
2016-11-07 8:08 ` [PATCH v7 3/6] VMX: Make sure PI is in proper state before install the hooks Feng Wu
2016-11-07 8:08 ` [PATCH v7 4/6] VT-d: No need to set irq affinity for posted format IRTE Feng Wu
2016-11-07 8:08 ` [PATCH v7 5/6] VT-d: Some cleanups Feng Wu
2016-11-11 18:24 ` Konrad Rzeszutek Wilk
2016-11-07 8:08 ` [PATCH v7 6/6] VMX: Fixup PI descriptor when cpu is offline Feng Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7E8CF409-7C0C-4CAD-BCA3-47149117F4D4@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=feng.wu@intel.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.