From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars Kurth Subject: Re: [PATCH 1/5] xen/arm: Introduce enable callback to enable a capabilities on each online CPU Date: Wed, 17 Jan 2018 12:23:33 +0000 Message-ID: <7F2FA84A-2CBA-45EC-9073-7FC86205BE5A@gmail.com> References: <20180116142337.24942-1-julien.grall@linaro.org> <20180116142337.24942-2-julien.grall@linaro.org> <3f287ea5-f122-b375-4d98-e33733516816@linaro.org> Mime-Version: 1.0 (Mac OS X Mail 11.2 \(3445.5.20\)) Content-Type: multipart/mixed; boundary="===============2619264010388236959==" Return-path: In-Reply-To: <3f287ea5-f122-b375-4d98-e33733516816@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Julien Grall Cc: Stefano Stabellini , andre.przywara@linaro.org, xen-devel List-Id: xen-devel@lists.xenproject.org --===============2619264010388236959== Content-Type: multipart/alternative; boundary="Apple-Mail=_B66324FC-9B36-4557-B9E1-47A20503A4A1" --Apple-Mail=_B66324FC-9B36-4557-B9E1-47A20503A4A1 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On 17 Jan 2018, at 10:31, Julien Grall = wrote: >=20 > Hi Stefano, >=20 > On 16/01/18 23:55, Stefano Stabellini wrote: >> On Tue, 16 Jan 2018, Julien Grall wrote: >>> Once Xen knows what features/workarounds present on the platform, it >>> might be necessary to configure each online CPU. >>>=20 >>> Introduce a new callback "enable" that will be called on each online = CPU to >>> configure the "capability". >>>=20 >>> The code is based on Linux v4.14 (where cpufeature.c comes from), = the >>> explanation of why using stop_machine_run is kept as we have similar >>> problem in the future. >>>=20 >>> Lastly introduce enable_errata_workaround that will be called once = CPUs >>> have booted and before the hardware domain is created. >>>=20 >>> This is part of XSA-254. >>>=20 >>> Signed-of-by: Julien Grall >> If you took the code from Linux, you need to add the original >> Signed-off-by from the Linux commit. Aside from that: >=20 > There are multiple commits touching this function. So I followed what = we did in similar situation. By that I mean, mentioning the code was = taken from Linux and not gathered the signed-off-by. >=20 > If you really want, I can gather all the signed-off-by of the commit = touching this function. If there are a lot of then, you may want to consider adding a = README.source file instead. There are a few examples in tree and they = are also mentioned in CONTRIBUTING files Lars --Apple-Mail=_B66324FC-9B36-4557-B9E1-47A20503A4A1 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On 17 Jan 2018, at 10:31, Julien Grall <julien.grall@linaro.org> wrote:

Hi = Stefano,

On 16/01/18 23:55, = Stefano Stabellini wrote:
On Tue, 16 Jan 2018, Julien = Grall wrote:
Once Xen = knows what features/workarounds present on the platform, it
might be necessary to configure each online CPU.

Introduce a new callback "enable" that will be = called on each online CPU to
configure the = "capability".

The code is based on Linux = v4.14 (where cpufeature.c comes from), the
explanation of = why using stop_machine_run is kept as we have similar
problem in the future.

Lastly = introduce enable_errata_workaround that will be called once CPUs
have booted and before the hardware domain is created.

This is part of XSA-254.

Signed-of-by: Julien Grall <julien.grall@linaro.org>
If = you took the code from Linux, you need to add the original
Signed-off-by from the Linux commit. Aside from that:

There are multiple = commits touching this function. So I followed what we did in similar = situation. By that I mean, mentioning the code was taken from Linux and = not gathered the signed-off-by.

If you really want, I can gather all the = signed-off-by of the commit touching this function.

If there are a = lot of then, you may want to consider adding a README.source file = instead. There are a few examples in tree and they are also mentioned = in CONTRIBUTING files
Lars

= --Apple-Mail=_B66324FC-9B36-4557-B9E1-47A20503A4A1-- --===============2619264010388236959== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============2619264010388236959==--