From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752844AbbCKPNB (ORCPT ); Wed, 11 Mar 2015 11:13:01 -0400 Received: from senator.holtmann.net ([87.106.208.187]:47888 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821AbbCKPNA (ORCPT ); Wed, 11 Mar 2015 11:13:00 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: efivarfs and writev() support From: Marcel Holtmann In-Reply-To: <20150311134226.GB24174@codeblueprint.co.uk> Date: Wed, 11 Mar 2015 08:12:52 -0700 Cc: Linux Kernel Mailing List , linux-efi@vger.kernel.org, Matthew Garrett , Jeremy Kerr , Matt Fleming , Al Viro Content-Transfer-Encoding: 7bit Message-Id: <7F5112DD-6998-47D3-B6B9-5618E14E022A@holtmann.org> References: <33E85F72-FCA0-4DF7-B9E1-46D36244FCA3@holtmann.org> <20150311134226.GB24174@codeblueprint.co.uk> To: Matt Fleming X-Mailer: Apple Mail (2.2070.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matt, >> it seems that efivarfs only supports readv(), but when it comes to >> writev(), I am getting an error. Is there any reason to not support >> vectored write on this filesystem? Especially with the uint32 header >> for each file, I think it would make perfect sense to support it. > > What error are you seeing? I thought that the vfs fell back to a looped > write if the file system doesn't support .write_iter()? that seems to work for readv(), but not for writev(). > But yes, we definitely should support writev(). I just get an EIO error and have not traced this down any further. Regards Marcel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Holtmann Subject: Re: efivarfs and writev() support Date: Wed, 11 Mar 2015 08:12:52 -0700 Message-ID: <7F5112DD-6998-47D3-B6B9-5618E14E022A@holtmann.org> References: <33E85F72-FCA0-4DF7-B9E1-46D36244FCA3@holtmann.org> <20150311134226.GB24174@codeblueprint.co.uk> Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150311134226.GB24174-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Fleming Cc: Linux Kernel Mailing List , linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Matthew Garrett , Jeremy Kerr , Matt Fleming , Al Viro List-Id: linux-efi@vger.kernel.org Hi Matt, >> it seems that efivarfs only supports readv(), but when it comes to >> writev(), I am getting an error. Is there any reason to not support >> vectored write on this filesystem? Especially with the uint32 header >> for each file, I think it would make perfect sense to support it. > > What error are you seeing? I thought that the vfs fell back to a looped > write if the file system doesn't support .write_iter()? that seems to work for readv(), but not for writev(). > But yes, we definitely should support writev(). I just get an EIO error and have not traced this down any further. Regards Marcel