From: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
To: Thomas Monjalon
<thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org"
<dev-VfR2kkLFssw@public.gmane.org>,
Hayato Momma <h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
Subject: [memnic PATCH v2] pmd: fix race condition
Date: Thu, 3 Apr 2014 06:35:06 +0000 [thread overview]
Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD0109D398@BPXM14GP.gisp.nec.co.jp> (raw)
From: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
There is a race condition, on transmit to host.
Guest PMD Host
Thread-A Thread-B vSwitch
|idx=0 |idx=0 |p[0] st!=2
|cmpxchg | |
|p[0] st->1 | |
|idx=1 | |
|fill data | |
|p[0] st->2 | |p[0] st==2
| | |receive data
| | |p[0] st->0
| |cmpxchg |
| |success |p[1] st!=2
| |p[0] st->1 |
This is BAD
That causes traffic stop.
We have to take care about that race condition with checking
whether current index is correct.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto-ehU+Cx/zZe18UrSeD/g0lQ@public.gmane.org>
Reviewed-by: Hayato Momma <h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org>
---
pmd/pmd_memnic.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/pmd/pmd_memnic.c b/pmd/pmd_memnic.c
index d833130..4a1c1e4 100644
--- a/pmd/pmd_memnic.c
+++ b/pmd/pmd_memnic.c
@@ -345,6 +345,15 @@ retry:
goto retry;
}
+ if (idx != ACCESS_ONCE(adapter->down_idx)) {
+ /*
+ * host freed this and got false positive,
+ * need to recover the status and retry.
+ */
+ p->status = MEMNIC_PKT_ST_FREE;
+ goto retry;
+ }
+
if (++idx >= MEMNIC_NR_PACKET)
idx = 0;
adapter->down_idx = idx;
--
1.8.4
next reply other threads:[~2014-04-03 6:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 6:35 Hiroshi Shimamoto [this message]
[not found] ` <7F861DC0615E0C47A872E6F3C5FCDDBD0109D398-ZmjkEB1lVlLt6d3pZDjeaEtBU8KWyXPq@public.gmane.org>
2014-04-11 14:41 ` [memnic PATCH v2] pmd: fix race condition Olivier MATZ
2014-04-11 15:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F861DC0615E0C47A872E6F3C5FCDDBD0109D398@BPXM14GP.gisp.nec.co.jp \
--to=h-shimamoto-ehu+cx/zze18ursed/g0lq@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=h-momma-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org \
--cc=thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.