From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751616AbbCJBnZ (ORCPT ); Mon, 9 Mar 2015 21:43:25 -0400 Received: from TYO202.gate.nec.co.jp ([210.143.35.52]:45913 "EHLO tyo202.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751188AbbCJBnY (ORCPT ); Mon, 9 Mar 2015 21:43:24 -0400 From: Hiroshi Shimamoto To: "jeffrey.t.kirsher@intel.com" , Or Gerlitz CC: "vyasevic@redhat.com" , "e1000-devel@lists.sourceforge.net" , "Choi, Sy Jong" , "linux-kernel@vger.kernel.org" , David Laight , Hayato Momma , "netdev@vger.kernel.org" , Edward Cree , =?utf-8?B?QmrDuHJuIE1vcms=?= Subject: Re: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control Thread-Topic: [E1000-devel] [PATCH v2 2/3] if_link: Add VF multicast promiscuous control Thread-Index: AdBa0s8csCgJ9marRbSM1FsrdZRa1Q== Date: Tue, 10 Mar 2015 01:42:22 +0000 Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD05E53671@BPXM14GP.gisp.nec.co.jp> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.205.5.123] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t2A1hWBa013937 > On 03/08/2015 02:15 PM, Or Gerlitz wrote: > > On Mon, Feb 23, 2015 at 11:14 PM, Jeff Kirsher > > wrote: > > [...] > >> We discussed this during NetConf last week, and Don is correct that a > >> custom sysfs interface is not the way we want to handle this. We agreed > >> upon a generic interface so that any NIC is able to turn on or off VF > >> multicast promiscuous mode. > > > > Jeff, please make sure to either respond to my comments on the V2 > > thread (or better) address them for the V3 post. > > > > > > http://marc.info/?l=linux-netdev&m=142441852518152&w=2 > > http://marc.info/?l=linux-netdev&m=142441867218183&w=2 > > I agree with you that the patch descriptions should be cleaned up and > "beefed" up for that matter. > > If/when I look to push his series of patches, I will make sure that your > concerns are addressed so that we can get a accurate changelog. I see that the patchset should have better explanation in changelog. I will rewrite it and submit again. Jeff, are you planning to drop the patchset from your tree? I just concerned which tree I should create patches against for. thanks, Hiroshi {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hiroshi Shimamoto Subject: Re: [PATCH v2 2/3] if_link: Add VF multicast promiscuous control Date: Tue, 10 Mar 2015 01:42:22 +0000 Message-ID: <7F861DC0615E0C47A872E6F3C5FCDDBD05E53671@BPXM14GP.gisp.nec.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "vyasevic@redhat.com" , "e1000-devel@lists.sourceforge.net" , "netdev@vger.kernel.org" , "Choi, Sy Jong" , "linux-kernel@vger.kernel.org" , David Laight , Hayato Momma , Edward Cree , =?utf-8?B?QmrDuHJuIE1vcms=?= To: "jeffrey.t.kirsher@intel.com" , Or Gerlitz Return-path: Content-Language: ja-JP List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: e1000-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org > On 03/08/2015 02:15 PM, Or Gerlitz wrote: > > On Mon, Feb 23, 2015 at 11:14 PM, Jeff Kirsher > > wrote: > > [...] > >> We discussed this during NetConf last week, and Don is correct that a > >> custom sysfs interface is not the way we want to handle this. We agreed > >> upon a generic interface so that any NIC is able to turn on or off VF > >> multicast promiscuous mode. > > > > Jeff, please make sure to either respond to my comments on the V2 > > thread (or better) address them for the V3 post. > > > > > > http://marc.info/?l=linux-netdev&m=142441852518152&w=2 > > http://marc.info/?l=linux-netdev&m=142441867218183&w=2 > > I agree with you that the patch descriptions should be cleaned up and > "beefed" up for that matter. > > If/when I look to push his series of patches, I will make sure that your > concerns are addressed so that we can get a accurate changelog. I see that the patchset should have better explanation in changelog. I will rewrite it and submit again. Jeff, are you planning to drop the patchset from your tree? I just concerned which tree I should create patches against for. thanks, Hiroshi ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired