From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: kvm_read_guest_page() missing kvm->srcu read lock? Date: Fri, 11 May 2018 13:43:21 +0200 Message-ID: <7a24f679-142b-9283-b7dc-f3d8e70c420a@redhat.com> References: <32913bee-6ccc-cab7-65fb-fb6896c3d19c@arm.com> <6a60301f-1fb7-a60a-d47a-85f7ea79b1a7@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: James Hogan , Marc Zyngier , Jan Glauber , Paul Mackerras , "kvmarm@lists.cs.columbia.edu" , David Gibson To: Andre Przywara , "kvm@vger.kernel.org" Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu List-Id: kvm.vger.kernel.org T24gMTEvMDUvMjAxOCAxMzowMiwgQW5kcmUgUHJ6eXdhcmEgd3JvdGU6Cj4gSGkgUGFvbG8sCj4g Cj4gdGhhbmtzIGZvciB0aGUgYW5zd2VyIQo+IFRvb2sgbWUgYSBiaXQsIGJ1dCBJIHRoaW5rIHlv dSBhcmUgcmlnaHQgKHNlZSBiZWxvdykuCj4gCj4gT24gMTAvMDUvMTggMTg6NDMsIFBhb2xvIEJv bnppbmkgd3JvdGU6Cj4+IE9uIDEwLzA1LzIwMTggMTk6NDEsIEFuZHJlIFByenl3YXJhIHdyb3Rl Ogo+Pj4gSGksCj4+Pgo+Pj4gSmFuIHBvc3RlZCBhbiBsb2NrZGVwIHNwbGF0IGNvbXBsYWluaW5n IGFib3V0IGEgc3VzcGljaW91cwo+Pj4gcmN1X2RlcmVmZXJlbmNlX2NoZWNrOgo+Pj4gaHR0cHM6 Ly9saXN0cy5jcy5jb2x1bWJpYS5lZHUvcGlwZXJtYWlsL2t2bWFybS8yMDE4LU1heS8wMzExMTYu aHRtbAo+Pj4KPj4+IFRoZSBnaXN0IG9mIHRoYXQgaXM6Cj4+PiAuLi4KPj4+IFsgMTAyNS42OTU1 MTddICBkdW1wX3N0YWNrKzB4OWMvMHhkNAo+Pj4gWyAxMDI1LjY5NTUyNF0gIGxvY2tkZXBfcmN1 X3N1c3BpY2lvdXMrMHhjYy8weDExOAo+Pj4gWyAxMDI1LjY5NTUzN10gIGdmbl90b19tZW1zbG90 KzB4MTc0LzB4MTkwCj4+PiBbIDEwMjUuNjk1NTQ2XSAga3ZtX3JlYWRfZ3Vlc3QrMHg1MC8weGIw Cj4+PiBbIDEwMjUuNjk1NTUzXSAgdmdpY19pdHNfY2hlY2tfaWQuaXNyYS4wKzB4MTE0LzB4MTQ4 Cj4+PiAuLi4KPj4+IEkgY2hhc2VkIHRoYXQgZG93biBhbmQgd29uZGVyIGlmIGt2bV9yZWFkX2d1 ZXN0eyxfcGFnZX0gaXMgc3VwcG9zZWQgdG8KPj4+IGJlIGNhbGxlZCBpbnNpZGUgYSBrdm0tPnNy Y3UgY3JpdGljYWwgc2VjdGlvbj8KPj4+Cj4+PiBXZSBoYXZlIGEgY2hlY2sgdGhhdCBzdWdnZXN0 cyB0aGF0IGV2ZW50dWFsbHkgc29tZW9uZSBuZWVkcyB0byBlbnRlciB0aGUKPj4+IFNSQ1UgY3Jp dGljaWFsIHNlY3Rpb246Cj4+PiBzdGF0aWMgaW5saW5lIHN0cnVjdCBrdm1fbWVtc2xvdHMgKl9f a3ZtX21lbXNsb3RzKHN0cnVjdCBrdm0gKmt2bSwKPj4+IAkJCQkJCSAgaW50IGFzX2lkKQo+Pj4g ewo+Pj4gICAgICAgICByZXR1cm4gc3JjdV9kZXJlZmVyZW5jZV9jaGVjayhrdm0tPm1lbXNsb3Rz W2FzX2lkXSwgJmt2bS0+c3JjdSwKPj4+ICAgICAgICAgICAgICAgICAgICAgICAgIGxvY2tkZXBf aXNfaGVsZCgma3ZtLT5zbG90c19sb2NrKSB8fAo+Pj4gICAgICAgICAgICAgICAgICAgICAgICAg IXJlZmNvdW50X3JlYWQoJmt2bS0+dXNlcnNfY291bnQpKTsKPj4+IH0KPj4+Cj4+PiBJZiBJIGdl dCB0aGlzIGNvcnJlY3RseSB0aGlzIG1lYW4gZm9yIGFjY2Vzc2luZyBrdm0tPm1lbXNsb3RzIHdl IGVpdGhlcgo+Pj4gbmVlZCB0byBiZSBpbnNpZGUgYW4gc3JjdSBjcml0aWNhbCBzZWN0aW9uIG9y IGhvbGQgdGhlIGt2bS0+c2xvdHNfbG9jawo+Pj4gKGZvciB1cGRhdGVzIG9ubHkpLgo+Pj4KPj4+ IElmIEkgYW0gbm90IG1pc3Rha2VuLCBpdCBpcyBub3QgbmVjZXNzYXJ5IGZvciAqY2FsbGVycyog b2YKPj4+IGt2bV9yZWFkX2d1ZXN0X3BhZ2UoKSB0byBkbyB0aGlzLCBhcyB0aGlzIGNvdWxkIGJl IGVudGlyZWx5IGNvbnRhaW5lZAo+Pj4gaW5zaWRlIHRoaXMgZnVuY3Rpb24gLSBzaW5jZSB3ZSBv bmx5IHVzZSB0aGUgcmVmZXJlbmNlIHRvIHRoZSBtZW1zbG90Cj4+PiBlbnRyeSB3aGlsZSBkb2lu ZyB0aGUgY29weV9mcm9tX3VzZXIoKSwgYW5kIHRoZSBkYXRhIGlzIHNhZmUgYWZ0ZXJ3YXJkcwo+ Pj4gZnJvbSBhbiBSQ1UgcG9pbnQgb2YgdmlldyBiZWNhdXNlIGl0IGhhcyBiZWVuICpjb3BpZWQq Lgo+Pgo+PiBZZXMsIGl0J3MgdGhlIGNhbGxlcidzIHJlc3BvbnNpYmlsaXR5LiAgc3JjdV9yZWFk X2xvY2svdW5sb2NrIGlzIHByZXR0eQo+PiBleHBlbnNpdmUKPiAKPiBJcyB0aGF0IHNvPyBJIHdh cyB1bmRlciB0aGUgaW1wcmVzc2lvbiB0aGF0IGRlY2xhcmluZyBSQ1UgY3JpdGljYWwKPiBzZWN0 aW9ucyBpcyB2ZXJ5IGNoZWFwLCBpcyB0aGF0IGRpZmZlcmVudCB3aXRoIFNSQ1U/CgpZZXMsIGJl Y2F1c2UgUkNVIGVmZmVjdGl2ZWx5IGxldHMgdGhlIHNjaGVkdWxlciBkbyB0aGUgZXhwZW5zaXZl IHBhcnRzLgpXaXRoIFNSQ1UgeW91IGhhdmUgdG8gZG8gdGhlbSB5b3Vyc2VsZiB3aXRoIHRoZSBh ZHZhbnRhZ2UgdGhhdDogMSkgeW91CmNhbiBzbGVlcCBkdXJpbmcgUkNVIGNyaXRpY2FsIHNlY3Rp b25zOyAyKSBzeW5jaHJvbml6ZV9zcmN1IGlzIG11Y2gKY2hlYXBlciB0aGFuIHN5bmNocm9uaXpl X3JjdSBhbmQgc3luY2hyb25pemVfc2NoZWQuCgpJdCBpcyBzdGlsbCByZWxhdGl2ZWx5IGNoZWFw LCBhbmQgaXQgZG9lc24ndCBzZXJpYWxpemUgYWdhaW5zdCB3cml0ZXJzLApidXQgdGhlIG9yZGVy IG9mIG1hZ25pdHVkZSBpcyAxMDAgY2xvY2sgY3ljbGVzIGZvciBlYWNoIG9mIGxvY2sgYW5kCnVu bG9jay4gIENvbXBhcmVkIHdpdGggcmN1X3JlYWRfbG9jay91bmxvY2ssIHdoaWNoIGFyZSBub3Bz IG9uIGFueQprZXJuZWwgYnV0IFBSRUVNUFRfUlQsIHRoYXQgY291bnRzIGFzIGV4cGVuc2l2ZS4g OikKCj4+IHNvIEtWTSBhc3N1bWVzIHRoYXQgdGhlIHRvcG1vc3QgY2FsbGVycyBkbyBpdC4KPiAK PiBPSywgZmFpciBlbm91Z2guIEFuZCB3aXRoIHNvbWUgaGludHMgZnJvbSBKw7ZyZyBJIHVuZGVy c3RhbmQgbm93IHRoYXQgeDg2Cj4gYW5kIHMzOTAgZG8gYSAic3JjdV9yZWFkX2xvY2soJmt2bS0+ c3JjdSk7IiByaWdodCBhZnRlciBsZWF2aW5nIHRoZQo6PiBndWVzdCBhbmQgdW5sb2NrIGl0IG9u bHkgc2hvcnRseSBiZWZvcmUgZW50ZXJpbmcgYWdhaW4sIHNvIHRoYXQgYW55Cj4gaW50ZXJtZWRp YXRlIGNhbGxzIGFyZSBwcm90ZWN0ZWQuIFRoYXQgbGVhdmVzIHRoZSBsb2NraW5nIGR1dHkgb25s eSB1cAo+IHRvIGNhbGxzIG9yaWdpbmF0aW5nIGZyb20gdXNlcnNwYWNlLgo+IEJ1dCBBRkFJQ1Qg bmVpdGhlciBtaXBzLCBwb3dlcnBjIG9yIGFybS9hcm02NCBhcmUgZG9pbmcgdGhpcy4gSSBhbQo+ IGNoZWNraW5nIG5vdyB3aGV0aGVyIHRoaXMgaXMgYW4gb21pc3Npb24gb3Igd2hldGhlciB0aGV5 IGFyZSByZWFsbHkKPiBkb2luZyBmaW5lIGdyYWluZWQgbG9ja2luZyBmb3IgYWxsIG1lbXNsb3Rz IGFjY2Vzc2VzLgoKT2ssIGxldCBtZSBDYyB0aGUgbWFpbnRhaW5lcnMuICBJIHN1cHBvc2UgYXQg bGVhc3Qgc29tZSBvZiB0aGVtIGRvIHVzZQpsb2NrZGVwIGZyb20gdGltZSB0byB0aW1lLCBidXQg aXQgaXMgY2VydGFpbmx5IHBvc3NpYmxlIHRoYXQgc29tZSBjYXNlcwpoYXZlIGJlZW4gbWlzc2Vk LgoKQWRkaW5nIHRoZSBzcmN1X3JlYWRfbG9jay91bmxvY2sgZGlyZWN0bHkgaW4ga3ZtX2FyY2hf dmNwdV9pb2N0bF9ydW4gYW5kCmFueSBvdGhlciBpb2N0bHMgdGhhdCBuZWVkIGl0IGlzIGJlc3Qs IGJ1dCBpbiBhbnkgY2FzZSBhZGRpbmcgbW9yZSBwYWlycwppcyBzYWZlIGJlY2F1c2UgdGhleSBj YW4gYmUgbmVzdGVkLgoKVGhhbmtzIGZvciB0aGUgcmVwb3J0IQoKUGFvbG8KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdApr dm1hcm1AbGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1 L21haWxtYW4vbGlzdGluZm8va3ZtYXJtCg==