From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bombadil.infradead.org ([198.137.202.133]:40012 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729626AbeGMQ6c (ORCPT ); Fri, 13 Jul 2018 12:58:32 -0400 Subject: Re: [PATCH] hostap: hide unused procfs helpers To: Arend van Spriel , YueHaibing , j@w1.fi, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, davem@davemloft.net References: <20180713070317.6724-1-yuehaibing@huawei.com> <5B485441.1080305@broadcom.com> From: Randy Dunlap Message-ID: <7a2dee6c-eca3-ca0f-8af6-2ecc14f6d0a9@infradead.org> (sfid-20180713_184320_169060_32810EED) Date: Fri, 13 Jul 2018 09:43:05 -0700 MIME-Version: 1.0 In-Reply-To: <5B485441.1080305@broadcom.com> Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 07/13/2018 12:26 AM, Arend van Spriel wrote: > + Randy > > On 7/13/2018 9:03 AM, YueHaibing wrote: >> When CONFIG_PROC_FS isn't set, gcc warning this: >> >> drivers/net/wireless/intersil/hostap/hostap_hw.c:2901:12: warning: ‘prism2_registers_proc_show’ defined but not used [-Wunused-function] >>   static int prism2_registers_proc_show(struct seq_file *m, void *v) >> >> drivers/net/wireless/intersil/hostap/hostap_proc.c:16:12: warning: ‘prism2_debug_proc_show’ defined but not used [-Wunused-function] >>   static int prism2_debug_proc_show(struct seq_file *m, void *v) >>              ^ >> drivers/net/wireless/intersil/hostap/hostap_proc.c:49:12: warning: ‘prism2_stats_proc_show’ defined but not used [-Wunused-function] >>   static int prism2_stats_proc_show(struct seq_file *m, void *v) >>              ^ >> drivers/net/wireless/intersil/hostap/hostap_proc.c:177:12: warning: ‘prism2_crypt_proc_show’ defined but not used [-Wunused-function] >>   static int prism2_crypt_proc_show(struct seq_file *m, void *v) >>              ^ >> >> fix this by adding #ifdef around them. >> hfa384x_read_reg is only used by prism2_registers_proc_show,so move it >> into #ifdef. > > There was already a fix for this posted by Randy Dunlap taking a different approach, ie. use __maybe_unused classifier. To be honest I prefer the ifdef approach as it is more explicit and does not feel like a cheat. Hi, You are welcome to merge (or ack or have someone else merge) either of them. I'm not counting patches, just trying to help out (in this case by reducing noise). > Actually some of the functions are between a flag already PRISM2_NO_PROCFS_DEBUG which is in a private header file hostap_config.h. Seems like this would be better placed in Kconfig and depend on CONFIG_PROCFS. Anyway, this driver is old cruft. Maybe some people are still running it, but it is probably not worth the effort so fine with either fix. > > Regards, > Arend -- ~Randy