Re: [PATCH v2] gpio: xilinx: Add interrupt support

From: Michal Simek <michal.simek@xilinx.com>
To: Robert Hancock <hancock@sedsystems.ca>,
	Linus Walleij <linus.walleij@linaro.org>,
	Michal Simek <michal.simek@xilinx.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Srinivas Neeli <srinivas.neeli@xilinx.com>
Subject: Re: [PATCH v2] gpio: xilinx: Add interrupt support
Date: Wed, 8 Jul 2020 13:20:45 +0200	[thread overview]
Message-ID: <7a39d894-e5ff-283d-650d-a0a2f64b350b@xilinx.com> (raw)
In-Reply-To: <d7313b79-1fcd-d04d-fdae-cae1c8c5c233@sedsystems.ca>

On 07. 07. 20 18:16, Robert Hancock wrote:
> On 2020-07-07 5:09 a.m., Linus Walleij wrote:
>> On Thu, Jun 11, 2020 at 6:51 PM Robert Hancock <hancock@sedsystems.ca>
>> wrote:
>>
>>> Adds interrupt support to the Xilinx GPIO driver so that rising and
>>> falling edge line events can be supported. Since interrupt support is
>>> an optional feature in the Xilinx IP, the driver continues to support
>>> devices which have no interrupt provided.
>>>
>>> These changes are based on a patch in the Xilinx Linux Git tree,
>>> "gpio: xilinx: Add irq support to the driver" from Srinivas Neeli, but
>>> include a number of fixes and improvements such as supporting both
>>> rising and falling edge events.
>>>
>>> Signed-off-by: Robert Hancock <hancock@sedsystems.ca>
>>> ---
>>>
>>> Changes from v1: Changed platform_get_irq to platform_get_irq_optional
>>
>> Looks good to me, two questions:
>>
>> - Can you make sure that this applies to the GPIO "devel" branch
>>    that has the previous changes from Srinivas.
> 
> I confirmed it applies without conflicts and builds on that branch - it
> doesn't appear that it has any changes to this driver that were not in
> the version I submitted against.
> 
>>
>> - Can we get a Tested-by or at least ACK from Srinivas?
>>
>> This driver currently lacks a maintainer. I would be very happy if
>> Srinivas or Robert or both would send a patch to add you as
>> maintainer(s) in the MAINTAINERS file, and would also like
>> Michal to to ACK that so everyone is happy.
> 
> Probably Srinivas or someone from Xilinx should be the primary
> maintainer of this driver, but I could add myself in if they don't..

This driver is covered also by my fragment but I am happy if Srinivas
can be in this position. If something happens I am around to help to
resolve any issue with it.

Srinivas: Please send the fragment for this driver and record your name
there. Feel free to add me with R:  Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal