All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: chenbo.xia@intel.com
Subject: Re: [PATCH 1/2] vhost: remove unneeded max enums
Date: Thu, 5 May 2022 16:22:31 +0200	[thread overview]
Message-ID: <7a460685-57af-c6df-132c-82d97bfcaeac@redhat.com> (raw)
In-Reply-To: <20220425125431.26464-1-david.marchand@redhat.com>

Hi David,

On 4/25/22 14:54, David Marchand wrote:
> Move message handler description and callbacks into a single array and
> remove unneeded VHOST_USER_MAX and VHOST_SLAVE_MAX enums.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   drivers/net/virtio/virtio_user/vhost_user.c |   1 -
>   examples/vhost_blk/blk_spec.h               |   1 -
>   lib/vhost/vhost_user.c                      | 175 +++++++++-----------
>   lib/vhost/vhost_user.h                      |   2 -
>   4 files changed, 76 insertions(+), 103 deletions(-)
> 

The patch does a bit more than what the commit title mentions.
What about: "vhost: refactor messages handlers declaration"?

Other than that, the patch content looks good to me:

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  parent reply	other threads:[~2022-05-05 14:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 12:54 [PATCH 1/2] vhost: remove unneeded max enums David Marchand
2022-04-25 12:54 ` [PATCH 2/2] vhost: validate fds attached to messages David Marchand
2022-05-05 14:31   ` Maxime Coquelin
2022-05-05 19:58   ` Maxime Coquelin
2022-05-05 14:22 ` Maxime Coquelin [this message]
2022-05-05 19:57 ` [PATCH 1/2] vhost: remove unneeded max enums Maxime Coquelin
2022-05-06  7:12   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a460685-57af-c6df-132c-82d97bfcaeac@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.