Re: [PATCH v2 4/7] target/ppc: overhauled and moved logic of storing fpscr

From: Richard Henderson <richard.henderson@linaro.org>
To: "Bruno Larsen (billionai)" <bruno.larsen@eldorado.org.br>,
	qemu-devel@nongnu.org
Cc: farosas@linux.ibm.com, luis.pires@eldorado.org.br,
	lucas.araujo@eldorado.org.br, fernando.valle@eldorado.org.br,
	qemu-ppc@nongnu.org, matheus.ferst@eldorado.org.br,
	david@gibson.dropbear.id.au
Subject: Re: [PATCH v2 4/7] target/ppc: overhauled and moved logic of storing fpscr
Date: Wed, 19 May 2021 11:05:26 -0500	[thread overview]
Message-ID: <7a4c0761-45aa-be4f-83b9-c753d6667790@linaro.org> (raw)
In-Reply-To: <20210518150515.57983-5-bruno.larsen@eldorado.org.br>

On 5/18/21 10:05 AM, Bruno Larsen (billionai) wrote:
> Followed the suggested overhaul to store_fpscr logic, and moved it to
> cpu.c where it can be accessed in !TCG builds.
> 
> The overhaul was suggesting because storing a value to fpscr should
> never raise an exception, so we could remove all the mess that happened
> with POWERPC_EXCP_FP.
> 
> We also moved fpscr_set_rounding_mode into cpu.c as it could now be moved
> there, and it is needed when a value for the fpscr is being stored
> directly.
> 
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Bruno Larsen (billionai)<bruno.larsen@eldorado.org.br>
> ---
>   target/ppc/cpu.c        |  43 ++++++++
>   target/ppc/cpu.h        |  12 +-
>   target/ppc/fpu_helper.c | 238 +++-------------------------------------
>   target/ppc/gdbstub.c    |   6 +-
>   4 files changed, 65 insertions(+), 234 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~