From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Goldschmidt Date: Tue, 30 Apr 2019 20:24:47 +0200 Subject: [U-Boot] [PATCH 1/2 v2] fit: Support compression for non-kernel components (e.g. FDT) In-Reply-To: References: <20190418210850.210461-1-jwerner@chromium.org> <20190418210850.210461-2-jwerner@chromium.org> Message-ID: <7a4c84a5-00f3-690f-531e-b5e61a45125a@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am 30.04.2019 um 06:05 schrieb Simon Goldschmidt: > > > Julius Werner > > schrieb am Di., 30. Apr. 2019, 02:38: > > > However, compared to my above mentioned RFC patch, this here somehow > > fails when loading something from the image, e.g. using the cmd 'fpga > > loadmk'. Seems like this one doesn't transparently uncompress? > > It looks to me like do_fpga_loadmk() doesn't actually call > fit_load_image()? It calls fit_image_get_data() directly, so it > bypasses the code I'm adding. Maybe it should be using > fit_load_image() instead, but that's moving pretty far away from what > I was trying to do... it could be left for a later patch? > > > Ah, ok. I wasn't aware I had changed that command too :-) let me > concentrate on finding out why booting the compressed fit,image doesn't > work, then. OK, so it turns out the error was on my side somewhere. I tested this with a known-to-work configuration at work today and it works like a charm, so I'll start to comment the contents of the patch again ;-) Regards, Simon