From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A507C7618A for ; Sun, 19 Mar 2023 06:16:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 740E983AA4; Sun, 19 Mar 2023 07:16:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id E7DFC85283; Sun, 19 Mar 2023 07:16:55 +0100 (CET) Received: from mail-m11874.qiye.163.com (mail-m11874.qiye.163.com [115.236.118.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 32CD6839AD for ; Sun, 19 Mar 2023 07:16:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [192.168.0.116] (unknown [112.49.5.143]) by mail-m11874.qiye.163.com (Hmail) with ESMTPA id 27B2F3C00F9; Sun, 19 Mar 2023 14:16:34 +0800 (CST) Message-ID: <7a4d1e68-ff63-0278-c02c-06cd23967cf7@rock-chips.com> Date: Sun, 19 Mar 2023 14:16:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 12/12] rockchip: Convert rk35xx to use standard boot Content-Language: en-US To: Jonas Karlman , Simon Glass , Philipp Tomsich Cc: Jagan Teki , Eugen Hristev , u-boot@lists.denx.de References: <20230314003755.512696-1-jonas@kwiboo.se> <20230314003755.512696-13-jonas@kwiboo.se> From: Kever Yang In-Reply-To: <20230314003755.512696-13-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWS1ZQUlXWQ8JGhUIEh9ZQVlDQh0eVk8fTx8dQxgdTUkZH1UTARMWGhIXJBQOD1 lXWRgSC1lBWUpKSVVPQlVOVUpPSFlXWRYaDxIVHRRZQVlPS0hVSkpLSEpDVUpLS1VLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Nk06Iww6Tj0PKRMsAz0qMB4o LFEaCwJVSlVKTUxCSUtNTkJPTE5KVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlKSklVT0JVTlVKT0hZV1kIAVlBT0NMSDcG X-HM-Tid: 0a86f883372c2eb0kusn27b2f3c00f9 X-HM-MType: 1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Jonas,     I will pick other patches for fix of this series, and leave this one after the patch set[0] from Simon get land. Thanks, - Kever https://patchwork.ozlabs.org/project/uboot/patch/20230302033930.2546548-7-sjg@chromium.org/ On 2023/3/14 08:38, Jonas Karlman wrote: > Imply use of BOOTSTD and OF_LIBFDT_OVERLAY on RK3568 and RK3588. > Drop the use of scripts and rely on standard boot for all operation. > > Signed-off-by: Jonas Karlman > --- > arch/arm/mach-rockchip/Kconfig | 6 ++++++ > include/configs/rk3568_common.h | 9 +++++++-- > include/configs/rk3588_common.h | 9 +++++++-- > 3 files changed, 20 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig > index e5ac58ae60b5..5e8aacc2ea14 100644 > --- a/arch/arm/mach-rockchip/Kconfig > +++ b/arch/arm/mach-rockchip/Kconfig > @@ -289,6 +289,9 @@ config ROCKCHIP_RK3568 > select DM_REGULATOR_FIXED > select DM_RESET > imply ROCKCHIP_COMMON_BOARD > + imply BOOTSTD_BOOTCOMMAND > + imply BOOTSTD_DEFAULTS > + imply OF_LIBFDT_OVERLAY > imply ROCKCHIP_OTP > imply MISC_INIT_R > help > @@ -310,6 +313,9 @@ config ROCKCHIP_RK3588 > select SYSCON > select BOARD_LATE_INIT > imply ROCKCHIP_COMMON_BOARD > + imply BOOTSTD_BOOTCOMMAND > + imply BOOTSTD_DEFAULTS > + imply OF_LIBFDT_OVERLAY > imply ROCKCHIP_OTP > imply MISC_INIT_R > help > diff --git a/include/configs/rk3568_common.h b/include/configs/rk3568_common.h > index a5e1dde50888..164c123d9490 100644 > --- a/include/configs/rk3568_common.h > +++ b/include/configs/rk3568_common.h > @@ -17,10 +17,15 @@ > > #define ENV_MEM_LAYOUT_SETTINGS \ > "scriptaddr=0x00c00000\0" \ > + "script_offset_f=0xffe000\0" \ > + "script_size_f=0x2000\0" \ > "pxefile_addr_r=0x00e00000\0" \ > "fdt_addr_r=0x0a100000\0" \ > + "fdtoverlay_addr_r=0x02000000\0" \ > "kernel_addr_r=0x02080000\0" \ > - "ramdisk_addr_r=0x0a200000\0" > + "ramdisk_addr_r=0x0a200000\0" \ > + "kernel_comp_addr_r=0x08000000\0" \ > + "kernel_comp_size=0x2000000\0" > > #include > #define CFG_EXTRA_ENV_SETTINGS \ > @@ -28,6 +33,6 @@ > "fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \ > "partitions=" PARTS_DEFAULT \ > ROCKCHIP_DEVICE_SETTINGS \ > - BOOTENV > + BOOTENV_BOOT_TARGETS > > #endif > diff --git a/include/configs/rk3588_common.h b/include/configs/rk3588_common.h > index abd20139aaf3..7ff0481a69fd 100644 > --- a/include/configs/rk3588_common.h > +++ b/include/configs/rk3588_common.h > @@ -16,10 +16,15 @@ > > #define ENV_MEM_LAYOUT_SETTINGS \ > "scriptaddr=0x00c00000\0" \ > + "script_offset_f=0xffe000\0" \ > + "script_size_f=0x2000\0" \ > "pxefile_addr_r=0x00e00000\0" \ > "fdt_addr_r=0x0a100000\0" \ > + "fdtoverlay_addr_r=0x02000000\0" \ > "kernel_addr_r=0x02080000\0" \ > - "ramdisk_addr_r=0x0a200000\0" > + "ramdisk_addr_r=0x0a200000\0" \ > + "kernel_comp_addr_r=0x08000000\0" \ > + "kernel_comp_size=0x2000000\0" > > #include > #define CFG_EXTRA_ENV_SETTINGS \ > @@ -27,6 +32,6 @@ > "partitions=" PARTS_DEFAULT \ > ENV_MEM_LAYOUT_SETTINGS \ > ROCKCHIP_DEVICE_SETTINGS \ > - BOOTENV > + BOOTENV_BOOT_TARGETS > > #endif /* __CONFIG_RK3588_COMMON_H */